<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";
mso-believe-normal-left:yes;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
p.rvps1, li.rvps1, div.rvps1
{mso-style-name:rvps1;
margin:0in;
margin-bottom:.0001pt;
text-align:center;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.rvts1
{mso-style-name:rvts1;
font-family:"Arial","sans-serif";
color:blue;
font-weight:bold;}
span.rvts2
{mso-style-name:rvts2;
font-family:"Arial","sans-serif";
color:navy;
font-weight:bold;}
span.rvts3
{mso-style-name:rvts3;
font-family:"Arial","sans-serif";
color:maroon;
font-style:italic;}
span.rvts4
{mso-style-name:rvts4;
font-family:"Arial","sans-serif";
color:green;
text-decoration:underline;}
span.rvts5
{mso-style-name:rvts5;
font-family:"Arial","sans-serif";
color:green;
text-decoration:underline;}
span.rvts6
{mso-style-name:rvts6;
font-family:"Tahoma","sans-serif";
color:white;
background:blue;
font-weight:bold;}
span.rvts7
{mso-style-name:rvts7;
font-family:"Calibri","sans-serif";
color:#454545;}
span.rvts9
{mso-style-name:rvts9;
font-family:"Arial","sans-serif";
color:silver;
font-style:italic;}
span.rvts10
{mso-style-name:rvts10;
font-family:"Arial","sans-serif";
color:blue;
text-decoration:underline;}
span.rvts8
{mso-style-name:rvts8;}
span.EmailStyle29
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<![if mso 9]>
<style>
p.MsoNormal
{margin-left:3.75pt;}
</style>
<![endif]><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor=white lang=EN-US link=blue vlink=purple style='margin-left:3.75pt;
margin-top:3.75pt;margin-right:3.75pt;margin-bottom:3.75pt'>
<div class=Section1>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>See the old codes, I think adding cast from void* to uint8_t*
would be ok.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Would you like submitting your</span> <span style='font-size:
11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>MSVS2005 project?<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Chang<o:p></o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal style='margin:0in;margin-bottom:.0001pt'><b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> x264-devel-bounces@videolan.org
[mailto:x264-devel-bounces@videolan.org] <b>On Behalf Of </b>Paul -Spawn-
Rysevets<br>
<b>Sent:</b> Monday, April 21, 2008 4:02 PM<br>
<b>To:</b> Mailing list for x264 developers<br>
<b>Subject:</b> Re: [x264-devel] Build issue<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>Hello
Chang,<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>Monday,
April 21, 2008, 7:38:14 AM, you wrote:<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>and what
about this solution?<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>-
CHECKED_MALLOC( frame->buffer[4+i],<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>-
frame->i_stride[0] * ( frame->i_lines[0] + 2*i_padv ) );<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>-
frame->filtered[i+1] = ((uint8_t*)frame->buffer[4+i])
+<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>-
frame->i_stride[0] * i_padv + PADH;<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
CHECKED_MALLOC( frame->buffer[i], luma_plane_size/4 );<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
frame->plane[i] = (uint8_t*)frame->buffer[i] +
(frame->i_stride[i] * i_padv + PADH)/2;<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>
}<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
/* all 4 luma planes allocated together, since the cacheline split code<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
* requires them to be in-phase wrt cacheline alignment. */<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
CHECKED_MALLOC( frame->buffer[0], 4*luma_plane_size);<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
for( i = 0; i < 4; i++ )<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
frame->filtered[i] = (uint8_t*)frame->buffer[0] +
i*luma_plane_size + frame->i_stride[0] * i_padv + PADH;<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>+
frame->plane[0] = frame->filtered[0];<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'>in this
case MSVS2005 says it's fine... and compiles it perfectly. (i've wrote that on
doom9 last week)<o:p></o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<div>
<table class=MsoNormalTable border=0 cellpadding=0>
<tr>
<td width=12 valign=top style='width:9.0pt;background:blue;padding:.75pt .75pt .75pt .75pt'>
<p><span class=rvts6><span style='font-size:11.0pt'>></span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
</td>
<td width=751 valign=top style='width:563.25pt;background:white;padding:.75pt .75pt .75pt .75pt'>
<p><span class=rvts7><span style='font-size:11.0pt'>Hi </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'> </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'>For the “cacheline split
workaround for mc_luma”</span></span><span style='font-size:9.0pt;font-family:
"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'> </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'>+ for( i = 1; i < 3; i++ )</span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'> {</span></span><span style='font-size:9.0pt;
font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'>- CHECKED_MALLOC(
frame->buffer[4+i],</span></span><span style='font-size:9.0pt;font-family:
"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'>-
frame->i_stride[0] * ( frame->i_lines[0] + 2*i_padv
) );</span></span><span style='font-size:9.0pt;font-family:"Courier New";
color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'>- frame->filtered[i+1] =
((uint8_t*)frame->buffer[4+i]) +</span></span><span style='font-size:9.0pt;
font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'>-
frame->i_stride[0] *
i_padv + PADH;</span></span><span style='font-size:9.0pt;font-family:"Courier New";
color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'>+ CHECKED_MALLOC(
frame->buffer[i], luma_plane_size/4 );</span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'>+ frame->plane[i] =
frame->buffer[i] + (frame->i_stride[i] * i_padv + PADH)/2;</span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts8><span style='font-size:9.0pt;font-family:"Courier New";
color:black'> }</span></span><span style='font-size:9.0pt;
font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'> </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'>This line would be
problematic, </span></span><span style='font-size:9.0pt;font-family:
"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'> </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'>frame->plane[i] =
frame->buffer[i] + (frame->i_stride[i] * i_padv + PADH)/2;</span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'> </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts7><span style='font-size:11.0pt'>the buffer array is
defined as “void *buffer[4];” and plane is defined as ”uint8_t
*plane[3]”, so it leads a compile issue at MSVC71 </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
</td>
</tr>
</table>
</div>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p> </o:p></span></p>
<p><span class=rvts9><span style='font-size:8.0pt'>-- </span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts9><span style='font-size:8.0pt'>Best regards,</span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
<p><span class=rvts9><span style='font-size:8.0pt'> Paul 'Spawn' Rysevets
</span></span><span style='font-size:9.0pt;
font-family:"Courier New";color:black'><a
href="mailto:P.Rysevets@sam-solutions.net"><span style='font-size:8.0pt;
font-family:"Arial","sans-serif"'>P.Rysevets@sam-solutions.net</span></a><o:p></o:p></span></p>
<p><span class=rvts9><span style='font-size:8.0pt'> SpAwN_gUy.aka.WAREZMasta
</span></span><span style='font-size:9.0pt;
font-family:"Courier New";color:black'><a href="mailto:WAREZMasta@gmail.com"><span
style='font-size:8.0pt;font-family:"Arial","sans-serif"'>WAREZMasta@gmail.com</span></a><o:p></o:p></span></p>
<p><span class=rvts9><span style='font-size:8.0pt'> ICQ(PRiMARY):968978
ICQ(Secondary):169588436</span></span><span
style='font-size:9.0pt;font-family:"Courier New";color:black'><o:p></o:p></span></p>
</div>
</body>
</html>