<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Thanks for your comments.</div><div><br></div><div>I corrected the variable names and converted the tabs, now I'm ready to run a few tests with the patch as you recommended. However, I can't compile x264 anymore with Xcode under Leopard. Logs report a problem I read about in this mailing list : the file cabac-a.asm fails to compile.</div><div>I don't wan to cross-post, so I won't ask for a solution for this particular problem, but does anyone know which is the latest version to compile flawlessly under Leopard? Now I'm stuck with this version which doesn't compile anymore, so I can't run any test...</div><div><br></div><div>Etienne</div><div><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 11px;"><i><br></i></span></font></div><div><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 11px;"><i><br></i></span></font></div><br><div><div>On 22 Apr 2008, at 20:24, Alex Izvorski wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi Etienne,<br><br>I've looked at it, and can confirm that at least with a couple of<br>combinations of settings it produces a good stream for jm13.2 and ffmpeg<br>decoding. The only changes I would suggest is some small tweaks to<br>variable names for consistency (slice_size_threshold =><br>i_slice_size_threshold, b_l => b_left?), and also perhaps you can<br>convert it to use spaces instead of tabs?<br><br>I haven't benchmarked single-slice encoding with vs without the patch,<br>nor have I tried using a mb-slicesize that would end slices in mid-row<br>(a special corner case would be mb-slicesize=1). Perhaps you or someone<br>could try and report your results?<br><br>Aside from those issues, I would like to see it applied in git, if<br>nobody objects. Good work.<br><br>Regards,<br>--Alex<br><br><br>On Tue, 2008-04-22 at 12:18 +0200, Etienne Bömcke wrote:<br><blockquote type="cite">Hi guys,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I'd like to get your attention one last time on the topic of multi- <br></blockquote><blockquote type="cite">sliced encoding. You'll find attached to this message the patch I <br></blockquote><blockquote type="cite">developped based on Mojtaba Hossein's work, adding support for <br></blockquote><blockquote type="cite">multiple slices during the encoding process. A new command-line option <br></blockquote><blockquote type="cite">has been added (--mb-slicesize) allowing one to specify the max number <br></blockquote><blockquote type="cite">of macroblock to be encoded in each slice, while the --no-mv-inter- <br></blockquote><blockquote type="cite">slices option tell x264 to output totally independent slices, both <br></blockquote><blockquote type="cite">spatially and temporally. Last time I sent this patch, I just received <br></blockquote><blockquote type="cite">a single reaction from Jason Martens, but no real comment on the patch <br></blockquote><blockquote type="cite">itself.<br></blockquote><blockquote type="cite">Could you please take a minute and look at it? I myself did some tests <br></blockquote><blockquote type="cite">to evaluate the performance of the patched code, but as my knowledge <br></blockquote><blockquote type="cite">of the encoder is limited I can't tell for sure that the patched code <br></blockquote><blockquote type="cite">doesn't cause significant performance losses.<br></blockquote><blockquote type="cite">If I don't receive any feedback, I'll assume the patch is ready to be <br></blockquote><blockquote type="cite">included in the official version, and I'll make sure this will be done <br></blockquote><blockquote type="cite">as soon as possible.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Best regards,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Etienne<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">--<br></blockquote><blockquote type="cite">Etienne Bömcke<br></blockquote><blockquote type="cite">UCL - Laboratoire TELE<br></blockquote><blockquote type="cite"><a href="mailto:etienne.bomcke@uclouvain.be">etienne.bomcke@uclouvain.be</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">x264-devel mailing list<br></blockquote><blockquote type="cite"><a href="mailto:x264-devel@videolan.org">x264-devel@videolan.org</a><br></blockquote><blockquote type="cite"><a href="http://mailman.videolan.org/listinfo/x264-devel">http://mailman.videolan.org/listinfo/x264-devel</a><br></blockquote><br>_______________________________________________<br>x264-devel mailing list<br><a href="mailto:x264-devel@videolan.org">x264-devel@videolan.org</a><br>http://mailman.videolan.org/listinfo/x264-devel<br></blockquote></div><br><div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Etienne Bömcke</div><div>UCL - Laboratoire TELE</div><div><a href="mailto:etienne.bomcke@uclouvain.be">etienne.bomcke@uclouvain.be</a></div><div><br></div></div></span><br class="Apple-interchange-newline"> </div><br></body></html>