Hi,<br>I tried the two patches posted by Gabriel and now x264 r999 works fine but in slow_mod for my <font size="2">Intel Core 2 Extreme X9770 supporting the following instructions: MMX SSE SSE2 SSE3 SSSE3 SSE4.1 EM64T</font> .<br>
So subme crash came from that.<br><br>The problem was something I can't explain:<br>i had to add brackets to the ifs of the patch <b>hadamar_slowmod4.patch</b><br><br>+ if (!(cpu&X264_CPU_STACK_MOD4))<br>+ {<br>
+ INIT4( hadamard_ac, _ssse3 );<br>+ }<br><br>and this<br><br>+ if (!(cpu&X264_CPU_STACK_MOD4))<br>+ {<br>
+ INIT4( hadamard_ac, _sse2 );<br>+ }<br><br>Don't ask me why... I know it sound crazy.<br>David<br><br><div class="gmail_quote">2008/10/24 Gabriel Bouvigne <span dir="ltr"><<a href="mailto:gabriel.bouvigne@joost.com">gabriel.bouvigne@joost.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">David Sullivan a écrit :<br>
<div class="Ih2E3d"><br>
> It seems that the patch is useful only if the call to ssd_plane comes from<br>
> the function ssd_mb.<br>
> In this case the variable named "size" ( static inline int ssd_plane( x264_t<br>
> *h, int size, int p, int x, int y ) )<br>
> has always (in my case) the value 0 that is h->pixf.hadamard_ac[size] =<br>
> 0x0045db60 _x264_pixel_hadamard_ac_16x16_mmxext<br>
> and no crash appens.<br>
><br>
> If the call comes from x264_rd_cost_part function, the variable named "size"<br>
> is set to 3 and the corresponding value of<br>
> h->pixf.hadamard_ac[size] = 0x0045db60 _x264_pixel_hadamard_ac_16x16_ssse3<br>
> and so it crashes.<br>
<br>
</div>Which imply that there is likely a compilation issue on your side, as<br>
the patch is disabling SSE2/3 versions of hadamard_ac.<br>
<br>
I tested on my side, and to me hadamard_slowmod4 patch and updated msvc<br>
workspace are all that are necessary to have trunk version working on an<br>
SSE2 processor when compiling with msvc.<br>
<br>
<br>
--<br>
<font color="#888888">Gabriel<br>
</font><div><div></div><div class="Wj3C7c">_______________________________________________<br>
x264-devel mailing list<br>
<a href="mailto:x264-devel@videolan.org">x264-devel@videolan.org</a><br>
<a href="http://mailman.videolan.org/listinfo/x264-devel" target="_blank">http://mailman.videolan.org/listinfo/x264-devel</a><br>
</div></div></blockquote></div><br>