<div>my modifications are enabled by the macro EN_TR_EXT</div>
<div> </div>
<div>I also attached the common/macroblock.c file, all my modifications are in this file<br><br></div>
<div class="gmail_quote">2009/5/14 Loren Merritt <span dir="ltr"><<a href="mailto:lorenm@u.washington.edu">lorenm@u.washington.edu</a>></span><br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">
<div>
<div></div>
<div class="h5">On Thu, 14 May 2009, kenter wrote:<br><br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">I was trying to disable Top-Right prediction modes on x264 now, I find the<br>psnr difference is rather low for enable top-right and disable it. While the<br>
subjective quality of disable top-right modes is greatly down. I guess there<br>are some bugs on calculation of PSNR in x264, Is there any bug feedback on<br>this issue?<br></blockquote><br></div></div>x264's PSNR calculation works.<br>
<br>I would rather guess that your modification broke x264, so that the reconstructed frame that PSNR is measured on no longer matches what the standard says your bitstream means. But without the code, I can only guess.<br>
<font color="#888888"><br>--Loren Merritt<br>_______________________________________________<br>x264-devel mailing list<br><a href="mailto:x264-devel@videolan.org" target="_blank">x264-devel@videolan.org</a><br><a href="http://mailman.videolan.org/listinfo/x264-devel" target="_blank">http://mailman.videolan.org/listinfo/x264-devel</a><br>
</font></blockquote></div><br>