Hello,<br><br><div class="gmail_quote">On Wed, Jul 1, 2009 at 4:56 PM, Mike Kazmier <span dir="ltr"><<a href="mailto:DaKaZ@zenbe.com">DaKaZ@zenbe.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Fri, Jun 5, 2009 at 10:17 PM "Steven Walters" <<a href="mailto:kemuri9@gmail.com">kemuri9@gmail.com</a>> wrote:<br>
>yeah it's no problem to help out, would like to see the patch get<br>
> finalized and put to use for everyone...<br>
<br>
</div>All - with a big HOORAY to Steven for his effort in fixing the v14 patch for proper functionality - we are proud to submit this patch which has been tested on linux and windows and appears to be functioning properly. We would love to get this committed.<br>
<br>
Thanks</blockquote><div><br>I had a quick look at it, and these lines hurt my eyes:<br><br><pre>+#ifndef USE_USLEEP<br>+ x264_pthread_cond_wait( &h->lookahead->ofbuf.cv_empty, &h->lookahead->ofbuf.mutex );<br>
+#else<br>+ x264_pthread_mutex_unlock( &h->lookahead->ofbuf.mutex );<br>+ usleep( 100 );<br>+ x264_pthread_mutex_lock( &h->lookahead->ofbuf.mutex );<br>+#endif<br></pre>
</div></div>You shouldn't duplicate these lines over and over again. You can probably fix that problem by putting these changes directly in x264_pthread_cond_wait (but I'm not certain).<br><br>Guillaume<br>-- <br>
Only a very small fraction of our DNA does anything; the rest is all<br>comments and ifdefs.<br><br><a href="http://www.brainyquote.com/quotes/authors/g/george_burns.html" target="_blank">George Burns</a> - "I would go out with women my age, but there are no women my age."