normal mode needs reordering for correct output. (actually just for the BREFs.. i can change it to x264_type_bref instead of slicetypeb.).<br><br><div class="gmail_quote">On Thu, Sep 3, 2009 at 12:35 AM, Jason Garrett-Glaser <span dir="ltr"><<a href="mailto:darkshikari@gmail.com" target="_blank">darkshikari@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Trahald,<br>
<br>
Here's my current local patch; I've revamped the commandline usage<br>
once again and cleaned it up a bit. Here's Loren's requests before we<br>
commit it (why aren't you paying attention in IRC--it would get done a<br>
lot faster that way?):<br>
<br>
12:18 < pengvado> I think x264_reference_partial_reset could be simpler if it<br>
processes B-frames rather than skipping non-B-frames<br>
12:20 < pengvado> it should also do if(!pyramid) return at the beginning,<br>
rather than while(pyramid) at the end.<br>
12:22 < pengvado> ref list header code should be macroed, functioned, or looped<br>
for the 2 lists, not duplicated<br>
12:23 < pengvado> ref list reordering should be enabled only if the desired<br>
order actually differs from the default order<br>
12:24 < pengvado> which should never happen in B-frames<br>
12:24 < pengvado> (unless you're abusing then for forward-only prediction or<br>
something like that)<br>
12:28 < pengvado> why do you need a mmco[] in both slice header and x264_t?<br>
12:29 < pengvado> if it's because x264_reference_partial_reset runs before<br>
slice_header_init, then just don't overwrite it in<br>
slice_header_init<br>
12:33 < pengvado> x264_reference_partial_reset should be named something that<br>
says which part, such as x264_reference_hierarchy_reset<br>
12:34 < pengvado> and then there's the comment on reordering, but I already<br>
sent that<br>
12:34 < pengvado> nothing else<br>
<br>
Dark Shikari<br>
<br>_______________________________________________<br>
x264-devel mailing list<br>
<a href="mailto:x264-devel@videolan.org" target="_blank">x264-devel@videolan.org</a><br>
<a href="http://mailman.videolan.org/listinfo/x264-devel" target="_blank">http://mailman.videolan.org/listinfo/x264-devel</a><br>
<br></blockquote></div><br>