<div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><br>
<br>
The problem is that this changes the way the presets work. Currently:<br>
<br>
preset is applied<br>
<br>
tune is applied<br>
<br>
all other settings are applied<br>
<br>
profile is applied<br>
<br>
Your method makes them applied in commandline order, which may confuse<br>
some users (especially with regard to --profile). It would make more<br>
sense, IMO, to have param_default() take a preset and tuning as an<br>
argument, for example.<br>
<br>
Dark Shikari<br></blockquote><div><br></div><div>I left the logic in x264.c intact, so preset, tune. other_settings, profiles are still applied in order.</div><div>so they are not applied in commandline order.</div><div>
<br></div></div>
</div>