I fixed the patch so that it patches with r1352 but I dunno if that breaks something or not. Could one of you guys please review the 2 changes?<br><br><br><font face="courier new,monospace">$ diff x264-r1342-nal_hrd-pic_struct-v11.patch x264-r1352-nal_hrd-pic_struct-v11.patch <br>
421c421<br>< - h->sh.i_delta_poc_bottom = 0; /* XXX won't work for field */<br>---<br>> - h->sh.i_delta_poc_bottom = 0;<br>719c719<br>< - pps->b_pic_order = 0;<br>---<br>> - pps->b_pic_order = param->b_interlaced;<br>
</font><br><br>The 1st change is trivial, since the issue was only a comment in a line, in the second one though a value changed in the original file so, dunno if that breaks anything or not.<br>
<br><br><br><div class="gmail_quote">On Mon, Nov 23, 2009 at 4:57 AM, Alex Giladi <span dir="ltr"><<a href="mailto:alex.giladi@gmail.com" target="_blank">alex.giladi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Attached is a new version of the patch.<br>
This is a fix to the snafu detected by shon3i (on Doom9), where the<br>
sizes/rates were assumed to be in units of 1024 bits, while they are<br>
actually in 1000's.<br>
Thanks to all the brave people who are using the patch and reporting<br>
back the problems!<br>
Alex (a.k.a. Zm_Gorynych on #x264dev).<br>
<div><div></div><div><br>
On Sat, Nov 21, 2009 at 2:48 AM, Alex Giladi <<a href="mailto:alex.giladi@gmail.com" target="_blank">alex.giladi@gmail.com</a>> wrote:<br>
> Attached is a modified version (note: this is the same version as<br>
> published in Doom9 today as <a href="http://pastebin.com/d72a44cf2" target="_blank">http://pastebin.com/d72a44cf2</a>).<br>
> The patch has same functionality as the previous version, and has some<br>
> parameter handling changes. Also, it removes 'panic factor' which was<br>
> earlier applied to the HRD buffer parameters.<br>
> Alex.<br>
><br>
> On Thu, Nov 19, 2009 at 12:36 AM, Alex Giladi <<a href="mailto:alex.giladi@gmail.com" target="_blank">alex.giladi@gmail.com</a>> wrote:<br>
>> Attached is the fixed and updated version of the HRD patch.<br>
>> Trahald was right (thanks!), and the VBV fullness routine was really broken.<br>
>> Alex.<br>
>><br>
>> On Fri, Oct 16, 2009 at 8:45 AM, Trahald <<a href="mailto:wewk584@gmail.com" target="_blank">wewk584@gmail.com</a>> wrote:<br>
>>> I think your x264_vbv_fullness() routine is broken. initial cpb removal<br>
>>> delay is holding negative values. it is what is causing elecard to reject<br>
>>> the stream.<br>
>>><br>
>>> On Mon, Oct 12, 2009 at 10:34 AM, Alex Giladi <<a href="mailto:alex.giladi@gmail.com" target="_blank">alex.giladi@gmail.com</a>> wrote:<br>
>>>><br>
>>>> Anyone that sees a problem with this patch -- can you please provide<br>
>>>> some details?<br>
>>>> Thanks!<br>
>>>> Alex.<br>
>>>><br>
>>>> On Sun, Oct 11, 2009 at 3:31 PM, Jason Garrett-Glaser<br>
>>>> <<a href="mailto:darkshikari@gmail.com" target="_blank">darkshikari@gmail.com</a>> wrote:<br>
>>>> > On Wed, Oct 7, 2009 at 12:03 PM, Alex Giladi <<a href="mailto:alex.giladi@gmail.com" target="_blank">alex.giladi@gmail.com</a>><br>
>>>> > wrote:<br>
>>>> >> Attached is the new version of the HRD patch with several changes due<br>
>>>> >> to the inputs from Dark_Shikari, Manao and Trahald.<br>
>>>> >> The two major fixes cpb_removal_delay for IDR frames and calculation<br>
>>>> >> of initial_cpb_removal_delay.<br>
>>>> >> Alex.<br>
><br>
</div></div><br>_______________________________________________<br>
x264-devel mailing list<br>
<a href="mailto:x264-devel@videolan.org" target="_blank">x264-devel@videolan.org</a><br>
<a href="http://mailman.videolan.org/listinfo/x264-devel" target="_blank">http://mailman.videolan.org/listinfo/x264-devel</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Lep pozdrav,<br><br>Klemen Tušar<br><br><br><a href="http://djmemi.djslo-forum.com" target="_blank">http://djmemi.djslo-forum.com</a><br><a href="http://www.myspace.com/memidj" target="_blank">http://www.myspace.com/memidj</a><br>
<a href="http://www.midnightvibes.com" target="_blank">http://www.midnightvibes.com</a><br>