<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>On 21/01/2011, at 17.34, Lorenzo Pallara wrote:</div><div><br class="Apple-interchange-newline"><blockquote type="cite"><div><span class="Apple-tab-span" style="white-space:pre"> </span>Attached patch is to add MPEG2 Program Stream output to x264.<font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><div><br></div><blockquote type="cite"><div>My proposal is to use ".pes" as filename extension as I can't find a <br>more popular one.<br></div></blockquote></div><br><div>Looking at the code I can see that it's not an MPEG2 Program Stream you output, but rather a "PES Stream". A proper program stream will need some header and trailer bytes and should have a number of additional "pack" headers.</div><div><br></div><div>Naming aside, I'm a bit concerned that you never calculate and specify the PES_packet_length. As far as I can tell, according to 13818-1, this is only allowed if you encapsulate the PES Stream into Transport Stream packets, but not Program Stream packets.</div><div><br></div><div>Regards,</div><div>Gil</div></body></html>