<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal" style="background:white"><span style="color:#222222">Hi all<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">I am trying to encode some interlaced video content and crop it.<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"> <o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">The source resolution is 720x480 and I need to crop it to 720x392.<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">The cropping values that I set in the crop_rect member are:<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">i_right = 0<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">i_left = 0<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">i_top = 44<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">i_bottom = 44<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"> <o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">The encoder is starting fine, but it seems that one of the crop values in the resulted SPS is wrong.<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">2 different H264 analyzers shows :<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">frame_crop_left_offset = 0<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">frame_crop_right_offset = 0<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">frame_crop_top_offset = 22<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">frame_crop_bottom_offset = 11<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"> <o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">According to the crop values above, the resolution is 720 x 348<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">While the frame_crop_bottom_offset value is correct, frame_crop_top_offset is wrong and should be 11 as well (according to H.264 standard, CropUnitY is equal to 4 in my configuration)<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"> <o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">The source video frames are 720x480, 8 bit, 4:2:0 (NV12)<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"> <o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">My solution was to fix set.c : 288<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:#222222"><o:p> </o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">- sps->crop.i_top = param->crop_rect.i_top;<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">+ sps->crop.i_top = (param->crop_rect.i_top) >> !sps->b_frame_mbs_only;<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"><o:p> </o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"> I am using the shared object of this version 0.157.2932 303c484<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222"><o:p> </o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="color:#222222">Thanks for great work !<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>