<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi, all<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">After the commit “Unify 8-bit and 10-bit CLI and libraries"(<a href="http://git.videolan.org/gitweb.cgi?p=x264.git;a=commit;h=71ed44c7312438fac7c5c5301e45522e57127db4">http://git.videolan.org/gitweb.cgi?p=x264.git;a=commit;h=71ed44c7312438fac7c5c5301e45522e57127db4</a>),
the “ultrafast” preset costs more time encoding.<o:p></o:p></p>
<p class="MsoNormal">The commit “Unify 8-bit and 10-bit CLI and libraries" moves the function param_apply_preset from common/common.c to common/base.c , and also change the content of param_apply_preset.<o:p></o:p></p>
<p class="MsoNormal">Before the commit, in common/common.c, the old version param_apply_preset sets “param->analyse.i_trellis = 0;” if preset is ultrafast<o:p></o:p></p>
<p class="MsoNormal">After the commit, in common/base.c, the new version param_apply_preset misses to set “param->analyse.i_trellis = 0;” if preset is ultrafast.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I think it’s a bug, i_trellis’s default value is 2, and i_trellis is set to 0 in “superfast” and “veryfast”. So it makes no sense for i_trellis to be 2 in “ultrafast”.<o:p></o:p></p>
<p class="MsoNormal">Fixing this can restore the performance in “ultrafast” preset.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank you.<o:p></o:p></p>
</div>
</body>
</html>