<div dir="ltr"><div dir="ltr"><div dir="ltr"><div>It seems relevant to lavf support. We will investigate it a bit later.</div><div>For system environment, I'm on Ubuntu 18.04.1 LTS (x86_64), the supporting libraries are from deb package.</div><div>Compiled with Clang-4.0/Clang-6.0.<br><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Feb 9, 2019 at 9:24 PM Hongxu Chen <<a href="mailto:leftcopy.chx@gmail.com">leftcopy.chx@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Hi,<div><br></div><div>    I checked out with x264-sandbox commit HEAD 1210d2e9. It seems that ThreadSanitizer still reports similar issues (although I'm not quite sure whether they are false alarms).</div><div><br clear="all"><div><div dir="ltr" class="gmail-m_2694897805831340967gmail_signature"><div dir="ltr"><div><div dir="ltr"><font color="#313131" face="Arial, sans-serif"><span style="font-size:12px">Best Regards,</span></font><div><font color="#313131" face="Arial, sans-serif"><span style="font-size:12px">Hongxu</span></font></div></div></div></div></div></div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Feb 9, 2019 at 9:09 PM BugMaster <<a href="mailto:BugMaster@narod.ru" target="_blank">BugMaster@narod.ru</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sat, 9 Feb 2019 20:55:41 +0800, Hongxu Chen wrote:<br>
> Hi x264 developers,<br>
<br>
<br>
>     ThreadSanitizer instrumented x264 binary may warn multiple data<br>
> races (one of which is also surrounded by a mutex environment) when<br>
> running "x264 --threads 2 --quiet --output /dev/null test.avi"<br>
> (relevant files available here<br>
> <a href="https://github.com/ntu-sec/pocs/tree/master/x264-545de2ff/concurrency" rel="noreferrer" target="_blank">https://github.com/ntu-sec/pocs/tree/master/x264-545de2ff/concurrency</a>).<br>
>     Valgrind Helgrind reports similar issues.<br>
<br>
<br>
>     I also had a summation of the read/write pairs (function granularity).<br>
<br>
<br>
> * W thread_sync_context<br>
>   * R encoder_thread_init<br>
> * W slices_write (macroblock_cache_load_neighbours,<br>
> slice_header_write, x264_8_cabac_encode_init_core,<br>
> x264_8_cabac_encode_init, cabac_putbyte, x264_8_cabac_context_init,<br>
> x264_8_macroblock_thread_init, mb_analyse_init_qp,<br>
> macroblock_cache_load_neighbours_deblock, macroblock_cache_load,<br>
> macroblock_cache_load_neighbours, x264_8_frame_deblock_row,<br>
> mb_analyse_init, idct_dequant_2x2_dconly)<br>
>   * R thread_sync_context<br>
> * W analyse_update_cache<br>
>   * R x264_8_frame_cond_broadcast<br>
> * W x264_8_frame_push_unused<br>
>   * R x264_8_frame_push_unused<br>
> * W x264_8_frame_copy_picture<br>
>   * R x264_8_slicetype_analyse<br>
>   * R macroblock_tree<br>
> * W x264_8_encoder_encode<br>
>   * R x264_8_slicetype_analyse<br>
> * W idct_dequant_2x2_dconly<br>
>   * R thread_sync_context<br>
> * W x264_8_adaptive_quant_frame<br>
>   * R x264_8_weights_analyse<br>
> * W x264_8_frame_cond_broadcast<br>
>   * R weighted_reference_duplicate<br>
>   * R analyse_update_cache<br>
>     <br>
> Best Regards,<br>
> Hongxu<br>
<br>
Hi.<br>
<br>
Try with the lastest version from sandbox repo: <a href="http://git.videolan.org/?p=x264/x264-sandbox.git;a=summary" rel="noreferrer" target="_blank">http://git.videolan.org/?p=x264/x264-sandbox.git;a=summary</a><br>
There was some fixes there for ThreadSanitizer.<br>
<br>
_______________________________________________<br>
x264-devel mailing list<br>
<a href="mailto:x264-devel@videolan.org" target="_blank">x264-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x264-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x264-devel</a><br>
</blockquote></div>
</blockquote></div></div></div></div>