<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 5, 2013 at 6:26 AM,  <span dir="ltr"><<a href="mailto:praveen@multicorewareinc.com" target="_blank">praveen@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"># HG changeset patch<br>
# User praveentiwari<br>
# Date 1373023592 -19800<br>
# Node ID 2da2d7ec323ab58a0b7046892cebb9004e0c6008<br>
# Parent  8f4d92a5dd4edf634a408fddfcd48111c2c040af<br>
Cleanup some left hungarian notation left in first commit for xDeQuant<br>
<br>
diff -r 8f4d92a5dd4e -r 2da2d7ec323a source/common/dct.cpp<br>
--- a/source/common/dct.cpp     Fri Jul 05 16:31:48 2013 +0530<br>
+++ b/source/common/dct.cpp     Fri Jul 05 16:56:32 2013 +0530<br>
@@ -703,8 +703,8 @@<br>
<br>
 void xDeQuant(int bitDepth, const int* src, int* dst, int width, int height, int per, int rem, bool useScalingList, unsigned int log2TrSize, int *dequantCoefOrig)<br>
 {<br>
-    const int* piQCoef = src;<br>
-    int* piCoef = dst;<br>
+    const int* qCoef = src;<br>
+    int* coef = dst;<br></blockquote><div><br></div><div style>I would prefer to simply rename the function arguments here, instead of declaring new variables.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

     int invQuantScales[6] = { 40, 45, 51, 57, 64, 72 };<br>
<br>
@@ -725,7 +725,7 @@<br>
     if (useScalingList)<br>
     {<br>
         shift += 4;<br>
-        int *piDequantCoef = dequantCoefOrig;<br>
+        int *dequantCoef = dequantCoefOrig;<br></blockquote><div><br></div><div style>ditto here</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
         if (shift > per)<br>
         {<br>
@@ -733,18 +733,18 @@<br>
<br>
             for (int n = 0; n < width * height; n++)<br>
             {<br>
-                clipQCoef = Clip3(-32768, 32767, piQCoef[n]);<br>
-                coeffQ = ((clipQCoef * piDequantCoef[n]) + add) >> (shift - per);<br>
-                piCoef[n] = Clip3(-32768, 32767, coeffQ);<br>
+                clipQCoef = Clip3(-32768, 32767, qCoef[n]);<br>
+                coeffQ = ((clipQCoef * dequantCoef[n]) + add) >> (shift - per);<br>
+                coef[n] = Clip3(-32768, 32767, coeffQ);<br>
             }<br>
         }<br>
         else<br>
         {<br>
             for (int n = 0; n < width * height; n++)<br>
             {<br>
-                clipQCoef = Clip3(-32768, 32767, piQCoef[n]);<br>
-                coeffQ   = Clip3(-32768, 32767, clipQCoef * piDequantCoef[n]);<br>
-                piCoef[n] = Clip3(-32768, 32767, coeffQ << (per - shift));<br>
+                clipQCoef = Clip3(-32768, 32767, qCoef[n]);<br>
+                coeffQ   = Clip3(-32768, 32767, clipQCoef * dequantCoef[n]);<br>
+                coef[n] = Clip3(-32768, 32767, coeffQ << (per - shift));<br>
             }<br>
         }<br>
     }<br>
@@ -755,9 +755,9 @@<br>
<br>
         for (int n = 0; n < width * height; n++)<br>
         {<br>
-            clipQCoef = Clip3(-32768, 32767, piQCoef[n]);<br>
+            clipQCoef = Clip3(-32768, 32767, qCoef[n]);<br>
             coeffQ = (clipQCoef * scale + add) >> shift;<br>
-            piCoef[n] = Clip3(-32768, 32767, coeffQ);<br>
+            coef[n] = Clip3(-32768, 32767, coeffQ);<br>
         }<br>
     }<br>
 }<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="http://mailman.videolan.org/listinfo/x265-devel" target="_blank">http://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Steve Borho
</div></div>