<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 12, 2013 at 5:03 AM, Derek Buitenhuis <span dir="ltr"><<a href="mailto:derek.buitenhuis@gmail.com" target="_blank">derek.buitenhuis@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 9/12/2013 10:56 AM, Gopu Govindaswamy wrote:<br>
> # HG changeset patch<br>
> # User Gopu Govindaswamy <<a href="mailto:gopu@multicorewareinc.com">gopu@multicorewareinc.com</a>><br>
> # Date 1378979612 -19800<br>
> # Node ID 185918a342b05a9e420bcaeccc9b286a988c17ea<br>
> # Parent 7be0ceae34e059849737050c52a326becd8bbf1a<br>
> Encoder: Removed Code Duplication and made the common function for nal data extraction<br>
<br>
</div>Perhaps:<br>
<br>
Encoder: Factor out duplicated code NAL data extraction<br>
<div class="im"><br>
> void configure(x265_param_t *param);<br>
> void determineLevelAndProfile(x265_param_t *param);<br>
> + void x265_extract_naldata(AccessUnit &au, size_t &nalcount);<br>
<br>
</div>Perhaps I am mistaken, but I thought the x265_ function prefix was<br>
only for the public C API?<br></blockquote><div><br></div><div>Nope, you are correct. We only use x265_ prefix on the public C API where we have to avoid name conflicts. Internally, we use an x265 namespace, though there are a few functions in common.h that use the prefix because they were directly ported from x264, or if they didn't have a prefix they might conflict with system symbols (x265_mdate, x265_log, X265_MIN, etc)</div>
<div><br></div><div>--</div><div>Steve Borho</div></div></div></div>