<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 5:05 PM, Jean-Baptiste Kempf <span dir="ltr"><<a href="mailto:jb@videolan.org" target="_blank">jb@videolan.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 18 Sep, Gopu Govindaswamy wrote :<br>
> -<br>
> +<br>
<br>
whitespace issue.<br>
<div class="im">> -            AccessUnit tmp;<br>
> +           NALUnitEBSP **tmp = NULL;<br>
<br>
</div>Identation is off <br>
<div class="im">Identation ?<br></div></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im"></div><div class="im">

> @@ -169,7 +169,7 @@<br>
>   \param   accessUnitsOut      output bitstream<br>
>   \retval                      number of encoded pictures<br>
>   */<br>
> -int TEncTop::encode(bool flush, const x265_picture_t* pic_in, x265_picture_t *pic_out, AccessUnit& accessUnitOut)<br>
> +int TEncTop::encode(bool flush, const x265_picture_t* pic_in, x265_picture_t *pic_out, NALUnitEBSP **nalunits)<br>
<br>
</div>You fail to update the doxygen doc.<br>
<div class="im">I will update into doxygen doc<br></div></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">
> -        accessUnit.insert(accessUnit.end(), new NALUnitEBSP(onalu));<br>
> +        //accessUnit.insert(accessUnit.end(), new NALUnitEBSP(onalu));<br>
<br>
</div>Why?<br>
<div class="im">forgot to modify this place, after sent the patch I have sent the separate patch for it, <br></div></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">
>      UInt numRBSPBytes = 0;<br>
> -    for (AccessUnit::const_iterator it = accessUnit.begin(); it != accessUnit.end(); it++)<br>
> +    int count = 0;<br>
> +    while (nalunits[count])<br>
<br>
</div>Are you sure nalunits[0] always exists?<br>
<div class="im">Yes i am sure nalunits[0] to nalunits[5] has 0 , i have initialized the nalunit in declaration<br></div></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div><div class="im">
>      {<br>
> -        UInt numRBSPBytes_nal = (*it)->m_packetSize;<br>
> +        UInt numRBSPBytes_nal = nalunits[count]->m_packetSize;<br>
>  #if VERBOSE_RATE<br>
>          printf("*** %6s numBytesInNALunit: %u\n", nalUnitTypeToString((*it)->m_nalUnitType), numRBSPBytes_nal);<br>
>  #endif<br>
> -        if ((*it)->m_nalUnitType != NAL_UNIT_PREFIX_SEI && (*it)->m_nalUnitType != NAL_UNIT_SUFFIX_SEI)<br>
> +        if (nalunits[count]->m_nalUnitType != NAL_UNIT_PREFIX_SEI && nalunits[count]->m_nalUnitType != NAL_UNIT_SUFFIX_SEI)<br>
>          {<br>
>              numRBSPBytes += numRBSPBytes_nal;<br>
>          }<br>
> +        count++;<br>
>      }<br>
<br>
</div>Why not keeping the for syntax here?<br>
<div class="im">syntax?<br>
> +    NALUnitEBSP *nalunits[5] = { 0, 0, 0, 0, 0 };<br>
<br>
</div>You should make this 5 a define, so you can use it later on<br>
<div class="im"><br>
>          if (pi_nal) *pi_nal = (int)nalcount;<br>
> +<br>
<br>
</div>White space<br>
<div class="im"><br>
> +    NALUnitEBSP *nalunits[5] = { 0, 0, 0, 0, 0 };<br>
> +    int numEncoded = encoder->encode(!pic_in, pic_in, pic_out, nalunits);<br>
> +<br>
<br>
</div>idem<br>
<div class="im">idem?<br>
> +            m_accessUnit[m_nalcount] = (NALUnitEBSP *)X265_MALLOC(NALUnitEBSP, 1);<br>
<br>
</div>Why don't you check your malloc return???<br></div></blockquote><div>    X265_MALLOC Will take care of this  <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
</div><span class="HOEnZb"><font color="#888888"><br></font></span><div><span class="HOEnZb"><font color="#888888">
--<br>
Jean-Baptiste Kempf<br>
<a href="http://www.jbkempf.com/" target="_blank">http://www.jbkempf.com/</a> - +33 672 704 734<br>
Sent from my Electronic Device<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</font></span></div></blockquote></div><br><br clear="all"><br>-- <br>Thanks & Regards<br>Gopu G<br><br><br>
</div></div>