<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 7:44 AM, SF Markus Elfring <span dir="ltr"><<a href="mailto:elfring@users.sourceforge.net" target="_blank">elfring@users.sourceforge.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
1. The data type of the variable "local" should be "sig_atomic_t" for better<br>
portability.<br>
   <a href="https://bitbucket.org/multicoreware/x265/src/d11de33521cf/source/x265.cpp#cl-79" target="_blank">https://bitbucket.org/multicoreware/x265/src/d11de33521cf/source/x265.cpp#cl-79</a></blockquote><div><br></div>
<div>Thanks, patch on the way</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
2. The function "exit" does not belong to the list of async-signal-safe functions.<br>
<br>
<a href="https://www.securecoding.cert.org/confluence/display/cplusplus/SIG30-CPP.+Call+only+asynchronous-safe+functions+within+signal+handlers" target="_blank">https://www.securecoding.cert.org/confluence/display/cplusplus/SIG30-CPP.+Call+only+asynchronous-safe+functions+within+signal+handlers</a><br>

<br>
  I guess that a different program design will be needed for your function<br>
"sigint_handler".<br></blockquote></div><div class="gmail_extra"><br></div>The sigint handler is only for early-exiting the encode loop; all of the exit() calls would happen before the encode loop is entered, so I don't think this is a problem.<br clear="all">
<div><br></div>-- <br>Steve Borho
</div></div>