<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 19, 2013 at 2:25 AM, Deepthi Devaki Akkoorath <span dir="ltr"><<a href="mailto:deepthidevaki@multicorewareinc.com" target="_blank">deepthidevaki@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Thu, Sep 19, 2013 at 12:19 PM, Deepthi Nandakumar <span dir="ltr"><<a href="mailto:deepthi@multicorewareinc.com" target="_blank">deepthi@multicorewareinc.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Thu, Sep 19, 2013 at 11:55 AM,  <span dir="ltr"><<a href="mailto:deepthidevaki@multicorewareinc.com" target="_blank">deepthidevaki@multicorewareinc.com</a>></span> wrote:<br>


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"># HG changeset patch<br>
# User Deepthi Devaki <<a href="mailto:deepthidevaki@multicorewareinc.com" target="_blank">deepthidevaki@multicorewareinc.com</a>><br>
# Date 1379571920 -19800<br>
# Node ID 93d222ec321e5eed93dc8652dc9e5248d836c436<br>
# Parent  26d6f155f8df69147f40f4945d99c29a52988c56<br>
lookahead: fix crash for I frame cost estimation<br>
<br>
diff -r 26d6f155f8df -r 93d222ec321e source/encoder/slicetype.cpp<br>
--- a/source/encoder/slicetype.cpp      Wed Sep 18 16:13:33 2013 -0500<br>
+++ b/source/encoder/slicetype.cpp      Thu Sep 19 11:55:20 2013 +0530<br>
@@ -365,7 +365,8 @@<br>
         if (!bDoSearch[i])<br>
         {<br>
             /* Use previously calculated cost */<br>
-            COPY2_IF_LT(bcost, *fenc_costs[i], listused, i + 1);<br>
+            if(p0 != p1)<br></blockquote><div><br></div></div><div>Can we move this check (for intra-slices) to outside the for-loop? <br></div></div></div></div></blockquote><div><br></div></div><div>Yes. Infact, it doesnt have to enter the loop if Intra slice.</div>
</div></div></div></blockquote><div><br></div><div><br></div><div>x264 actually uses a goto here to skip inter searches entirely and jump to the intra checks</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div>

+                COPY2_IF_LT(bcost, *fenc_costs[i], listused, i + 1);<br>
             continue;<br>
         }<br>
         int numc = 0;<br></div>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div><br></div></div>
<br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div></div><br></div></div>
<br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Steve Borho
</div></div>