<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Oct 5, 2013 at 1:00 PM, Derek Buitenhuis <span dir="ltr"><<a href="mailto:derek.buitenhuis@gmail.com" target="_blank">derek.buitenhuis@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">On 10/4/2013 12:22 AM, Derek Buitenhuis wrote:<br>

> Queued to test tomorrow morn.<br></div></blockquote><div><br></div><div>Thanks for testing</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Findings:<br>
t<br>
Lib links via:<br>
<br>
/usr/bin/c++  -fPIC  -fPIC -O3 -DNDEBUG  -shared -Wl,-soname,libx265.so -o libx265.so CMakeFiles/x265.dir/dllmain.cpp.o common/libcommon.a encoder/libencoder.a common/vec/libPrimitivesVec.a common/x86/libPrimitivesASM.a -lpthread -lm -lrt<br>
</blockquote><div><br></div><div>this looks somewhat sane, ignoring the redundant -fPIC.  Though I wonder if the link order is wrong for GCC.  It might be discarding much of libcommon.a because it is listed before libencoder.a</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
x265 links via:<br>
<br>
/usr/bin/c++    -fPIC -O3 -DNDEBUG  -fPIC CMakeFiles/cli.dir/input/input.cpp.o CMakeFiles/cli.dir/input/y4m.cpp.o CMakeFiles/cli.dir/input/yuv.cpp.o CMakeFiles/cli.dir/output/output.cpp.o CMakeFiles/cli.dir/output/y4m.cpp.o CMakeFiles/cli.dir/output/yuv.cpp.o CMakeFiles/cli.dir/x265.cpp.o CMakeFiles/cli.dir/compat/msvc/getopt.c.o  -o x265 -rdynamic libx265.so -lpthread -lm -lrt common/libcommon.a encoder/libencoder.a common/vec/libPrimitivesVec.a common/x86/libPrimitivesASM.a -Wl,-rpath,/mnt/tc/dev/b<br>

<br>
Obviously wrong, since it includes the .a files.<br></blockquote><div><br></div><div>Yeah; I need to figure out why it's adding static libs as well.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

Also libx265.so doesn't link to third party libs properly.<br>
<br>
I tested with my patch to Libav and got:<br>
<br>
check_func x265_encoder_encode -lx265 -lstdc++<br>
check_ld -lx265 -lstdc++<br>
check_cc<br>
BEGIN /tmp/ffconf.TrwduATY.c<br>
    1   extern int x265_encoder_encode();<br>
    2   int main(void){ x265_encoder_encode(); }<br>
END /tmp/ffconf.TrwduATY.c<br>
clang -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -std=c99 -fomit-frame-pointer -pthread -c -o /tmp/ffconf.eeq38c5j.o /tmp/ffconf.TrwduATY.c<br>
clang -Wl,--as-needed -o /tmp/ffconf.nF7C6wIq /tmp/ffconf.eeq38c5j.o -lx265 -lstdc++ -lm -pthread -lbz2 -lz<br>
/usr/local/lib/libx265.so: undefined reference to `x265::TComSampleAdaptiveOffset::m_numClass'<br></blockquote><div><snip><br></div><div><br></div><div>libcommon.a symbols are missing somehow</div><div><br></div>
<div>--</div><div>Steve</div></div></div></div>