<div dir="ltr">Yes, That is right we don't need to pass width and height but that is helpfully for now in some cases to know which parameter I need to load from stack but while finally integrating to Test Bench I will replace with new one.<div>
<br></div><div>Regards,</div><div>Praveen </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 8, 2013 at 11:13 AM, Steve Borho <span dir="ltr"><<a href="mailto:steve@borho.org" target="_blank">steve@borho.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Tue, Oct 8, 2013 at 12:40 AM, <span dir="ltr"><<a href="mailto:praveen@multicorewareinc.com" target="_blank">praveen@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"># HG changeset patch<br>
# User praveen Tiwari<br>
# Date 1381210681 -19800<br>
# Node ID d9580d9cad8df6ad00d08ab538cdac27c0eb4e92<br>
# Parent d71078917df01e92605158a13b45ab35ee7cfc1c<br>
filterHorizontal_p_p_4, 4x4 asm code<br>
<br>
diff -r d71078917df0 -r d9580d9cad8d source/common/x86/ipfilter8.asm<br>
--- a/source/common/x86/ipfilter8.asm Mon Oct 07 12:48:32 2013 +0530<br>
+++ b/source/common/x86/ipfilter8.asm Tue Oct 08 11:08:01 2013 +0530<br>
@@ -130,3 +130,56 @@<br>
RET<br>
<br>
%endif ; ARCH_X86_64 == 0<br>
+<br>
+SECTION_RODATA 32<br>
+tab_Tm: db 0, 1, 2, 3, 1, 2, 3, 4, 2, 3, 4, 5, 3, 4, 5, 6<br>
+<br>
+tab_c_512: times 8 dw 512<br>
+<br>
+SECTION .text<br>
+<br>
+%macro FILTER_H4_w4 3<br>
+ movu %1, [srcq - 1]<br>
+ pshufb %2, %1, Tm0<br>
+ pmaddubsw %2, coef2<br>
+ phaddw %2, %1<br>
+ pmulhrsw %2, %3<br>
+ packuswb %2, %2<br>
+%endmacro<br>
+<br>
+%macro FILTER_H4_w4_CALL 0<br>
+ FILTER_H4_w4 x0, x1, x2<br>
+<br>
+ movd [dstq], x1<br>
+<br>
+ add srcq, srcstrideq<br>
+ add dstq, dststrideq<br>
+%endmacro<br>
+<br>
+;-----------------------------------------------------------------------------<br>
+; void filterHorizontal_p_p_4(pixel *src, intptr_t srcStride, pixel *dst, intptr_t dstStride, int width, int height, short const *coeff)<br></blockquote><div><br></div></div></div><div>I assume this comment is out of date? you shouldn't need to pass width and height</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
+;-----------------------------------------------------------------------------<br>
+INIT_XMM sse4<br>
+cglobal filterHorizontal_p_p_4, 4, 5, 5, src, srcstride, dst, dststride<br>
+%define coef2 m4<br>
+%define Tm0 m3<br>
+%define x2 m2<br>
+%define x1 m1<br>
+%define x0 m0<br>
+<br>
+ mov r4, r6m<br>
+ movu coef2, [r4]<br>
+ packsswb coef2, coef2<br>
+ pshufd coef2, coef2, 0<br>
+<br>
+ mova x2, [tab_c_512]<br>
+<br>
+ mova Tm0, [tab_Tm]<br>
+<br>
+%rep 3<br>
+FILTER_H4_w4_CALL<br>
+%endrep<br>
+<br>
+ FILTER_H4_w4 x0, x1, x2<br>
+ movd [dstq], x1<br>
+ RET<br></div></div>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><span class="HOEnZb"><font color="#888888"><br>
</font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br>Steve Borho
</font></span></div></div>
<br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div><br></div>