<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 5, 2013 at 3:24 AM, Deepthi Nandakumar <span dir="ltr"><<a href="mailto:deepthi@multicorewareinc.com" target="_blank">deepthi@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div></div><div class="gmail_extra"><br>
<br><div class="gmail_quote"><div class="im">On Mon, Nov 4, 2013 at 7:36 PM,  <span dir="ltr"><<a href="mailto:praveen@multicorewareinc.com" target="_blank">praveen@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"># HG changeset patch<br>
# User Praveen Tiwari<br>
# Date 1383573863 -19800<br>
# Node ID 20b712dce6c237f64ea3ca2a06fc4cb9370ad91f<br>
# Parent  690639d8d50283feeb6d208ba70d350aa2b7b196<br>
removed loop, using part variable to test all partition for chroma_copy_pp<br>
<br>
diff -r 690639d8d502 -r 20b712dce6c2 source/test/pixelharness.cpp<br>
--- a/source/test/pixelharness.cpp      Mon Nov 04 18:57:06 2013 +0530<br>
+++ b/source/test/pixelharness.cpp      Mon Nov 04 19:34:23 2013 +0530<br>
@@ -645,6 +645,14 @@<br>
         }<br>
     }<br>
<br></blockquote></div><div>What does this mean? You are calling check_block_copy_pp recursively?? <br></div></div></div></div></blockquote><div><br></div><div><br></div><div>not sure what you're asking, but "<span style="color:rgb(80,0,80)">if (opt.chroma_copy_pp[part])" checks that an optimized function for this partition exists.</span></div>
<div><span style="color:rgb(80,0,80)"><br></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">
<div class="gmail_extra"><div class="gmail_quote"><div></div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

+    if (opt.chroma_copy_pp[part])<br>
+    {<br>
+        if (!check_block_copy_pp(ref.chroma_copy_pp[part], opt.chroma_copy_pp[part]))<br>
+        {<br>
+            printf("chroma_copy_pp[%s] failed\n", lumaPartStr[part]);<br>
+            return false;<br>
+        }<br>
+    }<br>
     return true;<br>
 }<br>
<br>
@@ -803,18 +811,6 @@<br>
             return false;<br>
         }<br>
     }<br>
-<br></blockquote></div><div>Why should check chroma be a part of check luma?<br></div></div></div></div></blockquote><div><br></div><div>the chroma and luma partitions are deliberately aligned, so an iteration over one can be used as an iteration over both;  you just have to be careful to index into the right string table in the printf.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div></div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
-    for (int i = 0; i < NUM_CHROMA_PARTITIONS; i++)<br>
-    {<br>
-      if (opt.chroma_copy_pp[i])<br>
-      {<br>
-          if (!check_block_copy_pp(ref.chroma_copy_pp[i], opt.chroma_copy_pp[i]))<br>
-          {<br>
-              printf("chroma_copy_pp[%s] failed\n", chromaPartStr[i]);<br>
-              return false;<br>
-          }<br>
-      }<br>
-    }<br>
     return true;<br>
 }<br>
<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div></div><br></div></div>
<br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Steve Borho
</div></div>