<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 12, 2013 at 10:07 PM, chen <span dir="ltr"><<a href="mailto:chenm003@163.com" target="_blank">chenm003@163.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="line-height:1.7;font-size:14px;font-family:arial">在 2013-11-13 07:26:04，"Steve Borho" <<a href="mailto:steve@borho.org" target="_blank">steve@borho.org</a>> 写道：<br>
<blockquote style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote"><div class="im">On Tue, Nov 12, 2013 at 4:58 AM, <span dir="ltr"><<a href="mailto:nabajit@multicorewareinc.com" target="_blank">nabajit@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid"># HG changeset patch<br># User Nabajit Deka<br># Date 1384253754 -19800<br># Tue Nov 12 16:25:54 2013 +0530<br>
# Node ID b0b5fd8c84ea3a4d6b9c44b0e57023e251e1bc81<br># Parent 752b982a4a6c7778a6f8a50cfa7c8f3e7eac04e9<br>Adding function pointer initializations for asm chroma vsp functions.<br></blockquote>
<div><br></div>
<div>Queued.</div>
<div><br></div>
<div>if these functions are now completed, you need to send a patch which enables these primitives in the encoder and removes the old primitives entirely.</div>
<div> </div>
</div><div>I try it before, but 16bpp path need these old primivites, so we have to keep it until we finished 16bpp version</div></div></div></div></blockquote></div></blockquote><div><br></div><div>in the short term, I'm not too concerned with 16bpp performance. I believe that particular 16bpp test bench is failing right now anyway.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="line-height:1.7;font-size:14px;font-family:arial"><blockquote style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">
<blockquote class="gmail_quote" style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid"><br>diff -r 752b982a4a6c -r b0b5fd8c84ea source/common/x86/asm-primitives.cpp<br>--- a/source/common/x86/asm-primitives.cpp Tue Nov 12 16:23:13 2013 +0530<br>
+++ b/source/common/x86/asm-primitives.cpp Tue Nov 12 16:25:54 2013 +0530<br>@@ -139,6 +139,9 @@<br> p.chroma_vpp[CHROMA_ ## W ## x ## H] = x265_interp_4tap_vert_pp_ ## W ## x ## H ## cpu; \<br> p.chroma_copy_ps[CHROMA_ ## W ## x ## H] = x265_blockcopy_ps_ ## W ## x ## H ## cpu;<br>
<br>+#define SETUP_CHROMA_SP_FUNC_DEF(W, H, cpu) \<br>+ p.chroma_vsp[CHROMA_ ## W ## x ## H] = x265_interp_4tap_vert_sp_ ## W ## x ## H ## cpu;<br>+<br> #define SETUP_CHROMA_BLOCKCOPY_FUNC_DEF(W, H, cpu) \<br> p.chroma_copy_pp[CHROMA_ ## W ## x ## H] = x265_blockcopy_pp_ ## W ## x ## H ## cpu;<br>
<br>@@ -168,6 +171,32 @@<br> SETUP_CHROMA_FUNC_DEF(32, 8, cpu); \<br> SETUP_CHROMA_FUNC_DEF(8, 32, cpu);<br><br>+#define CHROMA_SP_FILTERS(cpu) \<br>+ SETUP_CHROMA_SP_FUNC_DEF(4, 4, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(4, 2, cpu); \<br>
+ SETUP_CHROMA_SP_FUNC_DEF(2, 4, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(8, 8, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(8, 4, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(4, 8, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(8, 6, cpu); \<br>
+ SETUP_CHROMA_SP_FUNC_DEF(6, 8, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(8, 2, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(2, 8, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(16, 16, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(16, 8, cpu); \<br>
+ SETUP_CHROMA_SP_FUNC_DEF(8, 16, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(16, 12, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(12, 16, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(16, 4, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(4, 16, cpu); \<br>
+ SETUP_CHROMA_SP_FUNC_DEF(32, 32, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(32, 16, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(16, 32, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(32, 24, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(24, 32, cpu); \<br>
+ SETUP_CHROMA_SP_FUNC_DEF(32, 8, cpu); \<br>+ SETUP_CHROMA_SP_FUNC_DEF(8, 32, cpu);<br>+<br> #define CHROMA_BLOCKCOPY(cpu) \<br> SETUP_CHROMA_BLOCKCOPY_FUNC_DEF(4, 4, cpu); \<br> SETUP_CHROMA_BLOCKCOPY_FUNC_DEF(4, 2, cpu); \<br>
@@ -473,7 +502,10 @@<br> p.luma_hvpp[LUMA_8x8] = x265_interp_8tap_hv_pp_8x8_ssse3;<br> p.luma_p2s = x265_luma_p2s_ssse3;<br> p.chroma_p2s = x265_chroma_p2s_ssse3;<br>+<br>+ CHROMA_SP_FILTERS(_ssse3);<br>
LUMA_SP_FILTERS(_ssse3);<br>+<br> }<br> if (cpuMask & X265_CPU_SSE4)<br> {<br>_______________________________________________<br>x265-devel mailing list<br><a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br></blockquote></div></div></div><br><br clear="all"><span class="HOEnZb"><font color="#888888">
<div><br></div>-- <br>Steve Borho </font></span></div></div></blockquote></div><br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Steve Borho
</div></div>