<div dir="ltr">Okay. i will send it as a new patch.<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Nov 14, 2013 at 12:50 PM, chen <span dir="ltr"><<a href="mailto:chenm003@163.com" target="_blank">chenm003@163.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="line-height:1.7;font-size:14px;font-family:arial"><blockquote style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote"><div><div class="h5">On Thu, Nov 14, 2013 at 12:07 AM, <span dir="ltr"><<a href="mailto:murugan@multicorewareinc.com" target="_blank">murugan@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid"># HG changeset patch<br># User Murugan Vairavel <<a href="mailto:murugan@multicorewareinc.com" target="_blank">murugan@multicorewareinc.com</a>><br>
# Date 1384409049 -19800<br># Thu Nov 14 11:34:09 2013 +0530<br># Node ID c9fdf510182348c979a58be67101446c84b36569<br># Parent 481cdfc251de0f99ef0a3c4fd53c786b79b5f182<br>asm: Unit test code for scale1D_128to64 Routine<br>
<br>diff -r 481cdfc251de -r c9fdf5101823 source/test/pixelharness.cpp<br>--- a/source/test/pixelharness.cpp Wed Nov 13 12:46:07 2013 +0530<br>+++ b/source/test/pixelharness.cpp Thu Nov 14 11:34:09 2013 +0530<br>
@@ -586,6 +586,29 @@<br> return true;<br> }<br><br>+bool PixelHarness::check_scale_pixel_t(scale_t ref, scale_t opt)<br>+{<br>+ ALIGN_VAR_16(pixel, ref_dest[64 * 64]);<br>+ ALIGN_VAR_16(pixel, opt_dest[64 * 64]);<br>
+<br>+ memset(ref_dest, 0, sizeof(ref_dest));<br>+ memset(opt_dest, 0, sizeof(opt_dest));<br>+<br>+ int j = 0;<br>+ for (int i = 0; i < ITERS; i++)<br>+ {<br>+ opt(opt_dest, pbuf1 + j, STRIDE);<br>
+ ref(ref_dest, pbuf1 + j, STRIDE);<br>+<br>+ if (memcmp(ref_dest, opt_dest, 64 * 64 * sizeof(pixel)))<br>+ return false;<br>+<br>+ j += INCR;<br>+ }<br>+<br>+ return true;<br>+}<br>+<br>
bool PixelHarness::testPartition(int part, const EncoderPrimitives& ref, const EncoderPrimitives& opt)<br> {<br> if (opt.satd[part])<br>@@ -880,6 +903,15 @@<br> return false;<br> }<br> }<br>
+<br>+ if (opt.scale1D_128to64)<br>+ {<br>+ if (!check_scale_pixel_t(ref.scale1D_128to64, opt.scale1D_128to64))<br>+ {<br>+ printf("scale1D_128to64 failed!\n");<br>+ return false;<br>
+ }<br>+ }<br> return true;<br> }<br><br>@@ -1093,4 +1125,10 @@<br> printf("downscale");<br> REPORT_SPEEDUP(opt.frame_init_lowres_core, ref.frame_init_lowres_core, pbuf2, pbuf1, pbuf2, pbuf3, pbuf4, 64, 64, 64, 64);<br>
}<br>+<br>+ if (opt.scale1D_128to64)<br>+ {<br>+ printf("scale1D_128to64");<br>+ REPORT_SPEEDUP(opt.scale1D_128to64, ref.scale1D_128to64, pbuf2, pbuf1, 64);<br>+ }<br> }<br>diff -r 481cdfc251de -r c9fdf5101823 source/test/pixelharness.h<br>
--- a/source/test/pixelharness.h Wed Nov 13 12:46:07 2013 +0530<br>+++ b/source/test/pixelharness.h Thu Nov 14 11:34:09 2013 +0530<br>@@ -61,6 +61,8 @@<br> bool check_blockfill_s(blockfill_s_t ref, blockfill_s_t opt);<br>
<br> bool check_pixel_sub_ps(pixel_sub_ps_t ref, pixel_sub_ps_t opt);<br>+<br>+ bool check_scale_pixel_t(scale_t ref, scale_t opt);<br></blockquote>
<div><br></div>
<div>drop _t suffix from the function name</div>
<div> </div>
</div></div><div>increment _pp in end of name is better, since this function convert Pixel to Pixel</div>
<div> </div></div></div></div></blockquote></div><br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">With Regards,<div><br></div><div>Murugan. V</div><div>+919659287478</div></div>
</div>