<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Dec 16, 2013 at 2:49 PM, Deepthi Nandakumar <span dir="ltr"><<a href="mailto:deepthi@multicorewareinc.com" target="_blank">deepthi@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Mon, Dec 16, 2013 at 1:58 PM, <span dir="ltr"><<a href="mailto:sumalatha@multicorewareinc.com" target="_blank">sumalatha@multicorewareinc.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"># HG changeset patch<br>
# User Sumalatha Polureddy<br>
# Date 1387182478 -19800<br>
# Node ID 70a5357626fe2f45f0c462871c26b468a023a322<br>
# Parent 238d7f272d1e5c49d90bb15f40b2d7e90be78ba1<br>
rd level: fix for output mismatch<br>
<br>
For boundary conditions, cost calculation was wrong.<br>
<br>
diff -r 238d7f272d1e -r 70a5357626fe source/encoder/compress.cpp<br>
--- a/source/encoder/compress.cpp Mon Dec 16 10:57:06 2013 +0530<br>
+++ b/source/encoder/compress.cpp Mon Dec 16 13:57:58 2013 +0530<br>
@@ -768,11 +768,12 @@<br>
m_entropyCoder->resetBits();<br>
m_entropyCoder->encodeSplitFlag(outTempCU, 0, depth, true);<br>
outTempCU->m_totalBits += m_entropyCoder->getNumberOfWrittenBits(); // split bits<br>
- outTempCU->m_totalCost = m_rdCost->calcRdCost(outTempCU->m_totalDistortion, outTempCU->m_totalBits);<br>
}<br>
- else<br>
- outTempCU->m_totalCost = m_rdCost->calcRdSADCost(outTempCU->m_totalDistortion, outTempCU->m_totalBits);<br>
}<br>
+ if (m_cfg->param.rdLevel > 1)<br>
+ outTempCU->m_totalCost = m_rdCost->calcRdCost(outTempCU->m_totalDistortion, outTempCU->m_totalBits);<br>
+ else<br>
+ outTempCU->m_totalCost = m_rdCost->calcRdSADCost(outTempCU->m_totalDistortion, outTempCU->m_totalBits);<br>
<br></blockquote></div></div><div>Whats the logic behind this? If it's a valid output change for rd >1, we dont have to revert.<br></div></div></div></div></blockquote><div><br></div><div><font color="#0000ff"> Output change is not valid. It was mistake that cost was calculated only if it is not boundary.</font></div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">
if ((g_maxCUWidth >> depth) == outTempCU->getSlice()->getPPS()->getMinCuDQPSize() && outTempCU->getSlice()->getPPS()->getUseDQP())<br>
{<br></div>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div><br></div></div>
<br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div><br></div></div>