<html><head><meta http-equiv="Content-Type" content="text/html charset=GB2312"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 21, 2014, at 2:49 AM, <a href="mailto:herman.chen@rock-chips.com">herman.chen@rock-chips.com</a> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 10.5pt; font-family: ΢ÈíÑźÚ; line-height: 1.5; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; margin: 10px;"><div>Probably there is a bug on cuTree module.</div><div> </div><div>Here is the screen shot of function Lookahead::estimateCUPropagate on line:1343</div><div>There is a branch on mv non-equal to zero, but actually in x264 it is a branch for zero mv. So here should be a bug which will make the cuTree estimation inaccurate.</div><div> </div><div>x265:</div><div><span><Catch(01-21-16-49-33).jpg></span></div><div> </div><div>x264:</div><div><span><CatchD678(01-21-16-49-33).jpg></span></div></div></blockquote><div><br></div><div>Great catch, thanks.<span style="font-family: ΢ÈíÑźÚ; font-size: 10.5pt; line-height: 1.5;"> </span></div><blockquote type="cite"><div style="font-size: 10.5pt; font-family: ΢ÈíÑźÚ; line-height: 1.5; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; margin: 10px;"><div>BTW, how can I make my commit?</div></div></blockquote><div><br></div><div>You clone our repo with Mercurial, change the code and commit locally, then use the patchbomb extension (or the TortoiseHg email dialog) to email the patch to this list.</div><div><br></div><div>If you are git-centric, there is a git clone of x265 on bitbucket; you may clone that and make the commit and email that patch; it is all the same to me.</div><div><br></div><div>For this particular bug, I will probably fix it right away and give you credits in the commit message.</div><div><br></div><div>--</div><div>Steve Borho</div></div></body></html>