<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 02/02/2015 11:43 AM, Deepthi
Nandakumar wrote:<br>
</div>
<blockquote
cite="mid:CAAEo3uh3RtrxrDqbxxRYwG2Sod+5aaX+T_qpWsAKscZgQ8RkHw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote"><br>
<div><br>
We ran into this exact issue doing performance
analyses on 40-core+ machines, where we found
slicetypeDecide being a bottleneck. Please checkout
this commit. <br>
<table style="margin:0px" border="0" cellpadding="0"
cellspacing="2">
<tbody>
<tr>
<td style="padding-right:6">
<p style="margin:0px;text-indent:0px"><span
style="font-weight:600">Changeset:</span></p>
</td>
<td>
<p style="margin:0px;text-indent:0px"><span
style="font-family:"monospace";font-size:9pt">9033
(d36211d0190f)</span> slicetype: allow
queue to fill past full to prevent
bottlenecks …</p>
</td>
</tr>
<tr>
<td style="padding-right:6">
<p style="margin:0px;text-indent:0px"><span
style="font-weight:600">User:</span></p>
</td>
<td>
<p style="margin:0px;text-indent:0px">Steve
Borho <<a moz-do-not-send="true"
href="mailto:steve@borho.org">steve@borho.org</a>></p>
</td>
</tr>
<tr>
<td style="padding-right:6">
<p style="margin:0px;text-indent:0px"><span
style="font-weight:600">Date:</span></p>
</td>
<td>
<p style="margin:0px;text-indent:0px">2015-01-06
15:38:58 +0530 (3 weeks)</p>
</td>
</tr>
</tbody>
</table>
<br>
</div>
<div>This patch essentially lets lookahead run
slightly ahead of the Frame Encoders, so the output
queue always has decided frames available for
encoding. <br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
I was looking how my quick patch would conflicts against master and
found out this one. Which is pretty much what I did. <br>
<br>
<blockquote
cite="mid:CAAEo3uh3RtrxrDqbxxRYwG2Sod+5aaX+T_qpWsAKscZgQ8RkHw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div>We're very close to tagging 1.5 - which will
contain this and other improvements.<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
This is good. I've been waiting to update for a while but we had to
release some code last week. Hopefully it won't be too much of a
hassle to integrate.<br>
<br>
<blockquote
cite="mid:CAAEo3uh3RtrxrDqbxxRYwG2Sod+5aaX+T_qpWsAKscZgQ8RkHw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<br>
The idea would be something like this:<br>
Input -> Input Thread <-> LookAhead queue
<-> LookAhead Thread <-> input_queue
<-> Main thread <-> FrameEncoders
<-> Main Thread -> Output stream<br>
<br>
</blockquote>
<div>We could try this out, but on generic x86
multicore, it may not benefit much. It would be good
to see if the current tip fixes the performance
issues on your accelerator pipeline as well.<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
I'll give a try at merging the code and see where we land.<br>
<br>
Thanks for the feedback.<br>
<br>
Nicolas<br>
<br>
</body>
</html>