<div style="line-height:1.7;color:#000000;font-size:14px;font-family:arial"><div> </div>
<div></div>
<div id="divNeteaseMailCard"></div>
<div><br></div>At 2015-02-26 17:57:02,"Praveen Tiwari" <praveen@multicorewareinc.com> wrote:<br>
<blockquote id="isReplyContent" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">
<div dir="ltr"><br>
<div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">chen</b> <span dir="ltr"><<a href="mailto:chenm003@163.com">chenm003@163.com</a>></span><br>Date: Thu, Feb 26, 2015 at 3:15 PM<br>Subject: Re: [x265] Fwd: [PATCH Review Only] asm-avx2: intra_pred_ang8_33, improved 265.79c -> 185.43c over sse4 asm code<br>To: Development for x265 <<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a>><br><br><br>
<div>
<div style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial">
<div class="h5">
<div></div>
<div></div>
<div><br></div>At 2015-02-26 14:24:54,"Praveen Tiwari" <<a href="mailto:praveen@multicorewareinc.com" target="_blank">praveen@multicorewareinc.com</a>> wrote:<br></div></div>
<blockquote style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: rgb(204,204,204) 1px solid">
<div dir="ltr"><br>
<div class="gmail_quote">
<div style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial">
<div class="h5">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">chen</b> <span dir="ltr"><<a href="mailto:chenm003@163.com" target="_blank">chenm003@163.com</a>></span><br>Date: Wed, Feb 25, 2015 at 7:38 PM<br>Subject: Re: [x265] [PATCH Review Only] asm-avx2: intra_pred_ang8_33, improved 265.79c -> 185.43c over sse4 asm code<br>To: Development for x265 <<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a>><br><br><br></div></div>
<div>
<div style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial">
<div class="h5">
<div><br> </div><pre><br>At 2015-02-25 16:52:00,<a href="mailto:praveen@multicorewareinc.com" target="_blank">praveen@multicorewareinc.com</a> wrote:
># HG changeset patch
># User Praveen Tiwari <<a href="mailto:praveen@multicorewareinc.com" target="_blank">praveen@multicorewareinc.com</a>>
># Date 1424854196 -19800
># Node ID 177fe9372668b4824c291e967349664766688179
># Parent 02bac78bde961d60d180e59b5260fad93b98d9b4
>asm-avx2: intra_pred_ang8_33, improved 265.79c -> 185.43c over sse4 asm code
>
>intra_ang_8x8[33] 10.56x 185.43 1957.47
>
>diff -r 02bac78bde96 -r 177fe9372668 source/common/x86/asm-primitives.cpp
>--- a/source/common/x86/asm-primitives.cpp Wed Feb 25 13:46:58 2015 +0530
>+++ b/source/common/x86/asm-primitives.cpp Wed Feb 25 14:19:56 2015 +0530
>@@ -1813,6 +1813,7 @@
>
> // intra_pred functions
> <a href="http://p.cu/" target="_blank">p.cu</a>[BLOCK_8x8].intra_pred[3] = x265_intra_pred_ang8_3_avx2;
>+ <a href="http://p.cu/" target="_blank">p.cu</a>[BLOCK_8x8].intra_pred[33] = x265_intra_pred_ang8_33_avx2;
> }
> }
> #endif // if HIGH_BIT_DEPTH
>diff -r 02bac78bde96 -r 177fe9372668 source/common/x86/intrapred.h
>--- a/source/common/x86/intrapred.h Wed Feb 25 13:46:58 2015 +0530
>+++ b/source/common/x86/intrapred.h Wed Feb 25 14:19:56 2015 +0530
>@@ -158,6 +158,7 @@
>
> #undef DECL_ANG
> void x265_intra_pred_ang8_3_avx2(pixel* dst, intptr_t dstStride, const pixel* srcPix, int dirMode, int bFilter);
>+void x265_intra_pred_ang8_33_avx2(pixel* dst, intptr_t dstStride, const pixel* srcPix, int dirMode, int bFilter);
> void x265_all_angs_pred_4x4_sse4(pixel *dest, pixel *refPix, pixel *filtPix, int bLuma);
> void x265_all_angs_pred_8x8_sse4(pixel *dest, pixel *refPix, pixel *filtPix, int bLuma);
> void x265_all_angs_pred_16x16_sse4(pixel *dest, pixel *refPix, pixel *filtPix, int bLuma);
>diff -r 02bac78bde96 -r 177fe9372668 source/common/x86/intrapred8.asm
>--- a/source/common/x86/intrapred8.asm Wed Feb 25 13:46:58 2015 +0530
>+++ b/source/common/x86/intrapred8.asm Wed Feb 25 14:19:56 2015 +0530
>@@ -32087,3 +32087,39 @@
> movq [r0 + 2 * r1], xm2
> movhps [r0 + r3], xm2
> RET
>+
>+INIT_YMM avx2
>+cglobal intra_pred_ang8_33, 3,4,5
>+ movu m3, [pw_1024]<br>Why constant are unaligned?</pre></div></div><pre style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial"><span><div><div class="h5">[Praveen] Seems alignment issue here, mova crashing on avx2 machine.<br></div></div>[MC] it is global constant, we may use ALIGN32 before pw_1024 to avoid crash and get more performance</span></pre><pre><span class=""><font face="arial" color="#000000"><span style="FONT-SIZE: 14px; LINE-HEIGHT: 1.7">[Praveen] why it needs special care ? why not other </span></font><font color="#000000"><span style="FONT-SIZE: 14px; LINE-HEIGHT: 23px">constants</span></font><font face="arial" color="#000000"><span style="FONT-SIZE: 14px; LINE-HEIGHT: 1.7"> needs ALIGN32.</span></font></span></pre><pre><span class=""><font face="arial" color="#000000"><span style="FONT-SIZE: 14px; LINE-HEIGHT: 1.7">[MC] in future, we need modify "macro const" to make all const aligned. in this case, we just alignment constant that we need.<br></span></font></span></pre>
>+ vbroadcasti128 m0, [<font face="arial" color="#000000"><span style="FONT-SIZE: 14px; LINE-HEIGHT: 1.7">r2 + 1]<br></span></font><span class="" style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial">it is Exception Type 6, please check and confirm it compatible with unaligned address</span><pre style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial"><span class="">[Praveen] Sadly most of documents don't talk about alignment regarding this instruction including Intel® Architecture Instruction Set Extensions Programming Reference but I verified with encoder seems it works fine with unaligned address too. <br></span>[MC] ok, if you try to assign unaligned address (manual in debug mode) and it work fine, we may ignore it.<div><div class="h5"><br>
>+
>+ pshufb m1, m0, [c_ang8_src1_9_2_10]
>+ pshufb m2, m0, [c_ang8_src3_11_4_12]
>+ pshufb m4, m0, [c_ang8_src5_13_5_13]
>+ pshufb m4, m0, [c_ang8_src5_13_5_13]<br>Why duplicated?</div></div></pre>
<div style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial">
<div class="h5"><pre>[Praveen] Yeah, duplicate code here, has been fixed locally. <br><div><div><br>
>+ pshufb m0, [c_ang8_src6_14_7_15]
>+
>+ pmaddubsw m1, [c_ang8_26_20]
>+ pmulhrsw m1, m3
>+ pmaddubsw m2, [c_ang8_14_8]
>+ pmulhrsw m2, m3
>+ pmaddubsw m4, [c_ang8_2_28]
>+ pmulhrsw m4, m3
>+ pmaddubsw m0, [c_ang8_22_16]
>+ pmulhrsw m0, m3
>+ packuswb m1, m2
>+ packuswb m4, m0
>+
>+ lea r3, [3 * r1]
>+ movq [r0], xm1
>+ vextracti128 xm2, m1, 1
>+ movq [r0 + r1], xm2
>+ movhps [r0 + 2 * r1], xm1
>+ movhps [r0 + r3], xm2
>+ lea r0, [r0 + 4 * r1]
>+ movq [r0], xm4
>+ vextracti128 xm2, m4, 1
>+ movq [r0 + r1], xm2
>+ movhps [r0 + 2 * r1], xm4
>+ movhps [r0 + </div></div>r3], xm2
>+ RET
>_______________________________________________
>x265-devel mailing list
><a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a>
><a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a>
</pre></div></div></div>
<div style="FONT-SIZE: 14px; COLOR: rgb(0,0,0); LINE-HEIGHT: 1.7; FONT-FAMILY: arial">
<div class="h5"><br>_______________________________________________<br>x265-devel mailing list<br><a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br><a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br><br></div></div></div><br></div></blockquote></div><br>_______________________________________________<br>x265-devel mailing list<br><a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br><a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br><br></div><br></div></blockquote></div>