<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 03/28/2015 03:20 PM, chen wrote:<br>
</div>
<blockquote
cite="mid:1fc931d2.5d.14c6279021a.Coremail.chenm003@163.com"
type="cite">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:arial">
<div> </div>
<pre>
At 2015-03-29 05:35:21,<a class="moz-txt-link-abbreviated" href="mailto:dtyx265@gmail.com">dtyx265@gmail.com</a> wrote:
># HG changeset patch
># User David T Yuen <a class="moz-txt-link-rfc2396E" href="mailto:dtyx265@gmail.com"><dtyx265@gmail.com></a>
># Date 1427576216 25200
># Node ID 0a75e3d50518e73f5a199d7519f800a9ff1c2e2c
># Parent 6595ba5f989fdd521e268911ddf027665a610e25
>asm:intra_pred_ang4_4_sse2 improved ~2% 647.49 -> 634.98 with nits and tweaks
>
>Corrected parameter count
>Changed r3 and r4 to r3d and r4d
>tweaked unpacking for performance
>
>diff -r 6595ba5f989f -r 0a75e3d50518 source/common/x86/intrapred8.asm
>--- a/source/common/x86/intrapred8.asm Sat Mar 28 13:40:20 2015 -0700
>+++ b/source/common/x86/intrapred8.asm Sat Mar 28 13:56:56 2015 -0700
>@@ -1413,23 +1413,22 @@
> movd [r0 + r1], m0
> RET
>
>-cglobal intra_pred_ang4_4, 3,5,8
>- xor r4, r4
>- inc r4
>+cglobal intra_pred_ang4_4, 4,5,8
</pre>
<pre>load parameter into r3, and overwrite in below?</pre>
<pre>>+ xor r4d, r4d
>+ inc r4d
> cmp r3m, byte 32</pre>
</div>
</blockquote>
After cmp sets flags, r3 is free to use.<br>
<blockquote
cite="mid:1fc931d2.5d.14c6279021a.Coremail.chenm003@163.com"
type="cite">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:arial">
<pre>
>- mov r3, 9
>- cmove r3, r4
>+ mov r3d, 9
>+ cmove r3d, r4d</pre>
</div>
</blockquote>
This is to allow reused for transposed mode 32.<br>
<blockquote
cite="mid:1fc931d2.5d.14c6279021a.Coremail.chenm003@163.com"
type="cite">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:arial">
<pre>
>
> movh m0, [r2 + r3] ; [8 7 6 5 4 3 2 1]
>+ punpcklbw m0, m0
>+ psrldq m0, 1
>+ mova m2, m0
>+ psrldq m2, 2 ; [x x x x x x x x 6 5 5 4 4 3 3 2]
> mova m1, m0
>- psrldq m1, 1 ; [x 8 7 6 5 4 3 2]
>- punpcklbw m0, m1 ; [x 8 8 7 7 6 6 5 5 4 4 3 3 2 2 1]
>- mova m1, m0
>- psrldq m1, 2 ; [x x x x x x x x 6 5 5 4 4 3 3 2]
>- mova m3, m0
>- psrldq m3, 4 ; [x x x x x x x x 7 6 6 5 5 4 4 3]
>- punpcklqdq m0, m1
>- punpcklqdq m2, m1, m3
>+ psrldq m1, 4 ; [x x x x x x x x 7 6 6 5 5 4 4 3]
>+ punpcklqdq m0, m2
>+ punpcklqdq m2, m1
>
> lea r3, [pw_ang_table + 18 * 16]
> mova m4, [r3 + 3 * 16] ; [21]
>_______________________________________________
>x265-devel mailing list
><a class="moz-txt-link-abbreviated" href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a>
><a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a>
</pre>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
x265-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a>
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>