<div dir="ltr">I have removed the above gcc warnings and sent the follow on patch above the patch series. <div>Smoke test passed with binary changes. <div> </div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 15, 2015 at 12:06 PM, Steve Borho <span dir="ltr"><<a href="mailto:steve@borho.org" target="_blank">steve@borho.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 04/13, <a href="mailto:ashok@multicorewareinc.com">ashok@multicorewareinc.com</a> wrote:<br>
> # HG changeset patch<br>
> # User Ashok Kumar Mishra<<a href="mailto:ashok@multicorewareinc.com">ashok@multicorewareinc.com</a>><br>
> # Date 1428931472 -19800<br>
> #      Mon Apr 13 18:54:32 2015 +0530<br>
> # Node ID f40431e676a90d87243b994632c74b25a93fed2f<br>
> # Parent  b86198988303ae3ec4eeb42017e654f01d0f30a9<br>
> stats: with the CU reference limit, even 8x8 can have skipped motion searches<br>
<br>
</span>I won't have time to review this series properly until next week, but<br>
please smoke test these with MinGW and linux/GCC:<br>
<br>
[  7%] Building ASM_YASM object common/CMakeFiles/common.dir/x86/ssd-a.asm.o<br>
/Users/steve/repos/x265-sborho/source/encoder/analysis.cpp: In member function 'uint32_t x265::Analysis::compressInterCU_rd0_4(cons<br>
/Users/steve/repos/x265-sborho/source/encoder/analysis.cpp:969:80: warning: suggest braces around empty body in an 'else' statement<br>
                         ProfileCounter(parentCTU, skippedIntraCU[cuGeom.depth]);<br>
                                                                                ^<br>
/Users/steve/repos/x265-sborho/source/encoder/analysis.cpp:993:80: warning: suggest braces around empty body in an 'else' statement<br>
                         ProfileCounter(parentCTU, skippedIntraCU[cuGeom.depth]);<br>
                                                                                ^<br>
/Users/steve/repos/x265-sborho/source/encoder/analysis.cpp:1117:18: warning: declaration of 'depth' shadows a previous local [-Wsha<br>
         uint32_t depth = cu.m_cuDepth[0];<br>
                  ^<br>
/Users/steve/repos/x265-sborho/source/encoder/analysis.cpp:748:14: warning: shadowed declaration is here [-Wshadow]<br>
     uint32_t depth = cuGeom.depth;<br>
              ^<br>
<span class="HOEnZb"><font color="#888888">--<br>
Steve Borho<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</font></span></blockquote></div><br></div>