<div dir="ltr"><div>Hi Steve,<br><br></div>For now, lets keep it to integer levels, the highest level writes the most amount of information in the CSV. We can fine tune this later, after all the new information has been captured, if we can come up with meaningful names for each of these levels. <br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 10, 2015 at 9:18 PM, Steve Borho <span dir="ltr"><<a href="mailto:steve@borho.org" target="_blank">steve@borho.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 06/10, Divya Manivannan wrote:<br>
> # HG changeset patch<br>
> # User Divya Manivannan <<a href="mailto:divya@multicorewareinc.com">divya@multicorewareinc.com</a>><br>
> # Date 1433942092 -19800<br>
> # Wed Jun 10 18:44:52 2015 +0530<br>
> # Node ID 1225ccb9f8ae9dbc58379e01072a1c3f55cacb61<br>
> # Parent fd1018a48cc60d7ff6359a8a18ed01d6ae46324b<br>
> cli: add --csv-data as CLI only option to mention the level of csv logging<br>
<br>
</span>the only question I have is whether a level integer is what we want, or<br>
if we want something more flexible.<br>
<div><div class="h5"><br>
> diff -r fd1018a48cc6 -r 1225ccb9f8ae doc/reST/cli.rst<br>
> --- a/doc/reST/cli.rst Wed Jun 10 18:39:36 2015 +0530<br>
> +++ b/doc/reST/cli.rst Wed Jun 10 18:44:52 2015 +0530<br>
> @@ -82,7 +82,7 @@<br>
><br>
> Writes encoding results to a comma separated value log file. Creates<br>
> the file if it doesnt already exist, else adds one line per run. if<br>
> - :option:`--log-level` is frame or above, it writes one line per<br>
> + :option:`--csv-data` is greater than 0, it writes one line per<br>
> frame. Default none<br>
><br>
> When frame level logging is enabled, several frame performance<br>
> @@ -127,6 +127,16 @@<br>
><br>
> **CLI ONLY**<br>
><br>
> +.. option:: --csv-data <integer><br>
> +<br>
> + CSV logging level. Default 0<br>
> +<br>
> + 0. summary<br>
> + 1. frame level logging<br>
> + 2. detailed frame level logging<br>
> +<br>
> + **CLI ONLY**<br>
> +<br>
> .. option:: --ssim, --no-ssim<br>
><br>
> Calculate and report Structural Similarity values. It is<br>
> diff -r fd1018a48cc6 -r 1225ccb9f8ae source/CMakeLists.txt<br>
> --- a/source/CMakeLists.txt Wed Jun 10 18:39:36 2015 +0530<br>
> +++ b/source/CMakeLists.txt Wed Jun 10 18:44:52 2015 +0530<br>
> @@ -30,7 +30,7 @@<br>
> mark_as_advanced(FPROFILE_USE FPROFILE_GENERATE NATIVE_BUILD)<br>
><br>
> # X265_BUILD must be incremented each time the public API is changed<br>
> -set(X265_BUILD 62)<br>
> +set(X265_BUILD 63)<br>
<br>
</div></div>since this patch is not affecting x265.h, it does not need to bump the<br>
build number<br>
<div class="HOEnZb"><div class="h5"><br>
> configure_file("${PROJECT_SOURCE_DIR}/<a href="http://x265.def.in" target="_blank">x265.def.in</a>"<br>
> "${PROJECT_BINARY_DIR}/x265.def")<br>
> configure_file("${PROJECT_SOURCE_DIR}/<a href="http://x265_config.h.in" target="_blank">x265_config.h.in</a>"<br>
> diff -r fd1018a48cc6 -r 1225ccb9f8ae source/x265.cpp<br>
> --- a/source/x265.cpp Wed Jun 10 18:39:36 2015 +0530<br>
> +++ b/source/x265.cpp Wed Jun 10 18:44:52 2015 +0530<br>
> @@ -90,6 +90,7 @@<br>
> bool bProgress;<br>
> bool bForceY4m;<br>
> bool bDither;<br>
> + int csvData;<br>
> uint32_t seek; // number of frames to skip from the beginning<br>
> uint32_t framesToBeEncoded; // number of frames to encode<br>
> uint64_t totalbytes;<br>
> @@ -117,6 +118,7 @@<br>
> startTime = x265_mdate();<br>
> prevUpdateTime = 0;<br>
> bDither = false;<br>
> + csvData = 0;<br>
> }<br>
><br>
> void destroy();<br>
> @@ -356,6 +358,7 @@<br>
> OPT2("frame-skip", "seek") this->seek = (uint32_t)x265_atoi(optarg, bError);<br>
> OPT("frames") this->framesToBeEncoded = (uint32_t)x265_atoi(optarg, bError);<br>
> OPT("csv") this->csvfn = optarg;<br>
> + OPT("csv-data") this->csvData = x265_atoi(optarg, bError);<br>
> OPT("no-progress") this->bProgress = false;<br>
> OPT("output") outputfn = optarg;<br>
> OPT("input") inputfn = optarg;<br>
> diff -r fd1018a48cc6 -r 1225ccb9f8ae source/x265cli.h<br>
> --- a/source/x265cli.h Wed Jun 10 18:39:36 2015 +0530<br>
> +++ b/source/x265cli.h Wed Jun 10 18:44:52 2015 +0530<br>
> @@ -54,6 +54,7 @@<br>
> { "allow-non-conformance",no_argument, NULL, 0 },<br>
> { "no-allow-non-conformance",no_argument, NULL, 0 },<br>
> { "csv", required_argument, NULL, 0 },<br>
> + { "csv-data", required_argument, NULL, 0 },<br>
> { "no-cu-stats", no_argument, NULL, 0 },<br>
> { "cu-stats", no_argument, NULL, 0 },<br>
> { "y4m", no_argument, NULL, 0 },<br>
> @@ -246,7 +247,8 @@<br>
> H0("-D/--output-depth 8|10 Output bit depth (also internal bit depth). Default %d\n", param->internalBitDepth);<br>
> H0(" --log-level <string> Logging level: none error warning info debug full. Default %s\n", X265_NS::logLevelNames[param->logLevel + 1]);<br>
> H0(" --no-progress Disable CLI progress reports\n");<br>
> - H1(" --csv <filename> Comma separated log file, log level >= 3 frame log, else one line per run\n");<br>
> + H0(" --csv <filename> Comma separated log file, csv-data > 0 frame log, else one line per run\n");<br>
> + H0(" --csv-data Level of csv logging: summary FrameLevelData DetailedFrameLevelData\n");<br>
> H0("\nInput Options:\n");<br>
> H0(" --input <filename> Raw YUV or Y4M input file name. `-` for stdin\n");<br>
> H1(" --y4m Force parsing of input stream as YUV4MPEG2 regardless of file extension\n");<br>
> _______________________________________________<br>
> x265-devel mailing list<br>
> <a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
> <a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Steve Borho<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</div></div></blockquote></div><br></div>