<div dir="ltr"><div>Ah, this was a typo.<br></div>We dont have a Windows XP machine in our test farm, so we're hitting blind. I don't think the second error that was reported on XP with no-assembly has been fixed. <br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 22, 2015 at 3:12 PM, Mario *LigH* Rohkrämer <span dir="ltr"><<a href="mailto:contact@ligh.de" target="_blank">contact@ligh.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A lot of warnings in XP compatible Win32 builds with GCC 4.8.2 (here the HIGH_BIT_DEPTH setup, the 8-bit fails too):<br>
<br>
+----<br>
Scanning dependencies of target clean-generated<br>
Built target clean-generated<br>
-- cmake version 3.3.0-rc1<br>
-- Detected x86 target processor<br>
-- Found Yasm 1.3.0 to build assembly primitives<br>
-- hg found at e:/Programme/TortoiseHg/hg.exe<br>
-- x265 version 1.7+206-e8dc042008fa<br>
-- Configuring done<br>
-- Generating done<br>
-- Build files have been written to: H:/MSYS/home/Entwicklung/x265/build/msys_hbd<br>
Scanning dependencies of target common<br>
[ 1%] Building CXX object common/CMakeFiles/common.dir/winxp.cpp.obj<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,<br>
from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:<br>
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:52:37: error: 'x265_NS' does not name a type<br>
#define CONDITION_VARIABLE x265_NS::ConditionVariable<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:211:5: note: in expansion of macro 'CONDITION_VARIABLE'<br>
CONDITION_VARIABLE m_cv;<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In constructor 'x265::ThreadSafeInteger::ThreadSafeInteger()':<br>
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:53:37: error: 'x265_NS' has not been declared<br>
#define InitializeConditionVariable x265_NS::cond_init<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:158:9: note: in expansion of macro 'InitializeConditionVariable'<br>
InitializeConditionVariable(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:158:38: error: 'm_cv' was not declared in this scope<br>
InitializeConditionVariable(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,<br>
from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In destructor 'x265::ThreadSafeInteger::~ThreadSafeInteger()':<br>
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:57:37: error: 'x265_NS' has not been declared<br>
#define XP_CONDITION_VAR_FREE x265_NS::cond_destroy<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:164:9: note: in expansion of macro 'XP_CONDITION_VAR_FREE'<br>
XP_CONDITION_VAR_FREE(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:164:32: error: 'm_cv' was not declared in this scope<br>
XP_CONDITION_VAR_FREE(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,<br>
from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member function 'int x265::ThreadSafeInteger::waitForChange(int)':<br>
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:54:37: error: 'x265_NS' has not been declared<br>
#define SleepConditionVariableCS x265_NS::cond_wait<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:171:13: note: in expansion of macro 'SleepConditionVariableCS'<br>
SleepConditionVariableCS(&m_cv, &m_cs, INFINITE);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:171:39: error: 'm_cv' was not declared in this scope<br>
SleepConditionVariableCS(&m_cv, &m_cs, INFINITE);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,<br>
from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member function 'void x265::ThreadSafeInteger::set(int)':<br>
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:56:37: error: 'x265_NS' has not been declared<br>
#define WakeAllConditionVariable x265_NS::cond_broadcast<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:188:9: note: in expansion of macro 'WakeAllConditionVariable'<br>
WakeAllConditionVariable(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:188:35: error: 'm_cv' was not declared in this scope<br>
WakeAllConditionVariable(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,<br>
from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member function 'void x265::ThreadSafeInteger::poke()':<br>
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:56:37: error: 'x265_NS' has not been declared<br>
#define WakeAllConditionVariable x265_NS::cond_broadcast<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:196:9: note: in expansion of macro 'WakeAllConditionVariable'<br>
WakeAllConditionVariable(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:196:35: error: 'm_cv' was not declared in this scope<br>
WakeAllConditionVariable(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,<br>
from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member function 'void x265::ThreadSafeInteger::incr()':<br>
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:56:37: error: 'x265_NS' has not been declared<br>
#define WakeAllConditionVariable x265_NS::cond_broadcast<br>
^<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:204:9: note: in expansion of macro 'WakeAllConditionVariable'<br>
WakeAllConditionVariable(&m_cv);<br>
^<br>
In file included from h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:<br>
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:204:35: error: 'm_cv' was not declared in this scope<br>
WakeAllConditionVariable(&m_cv);<br>
^<br>
make[2]: *** [common/CMakeFiles/common.dir/winxp.cpp.obj] Error 1<br>
make[1]: *** [common/CMakeFiles/common.dir/all] Error 2<br>
make: *** [all] Error 2<br>
+----<span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
<br>
Fun and success!<br>
Mario *LigH* Rohkrämer<br>
mailto:<a href="mailto:contact@ligh.de" target="_blank">contact@ligh.de</a><br>
<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</font></span></blockquote></div><br></div>