<div dir="ltr">Thanks. we can add double quotes to string while dumping to csv, it works. will resend the patch.<br><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 15, 2015 at 4:18 PM, Mario *LigH* Rohkrämer <span dir="ltr"><<a href="mailto:contact@ligh.de" target="_blank">contact@ligh.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">IMHO the wrong "solution"; CSV supports string cells in double quotes, so I'd prefer wrapping string values in double quotes if they contain a comma (double quotes inside strings are to be escaped by doubling them).<br>
<br>
There are also variants of CSV preferring semicola as cell separators. This is also safer for the Germal locale using a decimal comma instead of decimal dot (even though numeric values in CSV files will probably be saved in "English" notation instead of locale dependent).<div><div class="h5"><br>
<br>
<br>
Am 15.10.2015, 12:21 Uhr, schrieb <<a href="mailto:mahesh@multicorewareinc.com" target="_blank">mahesh@multicorewareinc.com</a>>:<br>
<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
# HG changeset patch<br>
# User Mahesh Pittala <<a href="mailto:mahesh@multicorewareinc.com" target="_blank">mahesh@multicorewareinc.com</a>><br>
# Date 1444904078 -19800<br>
# Thu Oct 15 15:44:38 2015 +0530<br>
# Node ID 6e001b1e7bef6835b61d972977565d069690f65d<br>
# Parent b6156a08b1def3584647f26096866c1a0c11e54a<br>
replace comma with dot seperator from commandline when dumping to csv<br>
<br>
When we add comma in commandline, commandline splitting into multiple cells in csv<br>
so the header and data are mismatching<br>
<br>
diff -r b6156a08b1de -r 6e001b1e7bef source/common/threadpool.cpp<br>
--- a/source/common/threadpool.cpp Fri Oct 09 20:45:59 2015 +0530<br>
+++ b/source/common/threadpool.cpp Thu Oct 15 15:44:38 2015 +0530<br>
@@ -298,10 +298,10 @@<br>
nodeMaskPerPool[i] = ((uint64_t)1 << i);<br>
}<br>
- /* consume current node string, comma, and white-space */<br>
- while (*nodeStr && *nodeStr != ',')<br>
+ /* consume current node string, comma, period, and white-space */<br>
+ while (*nodeStr && *nodeStr != ',' && *nodeStr != '.')<br>
++nodeStr;<br>
- if (*nodeStr == ',' || *nodeStr == ' ')<br>
+ if (*nodeStr == ',' || *nodeStr == '.' || *nodeStr == ' ')<br>
++nodeStr;<br>
}<br>
}<br>
diff -r b6156a08b1de -r 6e001b1e7bef source/x265-extras.cpp<br>
--- a/source/x265-extras.cpp Fri Oct 09 20:45:59 2015 +0530<br>
+++ b/source/x265-extras.cpp Thu Oct 15 15:44:38 2015 +0530<br>
@@ -201,7 +201,11 @@<br>
for (int i = 1; i < argc; i++)<br>
{<br>
if (i) fputc(' ', csvfp);<br>
- fputs(argv[i], csvfp);<br>
+ for (int j = 0; j < strlen(argv[i]); j++)<br>
+ if (argv[i][j] == ',')<br>
+ fputc ('.', csvfp);<br>
+ else<br>
+ fputc (argv[i][j], csvfp);<br>
}<br>
// current date and time<br></div></div>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><span class="HOEnZb"><font color="#888888"><br>
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<br>
-- <br>
<br>
Fun and success!<br>
Mario *LigH* Rohkrämer<br>
mailto:<a href="mailto:contact@ligh.de" target="_blank">contact@ligh.de</a><br>
<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</font></span></blockquote></div><br></div></div></div></div></div>