<div dir="ltr">sure, will resend the patch.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 17, 2015 at 3:43 PM, Deepthi Nandakumar <span dir="ltr"><<a href="mailto:deepthi@multicorewareinc.com" target="_blank">deepthi@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Hmm, ok. Pls do a toupper before strcmp, so that you can account for lowercase inputs also.</p>
<div style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"># HG changeset patch<br>
# User Mahesh Pittala <<a href="mailto:mahesh@multicorewareinc.com" target="_blank">mahesh@multicorewareinc.com</a>><br>
# Date 1450172601 -19800<br>
# Tue Dec 15 15:13:21 2015 +0530<br>
# Node ID d64d110a4f92e1e78ee48da8007a2d7cef6fe1b7<br>
# Parent e951ab673b1c3d41ef86bc623f20ecc768d3f5c5<br>
threadpool: use all available threads on each NUMA node with --pools=NULL option too<br>
<br>
<br>
from x265.readthedocs, --pools = NULL, "", "*" are doing same functionality.<br>
--pools="" & --pools="*" are using all threads but when we pass --pools=NULL, disabled<br>
all threads pools but supposed to enable.<br>
<br>
diff -r e951ab673b1c -r d64d110a4f92 source/common/threadpool.cpp<br>
--- a/source/common/threadpool.cpp Fri Dec 11 07:33:41 2015 +0530<br>
+++ b/source/common/threadpool.cpp Tue Dec 15 15:13:21 2015 +0530<br>
@@ -277,7 +277,7 @@<br>
}<br>
else if (*nodeStr == '-')<br>
threadsPerPool[i] = 0;<br>
- else if (*nodeStr == '*')<br>
+ else if (*nodeStr == '*' || !strcmp(nodeStr, "NULL"))<br>
{<br>
for (int j = i; j < numNumaNodes; j++)<br>
{<br></div></div>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</div>
<br>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br></blockquote></div><br></div>