<div dir="ltr"><div>I have tested on Linux, Mac and windows, now it is fine. if you think it still through an error on different platforms then my second patch(<span style="font-size:12.8px">toupper)</span> is better for all.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 22, 2015 at 6:15 PM, <span dir="ltr"><<a href="mailto:mahesh@multicorewareinc.com" target="_blank">mahesh@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""># HG changeset patch<br>
# User Mahesh Pittala <<a href="mailto:mahesh@muticorewareinc.com">mahesh@muticorewareinc.com</a>><br>
</span># Date 1450788208 -19800<br>
# Tue Dec 22 18:13:28 2015 +0530<br>
# Node ID 6a0bb9c80bd3f5e8d66ac04c0f44c88ec83345d1<br>
<span class=""># Parent 5276fbdce4bd2598b8ccf363319f94c31523272d<br>
threadpool: use all available threads on each NUMA node with --pools=NULL option too<br>
<br>
from x265.readthedocs, --pools = NULL, "", "*" are doing same functionality.<br>
--pools="" & --pools="*" are using all threads but when we pass --pools=NULL, disabled<br>
all threads pools but supposed to enable.<br>
<br>
</span>diff -r 5276fbdce4bd -r 6a0bb9c80bd3 source/common/threadpool.cpp<br>
<span class="">--- a/source/common/threadpool.cpp Tue Dec 22 09:05:34 2015 +0530<br>
</span>+++ b/source/common/threadpool.cpp Tue Dec 22 18:13:28 2015 +0530<br>
@@ -60,6 +60,9 @@<br>
#if HAVE_LIBNUMA<br>
#include <numa.h><br>
#endif<br>
+#if defined(_MSC_VER)<br>
+# define strcasecmp _stricmp<br>
+#endif<br>
<br>
namespace X265_NS {<br>
// x265 private namespace<br>
@@ -277,7 +280,7 @@<br>
<div class="HOEnZb"><div class="h5"> }<br>
else if (*nodeStr == '-')<br>
threadsPerPool[i] = 0;<br>
- else if (*nodeStr == '*')<br>
+ else if (*nodeStr == '*' || !strcasecmp(nodeStr, "NULL"))<br>
{<br>
for (int j = i; j < numNumaNodes; j++)<br>
{<br>
</div></div></blockquote></div><br></div>