<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"><meta name="Generator" content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang="EN-US" link="blue" vlink="purple"><div class="WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">There are multiple types of NAL units. All NAL units do not contain video slices (which make up frames... for x265 we use only 1 slice per frame today). Your code removed all non-picture NAL units, including the SPS (Sequence Parameter Set) and PPS (Picture Parameter Set), which are an essential part of the bitstream. Without the SPS and PPS, a decoder can’t decode the slices.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">See <a href="http://www.codeproject.com/Tips/896030/The-Structure-of-HEVC-Video">http://www.codeproject.com/Tips/896030/The-Structure-of-HEVC-Video</a> for a decent explanation.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Your code needs to check the NAL unit type before proceeding to check the frame size.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Tom</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><div><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> x265-devel [mailto:<a href="mailto:x265-devel-bounces@videolan.org">x265-devel-bounces@videolan.org</a>] <b>On Behalf Of </b>Dolevo Jay<br><b>Sent:</b> Thursday, August 11, 2016 2:28 PM<br><b>To:</b> Development for x265<br><b>Subject:</b> Re: [x265] no SPS/PPS yet, * will be dropped</span></p></div></div><p class="MsoNormal"> </p><div id="divtagdefaultwrapper"><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">Sorry for my previous unfinished email. Let me continue here:</span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">After encoding some frames, I get the bitstream in dumpfileEncodedData. In order to verify that this is a valid bitstream, I wanted to play this file with gstreamer (just for easiness). I run the </span><span style="font-family:"Arial","sans-serif";color:black">following pipeline:</span><span style="font-family:"Calibri","sans-serif";color:black"></span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:black">GST_DEBUG=h265*:4 gst-launch-1.0 filesrc location=dumpedEncodedStream.265 ! h265parse ! fakesink</span><span style="font-family:"Calibri","sans-serif";color:black"></span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:black">I get the following messages from Gstreamer:</span><span style="font-family:"Calibri","sans-serif";color:black"></span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:black"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914">Setting pipeline to PAUSED ...</span><span style="font-size:9.0pt;color:black"></span></p><p style="background:black"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914">Pipeline is PREROLLING ...</span><span style="font-size:9.0pt;color:black"></span></p><p style="background:black"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914">0:00:00.026579000 31834 0x7fd3ac8289e0 </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#afad24">WARN </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914"> h265parse gsth265parse.c:981:gst_h265_parse_handle_frame:<h265parse0> no SPS/PPS yet, nal Type: 19 SLICE_IDR_W_RADL, Size: 344694 will be dropped</span><span style="font-size:9.0pt;color:black"></span></p><p style="background:black"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914">0:00:00.026784000 31834 0x7fd3ac8289e0 </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#afad24">WARN </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914"> h265parse gsth265parse.c:981:gst_h265_parse_handle_frame:<h265parse0> no SPS/PPS yet, nal Type: 1 Slice_TRAIL_R, Size: 61343 will be dropped</span><span style="font-size:9.0pt;color:black"></span></p><p style="background:black"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914">0:00:00.026922000 31834 0x7fd3ac8289e0 </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#afad24">WARN </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914"> h265parse gsth265parse.c:981:gst_h265_parse_handle_frame:<h265parse0> no SPS/PPS yet, nal Type: 1 Slice_TRAIL_R, Size: 77539 will be dropped</span><span style="font-size:9.0pt;color:black"></span></p><p style="background:black"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914">0:00:00.027144000 31834 0x7fd3ac8289e0 </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#afad24">WARN </span><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:#29f914"> h265parse gsth265parse.c:981:gst_h265_parse_handle_frame:<h265parse0> no SPS/PPS yet, nal Type: 1 Slice_TRAIL_R, Size: 80666 will be dropped</span><span style="font-size:9.0pt;color:black"></span></p><p class="MsoNormal" style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:black">So, my frames are being dropped for some reason. Could anyone shed some light what the problem would be?</span><span style="font-family:"Calibri","sans-serif";color:black"></span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:black">Thanks in advance,</span><span style="font-family:"Calibri","sans-serif";color:black"></span></p><p style="background:white"><span style="font-size:9.0pt;font-family:"Arial","sans-serif";color:black">Regards</span><span style="font-family:"Calibri","sans-serif";color:black"></span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p></div><div class="MsoNormal" align="center" style="text-align:center"><hr size="2" width="98%" align="center"></div><div id="divRplyFwdMsg"><p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"> x265-devel <<a href="mailto:x265-devel-bounces@videolan.org">x265-devel-bounces@videolan.org</a>> on behalf of Dolevo Jay <<a href="mailto:cmst@live.com">cmst@live.com</a>><br><b>Sent:</b> Thursday, August 11, 2016 9:23:26 PM<br><b>To:</b> <a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br><b>Subject:</b> [x265] no SPS/PPS yet, * will be dropped</span> </p><div><p class="MsoNormal"> </p></div></div><div><div id="divtagdefaultwrapper"><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">Hi all,</span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">In my encoder application, I initialize the encoder as follows:</span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><pre style="background:white"><span style="color:maroon"> param</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">x265_param_alloc();</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">x265_param_default(</span><span style="color:maroon">param</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">x265_param_default_preset(</span><span style="color:maroon">param</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:green">"ultrafast"</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:green">"zerolatency"</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">fpsNum</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:navy">25</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">fpsDenom</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:navy">1</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">bRepeatHeaders</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:olive">true</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">internalCsp</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:navy">X265_CSP_I420</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">sourceWidth</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">aWidth;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">sourceHeight</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">aHeight;</span></pre><pre style="background:white"><span style="color:black"> </span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">y_size</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">sourceWidth</span><span style="color:silver"> </span><span style="color:black">*</span><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">sourceHeight</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:black"> </span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">logLevel</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:navy">X265_LOG_FULL</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:black"> </span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">encoder</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:navy">x265_encoder_open</span><span style="color:black">(</span><span style="color:maroon">param</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:olive">if</span><span style="color:silver"> </span><span style="color:black">(</span><span style="color:navy">NULL</span><span style="color:silver"> </span><span style="color:black">==</span><span style="color:silver"> </span><span style="color:maroon">encoder</span><span style="color:black">)</span><span style="color:silver"> </span><span style="color:black">{</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">print</span><i><span style="color:black">Log</span></i><span style="color:black">(</span><span style="color:green">"[X265]</span><span style="color:silver"> </span><span style="color:green">x265_encoder_open</span><span style="color:silver"> </span><span style="color:green">err"</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:olive">return</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">}</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">param</span><span style="color:black">-></span><span style="color:maroon">internalCsp</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:navy">X265_CSP_I420</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:black"> </span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">x265_picture_alloc();</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">x265_picture_init(</span><span style="color:maroon">param</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:black">-></span><span style="color:maroon">planes</span><span style="color:black">[</span><span style="color:navy">0</span><span style="color:black">]</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:olive">new</span><span style="color:silver"> </span><span style="color:olive">char</span><span style="color:black">[</span><span style="color:navy">32000000</span><span style="color:black">];</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:black">-></span><span style="color:maroon">planes</span><span style="color:black">[</span><span style="color:navy">1</span><span style="color:black">]</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:olive">new</span><span style="color:silver"> </span><span style="color:olive">char</span><span style="color:black">[</span><span style="color:navy">32000000</span><span style="color:black">];</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:black">-></span><span style="color:maroon">planes</span><span style="color:black">[</span><span style="color:navy">2</span><span style="color:black">]</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:olive">new</span><span style="color:silver"> </span><span style="color:olive">char</span><span style="color:black">[</span><span style="color:navy">32000000</span><span style="color:black">];</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:black">-></span><span style="color:maroon">stride</span><span style="color:black">[</span><span style="color:navy">0</span><span style="color:black">]</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">aWidth;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:black">-></span><span style="color:maroon">stride</span><span style="color:black">[</span><span style="color:navy">1</span><span style="color:black">]</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">aWidth;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_in</span><span style="color:black">-></span><span style="color:maroon">stride</span><span style="color:black">[</span><span style="color:navy">2</span><span style="color:black">]</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">aWidth;</span></pre><pre style="background:white"><span style="color:black"> </span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">pic_out</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">x265_picture_alloc();</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">x265_picture_init(</span><span style="color:maroon">param</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:maroon">pic_out</span><span style="color:black">);</span></pre><p class="MsoNormal" style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">Then, I apply the following function for each incoming frame:</span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><pre style="background:white"><span style="color:silver"> </span><span style="color:olive">int</span><span style="color:silver"> </span><span style="color:black">frame_size</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:navy">0</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:black"> </span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:purple">x265_picture</span><span style="color:silver"> </span><span style="color:black">pic_out1;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">frame_size</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:black">x265_encoder_encode(</span><span style="color:maroon">encoder</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:black">&</span><span style="color:maroon">pNals</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:black">&</span><span style="color:maroon">iNal</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:black">pic_in,</span><span style="color:silver"> </span><span style="color:navy">NULL</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:olive">if</span><span style="color:silver"> </span><span style="color:black">(frame_size</span><span style="color:silver"> </span><span style="color:black"><</span><span style="color:silver"> </span><span style="color:navy">0</span><span style="color:black">)</span><span style="color:silver"> </span><span style="color:black">{</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:maroon">print</span><i><span style="color:black">Log</span></i><span style="color:black">(</span><span style="color:green">"[ERROR]</span><span style="color:silver"> </span><span style="color:green">H265:</span><span style="color:silver"> </span><span style="color:green">x265_encoder_encode</span><span style="color:silver"> </span><span style="color:green">failed."</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:olive">return</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">}</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:olive">if</span><span style="color:silver"> </span><span style="color:black">(frame_size</span><span style="color:silver"> </span><span style="color:black">></span><span style="color:silver"> </span><span style="color:navy">0</span><span style="color:black">)</span><span style="color:silver"> </span><span style="color:black">{</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">memcpy(aFramebuffer,</span><span style="color:silver"> </span><span style="color:maroon">pNals</span><span style="color:black">[</span><span style="color:navy">0</span><span style="color:black">].</span><span style="color:maroon">payload</span><span style="color:black">,</span><span style="color:silver"> </span><span style="color:maroon">pNals</span><span style="color:black">[</span><span style="color:navy">0</span><span style="color:black">].</span><span style="color:maroon">sizeBytes</span><span style="color:black">);</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">*aFrameBufferSize</span><span style="color:silver"> </span><span style="color:black">=</span><span style="color:silver"> </span><span style="color:maroon">pNals</span><span style="color:black">[</span><span style="color:navy">0</span><span style="color:black">].</span><span style="color:maroon">sizeBytes</span><span style="color:black">;</span></pre><pre style="background:white"><span style="color:silver"> </span><span style="color:black">}</span></pre><pre style="background:white"><span style="color:black"> </span></pre><pre style="background:white"><span style="color:maroon"> dumpfileEncodedData</span><span style="color:black">.write((</span><span style="color:olive">const</span><span style="color:silver"> </span><span style="color:olive">char</span><span style="color:silver"> </span><span style="color:black">*)aFramebuffer,</span><span style="color:silver"> </span><span style="color:black">*aFrameBufferSize);</span></pre><pre style="background:white"><span style="color:black"> </span></pre><p class="MsoNormal" style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">Just to debug the encoded bitstream, I dump the data into a file </span></p><p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> </span></p></div></div></div></body></html>