<div dir="ltr"><div>Min,</div><div><br></div>Yes to confirm with the output-mismatch, I just checked with very basic commandline <b>BasketballDrive_1920x1080_50.y4m --preset ultrafast .</b><div> The outputs are getting mismatched in all three builds(8/10/12 builds) in vc12-x86_64. I builded each build separately and compared.</div><div>As praveen said only binary file sizes remained same, but outputs mismatched.</div><div> </div><div>I checked on changeset-d20b78d6d138 , and applying your patch on top of this changeset ..</div><div><br></div><div>Can we know at which tip you tested ? and anyother way you compared ? </div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Thanks,<div>Aasaipriya</div></div></div></div>
<br><div class="gmail_quote">On Fri, Sep 23, 2016 at 4:04 PM, Praveen Tiwari <span dir="ltr"><<a href="mailto:praveen@multicorewareinc.com" target="_blank">praveen@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:georgia,serif;color:rgb(0,0,0)">Hi Min,</div><div class="gmail_default" style="font-family:georgia,serif;color:rgb(0,0,0)"> Can you please verify for VC12 ? I double checked on this I am getting different output for this patch. 8-bit encoded file size is same but different binary (compared using beyond compare), 10 and 12 bit size and binary both are different. I applied you patch build once (like 8 bit build) and collected all depth outputs (8, 10 and 12), compared with three builds of x265 i.e 8 bit, 10 bit and 12 bit. </div><div class="gmail_default" style="font-family:georgia,serif;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:georgia,serif;color:rgb(0,0,0)">Regards,</div><div class="gmail_default" style="font-family:georgia,serif;color:rgb(0,0,0)">Praveen </div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 23, 2016 at 2:47 AM, chen <span dir="ltr"><<a href="mailto:chenm003@163.com" target="_blank">chenm003@163.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="line-height:1.7;color:#000000;font-size:14px;font-family:arial">Hi Praveen,<div><br></div><div>I test your cmdlind on my VS2008 <span style="line-height:23.8px">build.</span></div><div><span style="line-height:1.7">I build three bit-depth version and compare with one bit-depth version, but </span><span style="line-height:23.8px">the output are still matched in both 10 and 12 bit.</span></div><div><span style="line-height:1.7"><br></span></div><div>Regards,</div><div>Min</div><div><div class="h5"><div><div><div><br>At 2016-09-22 14:39:50,"Praveen Tiwari" <<a href="mailto:praveen@multicorewareinc.com" target="_blank">pra<wbr>veen@multicorewareinc.com</a>> wrote:<br> <blockquote style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;color:rgb(0,0,255)">Hi Min,</div><div class="gmail_default" style="font-family:verdana,sans-serif;color:rgb(0,0,255)"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif;color:rgb(0,0,255)"> After this patch outputs are changing, tested for following command line for 10-bit and 12-bit outputs.</div><div class="gmail_default" style="font-family:verdana,sans-serif;color:rgb(0,0,255)"><br></div><div class="gmail_default"><font color="#0000ff" face="verdana, sans-serif">--input=NebutaFestival_2560x16<wbr>00_60_10bit_crop.yuv --input-res=2560x1600 --fps=60 --numa-pools="NULL" --output-depth=12 --hash=1 -o NFOut12.hevc</font><br></div><div class="gmail_default"><font color="#0000ff" face="verdana, sans-serif"><br></font></div><div class="gmail_default"><font color="#0000ff" face="verdana, sans-serif"><br></font></div><div class="gmail_default" style="font-family:verdana,sans-serif;color:rgb(0,0,255)"><br></div></div><div class="gmail_extra"><br clear="all"><div><div data-smartmail="gmail_signature"><div dir="ltr">Regards,<div>Praveen</div></div></div></div>
<br><div class="gmail_quote">On Thu, Sep 15, 2016 at 1:55 AM, chen <span dir="ltr"><<a href="mailto:chenm003@163.com" target="_blank">chenm003@163.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="line-height:1.7;color:#000000;font-size:14px;font-family:arial"><div>From ea50e494473623ed0dbff2907194aa<wbr>f268dc449a Mon Sep 17 00:00:00 2001</div><div>From: Min Chen <<a href="mailto:min.chen@multicorewareinc.com" target="_blank">min.chen@multicorewareinc.com</a><wbr>></div><div>Date: Wed, 14 Sep 2016 15:23:38 -0500</div><div>Subject: [PATCH] [multi-lib] Support 8+10+12 bits in single DLL (Workaround)</div><div><br></div><div>---</div><div> source/CMakeLists.txt | 40 ++++++++++++++++++++++++++++++<wbr>+++++++++-</div><div> 1 files changed, 39 insertions(+), 1 deletions(-)</div><div><br></div><div>diff --git a/source/CMakeLists.txt b/source/CMakeLists.txt</div><div>index dd19d28..c2c2f7f 100644</div><div>--- a/source/CMakeLists.txt</div><div>+++ b/source/CMakeLists.txt</div><div>@@ -36,6 +36,7 @@ configure_file("${PROJECT_SOUR<wbr>CE_DIR}/<a href="http://x265.def.in" target="_blank">x265.def.in</a>"</div><div> configure_file("${PROJECT_SOU<wbr>RCE_DIR}/<a href="http://x265_config.h.in" target="_blank">x265_config.h.in</a>"</div><div> "${PROJECT_BINARY_DIR}/x265_co<wbr>nfig.h")</div><div> </div><div>+</div><div> SET(CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake" "${CMAKE_MODULE_PATH}")</div><div> </div><div> # System architecture detection</div><div>@@ -396,6 +397,39 @@ if(WIN32)</div><div> endif(WINXP_SUPPORT)</div><div> endif()</div><div> </div><div>+</div><div>+if(ENABLE_SHARED AND LINKED_10BIT AND LINKED_12BIT)</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?setParamAspectRatio@x265@@YA<wbr>XPEAUx265_param@@HH@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?getParamAspectRatio@x265@@YA<wbr>XPEAUx265_param@@AEAH1@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?general_log_file@x265@@YAXPE<wbr>BUx265_param@@PEBDH1ZZ\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?general_log@x265@@YAXPEBUx26<wbr>5_param@@PEBDH1ZZ\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_api_get_94@x265_10bit@@<wbr>YAPEBUx265_api@@H@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_api_get_94@x265_12bit@@<wbr>YAPEBUx265_api@@H@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_api_query@x265_10bit@@Y<wbr>APEBUx265_api@@HHPEAH@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_api_query@x265_12bit@@Y<wbr>APEBUx265_api@@HHPEAH@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_mdate@x265@@YA_JXZ\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_picturePlaneSize@x265@@<wbr>YAIHHHH@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_ssim2dB@x265@@YANN@Z\n"<wbr>)</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_ssim2dB@x265@@YANN@Z\n"<wbr>)</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_report_simd@x265@@YAXPE<wbr>AUx265_param@@@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_fopen@x265@@YAPEAU_iobu<wbr>f@@PEBD0@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_malloc@x265@@YAPEAX_K@Z<wbr>\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_free@x265@@YAXPEAX@Z\n"<wbr>)</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?x265_atoi@x265@@YAHPEBDAEA_N<wbr>@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?start@Thread@x265@@QEAA_NXZ\<wbr>n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?stop@Thread@x265@@QEAAXXZ\n"<wbr>)</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "??0Thread@x265@@QEAA@XZ\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "??1Thread@x265@@UEAA@XZ\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?g_maxCUDepth@x265@@3IA\n")</div><div>+ if(WINXP_SUPPORT)</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?cond_init@x265@@YAHPEAUCondi<wbr>tionVariable@1@@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?cond_wait@x265@@YAHPEAUCondi<wbr>tionVariable@1@PEAU_RTL_CRITIC<wbr>AL_SECTION@@K@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?cond_destroy@x265@@YAXPEAUCo<wbr>nditionVariable@1@@Z\n")</div><div>+ file(APPEND ${PROJECT_BINARY_DIR}/x265.def "?cond_broadcast@x265@@YAXPEAU<wbr>ConditionVariable@1@@Z\n")</div><div>+ endif()</div><div>+endif()</div><div>+</div><div> include(version) # determine X265_VERSION and X265_LATEST_TAG</div><div> include_directories(. common encoder "${PROJECT_BINARY_DIR}")</div><div> </div><div>@@ -608,7 +642,11 @@ if(ENABLE_CLI)</div><div> if(WIN32 OR NOT ENABLE_SHARED OR INTEL_CXX)</div><div> # The CLI cannot link to the shared library on Windows, it</div><div> # requires internal APIs not exported from the DLL</div><div>- target_link_libraries(cli x265-static ${PLATFORM_LIBS})</div><div>+ if(ENABLE_SHARED AND LINKED_10BIT AND LINKED_12BIT)</div><div>+ target_link_libraries(cli x265-shared ${PLATFORM_LIBS})</div><div>+ else()</div><div>+ target_link_libraries(cli x265-static ${PLATFORM_LIBS})</div><div>+ endif()</div><div> else()</div><div> target_link_libraries(cli x265-shared ${PLATFORM_LIBS})</div><div> endif()</div><span><font color="#888888"><div>-- </div><div>1.7.9.msysgit.0</div><div><br></div></font></span></div><br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/l<wbr>istinfo/x265-devel</a><br>
<br></blockquote></div><br></div>
</blockquote></div></div></div></div></div></div><div><div class="h5"><br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/l<wbr>istinfo/x265-devel</a><br>
<br></div></div></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/<wbr>listinfo/x265-devel</a><br>
<br></blockquote></div><br></div>