<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 16, 2017 at 12:11 AM, Mateusz Brzostek <span dir="ltr"><<a href="mailto:mateusz@msystem.waw.pl" target="_blank">mateusz@msystem.waw.pl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch fixes issue #323 -- crash when encoding to 422. The 'qpCb' index is -2 on Selur's sample file and options.<br>
<br>
Please review.<br>
<br>
Mateusz<br>
<br>
# HG changeset patch<br>
# User Ma0 <<a href="mailto:mateuszb@poczta.onet.pl">mateuszb@poczta.onet.pl</a>><br>
# Date 1487183578 -3600<br>
# Wed Feb 15 19:32:58 2017 +0100<br>
# Node ID 7b55d81f0677b7cbef5a490d90bd9c<wbr>bbf96127cb<br>
# Parent 912dd749bdb53cdd1e251bc3a69e4c<wbr>41ece3b308<br>
SAO: avoid negative indexes in 'x265_lambda2_tab' table<br>
<br>
diff -r 912dd749bdb5 -r 7b55d81f0677 source/encoder/sao.cpp<br>
--- a/source/encoder/sao.cpp Wed Feb 15 12:04:41 2017 +0530<br>
+++ b/source/encoder/sao.cpp Wed Feb 15 19:32:58 2017 +0100<br>
@@ -1234,7 +1234,7 @@<br>
if (m_param->internalCsp == X265_CSP_I420)<br>
qpCb = x265_clip3(m_param->rc.qpMin, m_param->rc.qpMax, (int)g_chromaScale[qp + slice->m_pps->chromaQpOffset[<wbr>0]]);<br>
else<br>
- qpCb = X265_MIN(qp + slice->m_pps->chromaQpOffset[<wbr>0], QP_MAX_SPEC);<br>
+ qpCb = x265_clip3(0, QP_MAX_SPEC, qp + slice->m_pps->chromaQpOffset[<wbr>0]);<br></blockquote><div><br></div><div>This clip should be between m_param->rc.qpMin and m_param->rc.qpMax, as per what is done for the 4:2:0 videos.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
lambda[0] = (int64_t)floor(256.0 * x265_lambda2_tab[qp]);<br>
lambda[1] = (int64_t)floor(256.0 * x265_lambda2_tab[qpCb]); // Use Cb QP for SAO chroma<br>
<br>
<br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/<wbr>listinfo/x265-devel</a><br>
<br></blockquote></div><br></div></div>