<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 25, 2017 at 1:25 AM, Mateusz Brzostek <span dir="ltr"><<a href="mailto:mateusz@msystem.waw.pl" target="_blank">mateusz@msystem.waw.pl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">After tests with GCC from 4.8 to 8.0 I think it is OK to change to c++11 from c++98 (for -DENABLE_DYNAMIC_HDR10=ON and OFF).<br>
<br>
Selur (Hybrid author) wrote that for Clang it should be c++11 instead of gnu++11, so we can set for Clang c++11, for GCC gnu++11.<br></blockquote><div><br></div><div>I would prefer keeping the default support as c++98 as it will cover a wider range of applications that may not be compilable with c++11 and may compile x265 in its build flow.</div><div>It is good to see that performance delta is practically zero.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Please review.<br>
<br>
# HG changeset patch<br>
# User Ma0 <<a href="mailto:mateuszb@poczta.onet.pl">mateuszb@poczta.onet.pl</a>><br>
# Date 1493108195 -7200<br>
# Tue Apr 25 10:16:35 2017 +0200<br>
# Node ID 0923915cba9cf4bde39d0949944694<wbr>56f1b1f22f<br>
# Parent 5bc5e73760cdb61d2674e74cc52149<wbr>fa0603af8a<br>
cmake: switch to c++11 for Clang and GCC<br>
<br>
diff -r 5bc5e73760cd -r 0923915cba9c source/CMakeLists.txt<br>
--- a/source/CMakeLists.txt Sat Apr 22 17:00:28 2017 -0700<br>
+++ b/source/CMakeLists.txt Tue Apr 25 10:16:35 2017 +0200<br>
@@ -187,7 +187,11 @@<br>
if(GCC)<br>
add_definitions(-Wall -Wextra -Wshadow)<br>
add_definitions(-D__STDC_<wbr>LIMIT_MACROS=1)<br>
- add_definitions(-std=gnu++98)<br>
+ if(CLANG)<br>
+ add_definitions(-std=c++11)<br>
+ else()<br>
+ add_definitions(-std=gnu++11)<br>
+ endif()<br>
if(ENABLE_PIC)<br>
add_definitions(-fPIC)<br>
endif(ENABLE_PIC)<br>
<br>
<br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/<wbr>listinfo/x265-devel</a><br>
<br></blockquote></div><br></div></div>