<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><tt>BREF is not set in lowres.SliceType. Only B slice type is
getting set in pic_out sliceType. A similar test is already
performed in finishFrameStats because lowres.sliceType does not
distinguish.</tt><br>
</p>
<br>
<div class="moz-cite-prefix">On 11/19/2017 10:15 PM, Aarthi Priya
Thirumalai wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CANoR=ny9HXbD_Pt0pzqcx14PehqkGu6kax_W8q7PgEqpsVdSJg@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">
<div class="gmail_extra">
<div>
<div class="gmail_signature"
data-smartmail="gmail_signature">
<div>I think this change is not necessary since the
sliceType in pic_out is already set from
m_lowres.sliceType. </div>
<div>So, if the B frame is a B_REF, this is reflected from
the lowres.sliceType already.</div>
<div><br>
</div>
<div>Is there any reason, you are explicitly setting it
again?</div>
</div>
</div>
<br>
<div class="gmail_quote">On Fri, Nov 17, 2017 at 4:41 AM, John
Stebbins <span dir="ltr"><<a
href="mailto:stebbins@jetheaddev.com" target="_blank"
moz-do-not-send="true">stebbins@jetheaddev.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"># HG
changeset patch<br>
# User John Stebbins <<a
href="mailto:jstebbins.hb@gmail.com"
moz-do-not-send="true">jstebbins.hb@gmail.com</a>><br>
# Date 1510861637 28800<br>
# Thu Nov 16 11:47:17 2017 -0800<br>
# Branch stable<br>
# Node ID 5b61fc79bfa2d2bf85f8796001d711<wbr>e5eed1fa1c<br>
# Parent 0b3ba15b33eaed5681f63969702452<wbr>5e9460bb31<br>
encoder: expose BREF slice type in pic_out sliceType<br>
<br>
The AppleTV 4K requires accurate frame dependency
information in the<br>
mp4 sdtp box in order to play 2160p60 content.<br>
<br>
diff -r 0b3ba15b33ea -r 5b61fc79bfa2
source/encoder/encoder.cpp<br>
--- a/source/encoder/encoder.cpp Tue Sep 05
11:21:24 2017 +0530<br>
+++ b/source/encoder/encoder.cpp Thu Nov 16
11:47:17 2017 -0800<br>
@@ -857,6 +857,9 @@<br>
pic_out->pts = outFrame->m_pts;<br>
pic_out->dts = outFrame->m_dts;<br>
pic_out->sliceType =
outFrame->m_lowres.sliceType;<br>
+ if (pic_out->sliceType == X265_TYPE_B
&&<br>
+ IS_REFERENCED(outFrame))<br>
+ pic_out->sliceType =
X265_TYPE_BREF;<br>
pic_out->planes[0] =
recpic->m_picOrg[0];<br>
pic_out->stride[0] =
(int)(recpic->m_stride * sizeof(pixel));<br>
if (m_param->internalCsp !=
X265_CSP_I400)<br>
______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org"
moz-do-not-send="true">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://mailman.videolan.org/<wbr>listinfo/x265-devel</a><br>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
x265-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a>
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="120">--
John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
</pre>
</body>
</html>