<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jan 28, 2018 at 4:00 PM, Ricardo Constantino <span dir="ltr"><<a href="mailto:wiiaboo@gmail.com" target="_blank">wiiaboo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On 28 January 2018 at 06:45, Mario Rohkrämer <span dir="ltr"><<a href="mailto:contact@ligh.de" target="_blank">contact@ligh.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_568588695956423301HOEnZb"><div class="m_568588695956423301h5">Am 23.01.2018, 13:02 Uhr, schrieb Ricardo Constantino <<a href="mailto:wiiaboo@gmail.com" target="_blank">wiiaboo@gmail.com</a>>:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 16 January 2018 at 17:41, Ricardo Constantino <<a href="mailto:wiiaboo@gmail.com" target="_blank">wiiaboo@gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
# HG changeset patch<br>
# User Ricardo Constantino <<a href="mailto:wiiaboo@gmail.com" target="_blank">wiiaboo@gmail.com</a>><br>
# Date 1516124393 0<br>
# Tue Jan 16 17:39:53 2018 +0000<br>
# Node ID 5dbc1653fba42507f44fac6034aa35<wbr>98fb2816cd<br>
# Parent 3712d13c09bf3b9db105c7f97188bc<wbr>c11b8f83cd<br>
CMake: blacklist mingw implicit link libraries<br>
<br>
These also aren't meant to be in pkg-config's Libs.Private.<br>
<br>
diff -r 3712d13c09bf -r 5dbc1653fba4 source/CMakeLists.txt<br>
--- a/source/CMakeLists.txt Sat Jan 13 02:47:30 2018 +0100<br>
+++ b/source/CMakeLists.txt Tue Jan 16 17:39:53 2018 +0000<br>
@@ -647,7 +647,9 @@<br>
endforeach()<br>
if(PLIBLIST)<br>
# blacklist of libraries that should not be in Libs.private<br>
- list(REMOVE_ITEM PLIBLIST "-lc" "-lpthread")<br>
+ list(REMOVE_ITEM PLIBLIST "-lc" "-lpthread" "-lmingwex"<br>
"-lmingwthrd"<br>
+ "-lmingw32" "-lmoldname" "-lmsvcrt" "-ladvapi32" "-lshell32"<br>
+ "-luser32" "-lkernel32")<br>
string(REPLACE ";" " " PRIVATE_LIBS "${PLIBLIST}")<br>
else()<br>
set(PRIVATE_LIBS "")<br>
<br>
</blockquote>
<br>
ping<br>
</blockquote>
<br></div></div>
Hoping for a soon review and commit too...<span class="m_568588695956423301HOEnZb"></span></blockquote><div><br></div></div></div><div>Maybe it would add to the urgency that not fixing this very horribly breaks MinGW static linking with any upstream using x265.<br></div></div></div></div>
<br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/<wbr>listinfo/x265-devel</a><br>
<br></blockquote></div><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Thank you for sending this patch, will commit it asap.</div></div>