<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 30, 2018 at 11:30 AM, Pradeep Ramachandran <span dir="ltr"><<a href="mailto:pradeep@multicorewareinc.com" target="_blank">pradeep@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div><div class="m_-9042991089942646376gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><br></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote"><div><div class="h5">On Mon, Apr 30, 2018 at 10:39 AM, Kavitha Sampath <span dir="ltr"><<a href="mailto:kavitha@multicorewareinc.com" target="_blank">kavitha@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-9042991089942646376h5">On Thu, Apr 26, 2018 at 2:38 PM, Bhavna Hariharan <span dir="ltr"><<a href="mailto:bhavna@multicorewareinc.com" target="_blank">bhavna@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div><div class="m_-9042991089942646376m_-4193734940784667046m_-6376220508042967813gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><br></div></div></div></div></div></div></div>
<br><div class="gmail_quote"><div><div class="m_-9042991089942646376m_-4193734940784667046h5">On Thu, Apr 26, 2018 at 12:41 PM, <span dir="ltr"><<a href="mailto:kavitha@multicorewareinc.com" target="_blank">kavitha@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"># HG changeset patch<br>
# User Kavitha Sampath <<a href="mailto:kavitha@multicorewareinc.com" target="_blank">kavitha@multicorewareinc.com</a>><br>
# Date 1524568273 -19800<br>
# Tue Apr 24 16:41:13 2018 +0530<br>
# Node ID 860c3b32f59e1883b77064b9948e8e<wbr>17decd4641<br>
# Parent 07defe235cde1949c55464952ee1db<wbr>dc10baf5e4<br>
scaling: allow refinement of inter/intra frames when scalefactor is zero<br>
<br>
Also disable analysis of CU with min-cu size when scale factor is zero<br>
<br>
diff -r 07defe235cde -r 860c3b32f59e source/encoder/analysis.cpp<br>
--- a/source/encoder/analysis.cpp Thu Apr 12 16:57:19 2018 +0530<br>
+++ b/source/encoder/analysis.cpp Tue Apr 24 16:41:13 2018 +0530<br>
@@ -523,7 +523,7 @@<br>
int split = 0;<br>
if (m_param->intraRefine && m_param->intraRefine != 4)<br>
{<br>
- split = ((cuGeom.log2CUSize == (uint32_t)(g_log2Size[m_param-<wbr>>minCUSize] + 1)) && bDecidedDepth);<br>
+ split = m_param->scaleFactor && ((cuGeom.log2CUSize == (uint32_t)(g_log2Size[m_param-<wbr>>minCUSize] + 1)) && bDecidedDepth);<br>
if (cuGeom.log2CUSize == (uint32_t)(g_log2Size[m_param-<wbr>>minCUSize]) && !bDecidedDepth)<br>
bAlreadyDecided = false;<br>
}<br>
@@ -2420,7 +2420,7 @@<br>
m_refineLevel = m_param->interRefine;<br>
else<br>
m_refineLevel = m_frame->m_classifyFrame ? 1 : 3;<br>
- int split = (m_refineLevel && cuGeom.log2CUSize == (uint32_t)(g_log2Size[m_param-<wbr>>minCUSize] + 1) && bDecidedDepth);<br>
+ int split = (m_param->scaleFactor && m_refineLevel && cuGeom.log2CUSize == (uint32_t)(g_log2Size[m_param-<wbr>>minCUSize] + 1) && bDecidedDepth);<br>
td.split = split;<br>
<br>
if (bDecidedDepth)<br>
@@ -2494,7 +2494,7 @@<br>
mode.cu.m_mvd[list][pu.puAbsP<wbr>artIdx] = mode.cu.m_mv[list][pu.puAbsPar<wbr>tIdx] - mode.amvpCand[list][ref][mode.<wbr>cu.m_mvpIdx[list][pu.puAbsPart<wbr>Idx]]/*mvp*/;<br>
}<br>
}<br>
- else if(m_param->scaleFactor)<br>
+ else<br>
{<br>
MVField candMvField[MRG_MAX_NUM_CANDS]<wbr>[2]; // double length for mv of both lists<br>
uint8_t candDir[MRG_MAX_NUM_CANDS];<br>
diff -r 07defe235cde -r 860c3b32f59e source/encoder/encoder.cpp<br>
--- a/source/encoder/encoder.cpp Thu Apr 12 16:57:19 2018 +0530<br>
+++ b/source/encoder/encoder.cpp Tue Apr 24 16:41:13 2018 +0530<br>
@@ -2694,7 +2694,7 @@<br>
<br>
if (p->intraRefine)<br>
{<br>
- if (!p->analysisLoad || p->analysisReuseLevel < 10 || !p->scaleFactor)<br>
+ if (!p->analysisLoad || p->analysisReuseLevel < 10)<br>
{<br>
x265_log(p, X265_LOG_WARNING, "Intra refinement requires analysis load, analysis-reuse-level 10, scale factor. Disabling intra refine.\n");<br></blockquote><div><br></div></div></div><div>All the warning messages still say that scale factor is required to enable refinement methods, we can remove that.</div></div></div></div></blockquote></div></div></div></div></div></blockquote><div><br></div></div></div><div>Can you please fix these warning messages and send an updated patch?</div></div></div></div></blockquote><div><br>Sure. I will send an updated patch <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="m_-9042991089942646376h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>I see that you've enabled inter-refine, intra-refine and refine-mv without scale-factor, is there any reason for not enabling dynamic refinement without scale factor? </div></div></div></div></blockquote><div><br></div></div></div><div>Dynamic refinemement + scalefactor 0 requires some more testing. I thought of sending that as a separate patch. <br></div></div></div></div></blockquote><div><br></div></span><div>Sounds good.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
p->intraRefine = 0;<br>
@@ -2703,7 +2703,7 @@<br>
<br>
if (p->interRefine)<br>
{<br>
- if (!p->analysisLoad || p->analysisReuseLevel < 10 || !p->scaleFactor)<br>
+ if (!p->analysisLoad || p->analysisReuseLevel < 10)<br>
{<br>
x265_log(p, X265_LOG_WARNING, "Inter refinement requires analysis load, analysis-reuse-level 10, scale factor. Disabling inter refine.\n");<br>
p->interRefine = 0;<br>
@@ -2737,7 +2737,7 @@<br>
<br>
if (p->mvRefine)<br>
{<br>
- if (!p->analysisLoad || p->analysisReuseLevel < 10 || !p->scaleFactor)<br>
+ if (!p->analysisLoad || p->analysisReuseLevel < 10)<br>
{<br>
x265_log(p, X265_LOG_WARNING, "MV refinement requires analysis load, analysis-reuse-level 10, scale factor. Disabling MV refine.\n");<br>
p->mvRefine = 0;<br>
<br></span>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/l<wbr>istinfo/x265-devel</a><br>
<br></blockquote></div><br></div></div>
</blockquote></span></div><span class="m_-9042991089942646376HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div class="m_-9042991089942646376m_-4193734940784667046gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><span style="color:rgb(0,0,0)">Regards,<br>Kavitha</span></div></div></div></div>
</font></span></div></div>
<br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/l<wbr>istinfo/x265-devel</a><br>
<br></blockquote></span></div><br></div></div>
<br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/<wbr>listinfo/x265-devel</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><span style="color:rgb(0,0,0)">Regards,<br>Kavitha</span></div></div></div></div>
</div></div>