<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 2, 2018 at 9:42 AM, Jayashree Chandrasekaran <span dir="ltr"><<a href="mailto:jayashree.c@multicorewareinc.com" target="_blank">jayashree.c@multicorewareinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">Hi</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">I thought having a variable gives better clarity and that the variable can be used in future if needed. </div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">Thanks for the patch. It also fixes the ffmpeg crash issue reported with the previous commit.</div><div><div class="h5"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div>
<br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 2, 2018 at 12:50 AM, Ma0 <span dir="ltr"><<a href="mailto:mateuszb@poczta.onet.pl" target="_blank">mateuszb@poczta.onet.pl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"># HG changeset patch<br>
# User Ma0 <<a href="mailto:mateuszb@poczta.onet.pl" target="_blank">mateuszb@poczta.onet.pl</a>><br>
# Date 1525200622 -7200<br>
# Tue May 01 20:50:22 2018 +0200<br>
# Branch stable<br>
# Node ID 756a85b9b2db75aef1e1a81745769a<wbr>24c0cdbbe6<br>
# Parent 091f07265371ae6ee2c38795d5554e<wbr>6146acc18b<br>
remove 'bool bEnableavx512' from x265.h<br>
<br>
bEnableavx512 is/should be copy of 16th bit in cpuid so it is<br>
redundant<br></blockquote></div></div></div></div></div></blockquote><div><br></div><div>Pushed to stable. Thanks for the patch.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="h5"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
diff -r 091f07265371 -r 756a85b9b2db source/CMakeLists.txt<br>
--- a/source/CMakeLists.txt Tue Apr 24 10:37:02 2018 +0530<br>
+++ b/source/CMakeLists.txt Tue May 01 20:50:22 2018 +0200<br>
@@ -29,7 +29,7 @@<br>
option(STATIC_LINK_CRT "Statically link C runtime for release builds" OFF)<br>
mark_as_advanced(FPROFILE_USE FPROFILE_GENERATE NATIVE_BUILD)<br>
# X265_BUILD must be incremented each time the public API is changed<br>
-set(X265_BUILD 159)<br>
+set(X265_BUILD 160)<br>
configure_file("${PROJECT_SOU<wbr>RCE_DIR}/<a href="http://x265.def.in" rel="noreferrer" target="_blank">x265.def.in</a>"<br>
"${PROJECT_BINARY_DIR}/<a href="http://x265.de">x265.de</a><wbr>f")<br>
configure_file("${PROJECT_SOU<wbr>RCE_DIR}/<a href="http://x265_config.h.in" rel="noreferrer" target="_blank">x265_config.h.in</a>"<br>
diff -r 091f07265371 -r 756a85b9b2db source/common/param.cpp<br>
--- a/source/common/param.cpp Tue Apr 24 10:37:02 2018 +0530<br>
+++ b/source/common/param.cpp Tue May 01 20:50:22 2018 +0200<br>
@@ -618,20 +618,16 @@<br>
#if X265_ARCH_X86<br>
if (!strcasecmp(value, "avx512"))<br>
{<br>
- p->bEnableavx512 = true;<br>
-<br>
- p->cpuid = X265_NS::cpu_detect(p->bEnable<wbr>avx512);<br>
+ p->cpuid = X265_NS::cpu_detect(true);<br>
if (!(p->cpuid & X265_CPU_AVX512))<br>
x265_log(p, X265_LOG_WARNING, "AVX512 is not supported\n");<br>
}<br>
else<br>
{<br>
- p->bEnableavx512 = false;<br>
-<br>
if (bValueWasNull)<br>
p->cpuid = atobool(value);<br>
else<br>
- p->cpuid = parseCpuName(value, bError, p->bEnableavx512);<br>
+ p->cpuid = parseCpuName(value, bError, false);<br>
}<br>
#else<br>
if (bValueWasNull)<br>
diff -r 091f07265371 -r 756a85b9b2db source/x265.h<br>
--- a/source/x265.h Tue Apr 24 10:37:02 2018 +0530<br>
+++ b/source/x265.h Tue May 01 20:50:22 2018 +0200<br>
@@ -629,14 +629,6 @@<br>
* somehow flawed on your target hardware. The asm function tables are<br>
* process global, the first encoder configures them for all encoders */<br>
int cpuid;<br>
- /*==Assembly features ==*/<br>
- /* x265_param_parse() will detect if the avx512 is enabled (in cli )and set <br>
- * bEnableavx512 to 1 to use avx512 SIMD. By default this flag will not be set , <br>
- * hence the encoding will happen without avx512 assembly primitives even if the cpu has <br>
- * avx512 capabilities. <br>
- * Ensure to use --asm avx512 if you need to encode with avx512 assembly primitives*/<br>
-<br>
- bool bEnableavx512;<br>
/*== Parallelism Features ==*/<br>
<br>
/* Number of concurrently encoded frames between 1 and X265_MAX_FRAME_THREADS<br>
______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/l<wbr>istinfo/x265-devel</a><br>
</blockquote></div><br></div></div></div></div>
<br>______________________________<wbr>_________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/<wbr>listinfo/x265-devel</a><br>
<br></blockquote></div><br></div></div>