<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 18, 2018 at 10:13 PM <<a href="mailto:x265-devel-request@videolan.org" target="_blank">x265-devel-request@videolan.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Send x265-devel mailing list submissions to<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:x265-devel-request@videolan.org" target="_blank">x265-devel-request@videolan.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:x265-devel-owner@videolan.org" target="_blank">x265-devel-owner@videolan.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of x265-devel digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. [PATCH] x265 - Cutree Offset Reuse: Restricted to analysis<br>
reuse level 10 (Akil)<br>
2. Re: [PATCH 1 of 2] Add support for Dolby Vision profile 8.1<br>
(Vittorio Giovara)<br>
3. Re: [PATCH 1 of 2] Add support for Dolby Vision profile 8.1<br>
(Vittorio Giovara)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Tue, 18 Dec 2018 16:57:50 +0530<br>
From: Akil <<a href="mailto:akil@multicorewareinc.com" target="_blank">akil@multicorewareinc.com</a>><br>
To: <a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
Subject: [x265] [PATCH] x265 - Cutree Offset Reuse: Restricted to<br>
analysis reuse level 10<br>
Message-ID:<br>
<CAMGzPfwO=mz=uFLOBA-ydKnF7mpfEikn+4guRDhNfxFgz=<a href="mailto:SQWg@mail.gmail.com" target="_blank">SQWg@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
# HG changeset patch<br>
# User Akil Ayyappan<<a href="mailto:akil@multicorewareinc.com" target="_blank">akil@multicorewareinc.com</a>><br>
# Date 1545126758 -19800<br>
# Tue Dec 18 15:22:38 2018 +0530<br>
# Node ID da15824d3d7753a6372afdb7f438e553046f084e<br>
# Parent 81373aab81dfe2e31a5ef353b1073d8bf1e22502<br>
Cutree Offset Reuse: Restricted to analysis reuse level 10<br>
<br>
diff -r 81373aab81df -r da15824d3d77 source/encoder/encoder.cpp<br>
--- a/source/encoder/encoder.cpp Thu Dec 13 10:55:15 2018 +0530<br>
+++ b/source/encoder/encoder.cpp Tue Dec 18 15:22:38 2018 +0530<br>
@@ -2755,6 +2755,12 @@<br>
x265_log(m_param, X265_LOG_WARNING, "CRF min must be less than<br>
CRF\n");<br>
p->rc.rfConstantMin = 0;<br>
}<br>
+<br>
+ if ((p->analysisLoad || p->analysisSave) && p->rc.cuTree &&<br>
p->analysisReuseLevel < 10)<br>
+ {<br>
+ x265_log(p, X265_LOG_WARNING, "cu-tree works only with analysis<br>
reuse level 10, Disabling cu-tree\n");<br>
+ p->rc.cuTree = 0;<br>
+ }<br>
<br>
if ((p->analysisLoad || p->analysisSave) &&<br>
(p->bDistributeModeAnalysis || p->bDistributeMotionEstimation))<br>
{<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/86047179/attachment-0001.html" rel="noreferrer" target="_blank">http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/86047179/attachment-0001.html</a>><br>
-------------- next part --------------<br>
A non-text attachment was scrubbed...<br>
Name: Cutree offset reuse - bug fix.patch<br>
Type: application/octet-stream<br>
Size: 1006 bytes<br>
Desc: not available<br>
URL: <<a href="http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/86047179/attachment-0001.obj" rel="noreferrer" target="_blank">http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/86047179/attachment-0001.obj</a>><br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Tue, 18 Dec 2018 11:42:02 -0500<br>
From: Vittorio Giovara <<a href="mailto:vittorio.giovara@gmail.com" target="_blank">vittorio.giovara@gmail.com</a>><br>
To: Development for x265 <<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a>><br>
Subject: Re: [x265] [PATCH 1 of 2] Add support for Dolby Vision<br>
profile 8.1<br>
Message-ID:<br>
<<a href="mailto:CABLWnS_WC%2By%2B01uwUGAx_omXsCqL%2B1s4wKNXQEhr-9b_sbcXxg@mail.gmail.com" target="_blank">CABLWnS_WC+y+01uwUGAx_omXsCqL+1s4wKNXQEhr-9b_sbcXxg@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
On Tue, Dec 18, 2018 at 3:07 AM Kirithika Kalirathnam <<br>
<a href="mailto:kirithika@multicorewareinc.com" target="_blank">kirithika@multicorewareinc.com</a>> wrote:<br>
<br>
> # HG changeset patch<br>
> # User kirithika <<a href="mailto:kirithika@multicorewareinc.com" target="_blank">kirithika@multicorewareinc.com</a>><br>
> # Date 1544426306 -19800<br>
> # Mon Dec 10 12:48:26 2018 +0530<br>
> # Node ID 827668cf88a85f8d14b8943c53e3f4c87196e96d<br>
> # Parent 81373aab81dfe2e31a5ef353b1073d8bf1e22502<br>
> Add support for Dolby Vision profile 8.1<br>
><br>
> diff -r 81373aab81df -r 827668cf88a8 doc/reST/cli.rst<br>
> --- a/doc/reST/cli.rst Thu Dec 13 10:55:15 2018 +0530<br>
> +++ b/doc/reST/cli.rst Mon Dec 10 12:48:26 2018 +0530<br>
> @@ -2214,7 +2214,7 @@<br>
> The value is specified as a float or as an integer with the profile<br>
> times 10,<br>
> for example profile 5 is specified as "5" or "5.0" or "50".<br>
><br>
> - Currently only profile 5 enabled, Default 0 (disabled)<br>
> + Currently only profile 5 and profile 8.1 enabled , Default 0<br>
> (disabled)<br>
><br>
> .. option:: --dolby-vision-rpu <filename><br>
><br>
> diff -r 81373aab81df -r 827668cf88a8 source/common/param.cpp<br>
> --- a/source/common/param.cpp Thu Dec 13 10:55:15 2018 +0530<br>
> +++ b/source/common/param.cpp Mon Dec 10 12:48:26 2018 +0530<br>
> @@ -1418,14 +1418,17 @@<br>
> "Invalid refine-intra value, refine-intra levels 0 to 3<br>
> supported");<br>
> CHECK(param->maxAUSizeFactor < 0.5 || param->maxAUSizeFactor > 1.0,<br>
> "Supported factor for controlling max AU size is from 0.5 to 1");<br>
> - CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50),<br>
> - "Unsupported Dolby Vision profile, only profile 5 enabled");<br>
> - if (param->dolbyProfile == 50)<br>
> + CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50) &&<br>
> (param->dolbyProfile != 81),<br>
> + "Unsupported Dolby Vision profile, only profile 5 and profile 8.1<br>
> enabled");<br>
> + if (param->dolbyProfile)<br>
> {<br>
> - CHECK((param->rc.vbvMaxBitrate < 0 && param->rc.vbvBufferSize <<br>
> 0), "Dolby Vision requires VBV settings to enable HRD.\n");<br>
> - CHECK((param->sourceWidth > 3840 || param->sourceHeight > 2160),<br>
> "Maximum supported resolution for Dolby Vision profile - 5 is 4k UHD\n");<br>
> - CHECK((param->internalBitDepth != 10), "Dolby Vision profile - 5<br>
> is Main10 only\n");<br>
> - CHECK((param->internalCsp != X265_CSP_I420), "Dolby Vision<br>
> profile - 5 requires YCbCr 4:2:0 color space\n");<br>
> + CHECK((param->rc.vbvMaxBitrate <= 0 && param->rc.vbvBufferSize <=<br>
> 0), "Dolby Vision requires VBV settings to enable HRD.\n");<br>
><br>
<br>
This is still wrong, the condition should be (param->rc.vbvMaxBitrate <= 0<br>
&& param->rc.vbvBufferSize <= 0) since you need both values set to<br>
something in order to have a working VBV. I mentioned this in a previous<br>
review but it got ignored and the wrong version got pushed...<br>
<br></blockquote><div> Yes,it's a wrong check.I shall fix this check and resend the patch. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> + CHECK((param->sourceWidth > 3840 || param->sourceHeight > 2160),<br>
> "Maximum supported resolution for Dolby Vision profile - 5 and profile -<br>
> 8.1 is 4k UHD\n");<br>
><br>
<br>
nit: double space before "- 8.1"<br>
also this constraint is a bit strange, what about 4k dci? seems odd that it<br>
is not supported...<br></blockquote><div>I shall fix the nit in the updated version of the patch.Regarding 4K dci,</div><div>it is not supported by Dolby Vision profiles 5,8.1 and 8.2.</div><div>The maximum resolution supported for Dolby Vision encodes is 4K-UHD.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
+ CHECK((param->internalBitDepth != 10), "Dolby Vision profile - 5<br>
> and profile - 8.1 is Main10 only\n");<br>
> + CHECK((param->internalCsp != X265_CSP_I420), "Dolby Vision<br>
> profile - 5 and profile - 8.1 requires YCbCr 4:2:0 color space\n");<br>
> +<br>
> + if (param->dolbyProfile == 81)<br>
> + CHECK(!(param->masteringDisplayColorVolume), "Dolby Vision<br>
> profile - 8.1 requires Mastering display color volume information\n");<br>
> }<br>
> #if !X86_64<br>
><br>
-- <br>
Vittorio<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/ec3c5769/attachment-0001.html" rel="noreferrer" target="_blank">http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/ec3c5769/attachment-0001.html</a>><br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Tue, 18 Dec 2018 11:43:00 -0500<br>
From: Vittorio Giovara <<a href="mailto:vittorio.giovara@gmail.com" target="_blank">vittorio.giovara@gmail.com</a>><br>
To: Development for x265 <<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a>><br>
Subject: Re: [x265] [PATCH 1 of 2] Add support for Dolby Vision<br>
profile 8.1<br>
Message-ID:<br>
<<a href="mailto:CABLWnS-mFR0D2%2Bu-0i%2BR2rkvfdyojua07840MBEFDy89p81Zvg@mail.gmail.com" target="_blank">CABLWnS-mFR0D2+u-0i+R2rkvfdyojua07840MBEFDy89p81Zvg@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
On Tue, Dec 18, 2018 at 11:42 AM Vittorio Giovara <<br>
<a href="mailto:vittorio.giovara@gmail.com" target="_blank">vittorio.giovara@gmail.com</a>> wrote:<br>
<br>
><br>
><br>
> On Tue, Dec 18, 2018 at 3:07 AM Kirithika Kalirathnam <<br>
> <a href="mailto:kirithika@multicorewareinc.com" target="_blank">kirithika@multicorewareinc.com</a>> wrote:<br>
><br>
>> # HG changeset patch<br>
>> # User kirithika <<a href="mailto:kirithika@multicorewareinc.com" target="_blank">kirithika@multicorewareinc.com</a>><br>
>> # Date 1544426306 -19800<br>
>> # Mon Dec 10 12:48:26 2018 +0530<br>
>> # Node ID 827668cf88a85f8d14b8943c53e3f4c87196e96d<br>
>> # Parent 81373aab81dfe2e31a5ef353b1073d8bf1e22502<br>
>> Add support for Dolby Vision profile 8.1<br>
>><br>
>> diff -r 81373aab81df -r 827668cf88a8 doc/reST/cli.rst<br>
>> --- a/doc/reST/cli.rst Thu Dec 13 10:55:15 2018 +0530<br>
>> +++ b/doc/reST/cli.rst Mon Dec 10 12:48:26 2018 +0530<br>
>> @@ -2214,7 +2214,7 @@<br>
>> The value is specified as a float or as an integer with the profile<br>
>> times 10,<br>
>> for example profile 5 is specified as "5" or "5.0" or "50".<br>
>><br>
>> - Currently only profile 5 enabled, Default 0 (disabled)<br>
>> + Currently only profile 5 and profile 8.1 enabled , Default 0<br>
>> (disabled)<br>
>><br>
>> .. option:: --dolby-vision-rpu <filename><br>
>><br>
>> diff -r 81373aab81df -r 827668cf88a8 source/common/param.cpp<br>
>> --- a/source/common/param.cpp Thu Dec 13 10:55:15 2018 +0530<br>
>> +++ b/source/common/param.cpp Mon Dec 10 12:48:26 2018 +0530<br>
>> @@ -1418,14 +1418,17 @@<br>
>> "Invalid refine-intra value, refine-intra levels 0 to 3<br>
>> supported");<br>
>> CHECK(param->maxAUSizeFactor < 0.5 || param->maxAUSizeFactor > 1.0,<br>
>> "Supported factor for controlling max AU size is from 0.5 to 1");<br>
>> - CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50),<br>
>> - "Unsupported Dolby Vision profile, only profile 5 enabled");<br>
>> - if (param->dolbyProfile == 50)<br>
>> + CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50) &&<br>
>> (param->dolbyProfile != 81),<br>
>> + "Unsupported Dolby Vision profile, only profile 5 and profile<br>
>> 8.1 enabled");<br>
>> + if (param->dolbyProfile)<br>
>> {<br>
>> - CHECK((param->rc.vbvMaxBitrate < 0 && param->rc.vbvBufferSize <<br>
>> 0), "Dolby Vision requires VBV settings to enable HRD.\n");<br>
>> - CHECK((param->sourceWidth > 3840 || param->sourceHeight > 2160),<br>
>> "Maximum supported resolution for Dolby Vision profile - 5 is 4k UHD\n");<br>
>> - CHECK((param->internalBitDepth != 10), "Dolby Vision profile - 5<br>
>> is Main10 only\n");<br>
>> - CHECK((param->internalCsp != X265_CSP_I420), "Dolby Vision<br>
>> profile - 5 requires YCbCr 4:2:0 color space\n");<br>
>> + CHECK((param->rc.vbvMaxBitrate <= 0 && param->rc.vbvBufferSize<br>
>> <= 0), "Dolby Vision requires VBV settings to enable HRD.\n");<br>
>><br>
><br>
> This is still wrong, the condition should be (param->rc.vbvMaxBitrate <= 0<br>
> && param->rc.vbvBufferSize <= 0)<br>
><br>
<br>
copy paste fail, I meant to write "(param->rc.vbvMaxBitrate <= 0 ||<br>
param->rc.vbvBufferSize <= 0)"<br>
<br>
-- <br>
Vittorio<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/4b371f42/attachment.html" rel="noreferrer" target="_blank">http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/4b371f42/attachment.html</a>><br>
<br>
------------------------------<br>
<br>
Subject: Digest Footer<br>
<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
<br>
<br>
------------------------------<br>
<br>
End of x265-devel Digest, Vol 67, Issue 15<br>
******************************************<br>
</blockquote></div></div>