<div dir="ltr"><div dir="ltr"><br></div><div class="gmail_quote"><div dir="ltr">On Wed, Jan 2, 2019 at 4:59 PM <<a href="mailto:radhakrishnan@multicorewareinc.com" target="_blank">radhakrishnan@multicorewareinc.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"># HG changeset patch<br>
# User Radhakrishnan <<a href="mailto:radhakrishnan@multicorewareinc.com" target="_blank">radhakrishnan@multicorewareinc.com</a>><br>
# Date 1546418753 -19800<br>
# Wed Jan 02 14:15:53 2019 +0530<br>
# Node ID a0e1f722d25634b9d5065d51c270a5a3d00d502c<br>
# Parent 8f1c154aae5e3549eace74e152ab8d05179b7d8b<br>
fix RC version string error in MinGW<br>
<br>
diff -r 8f1c154aae5e -r a0e1f722d256 source/CMakeLists.txt<br>
--- a/source/CMakeLists.txt Sat Dec 29 07:21:21 2018 +0100<br>
+++ b/source/CMakeLists.txt Wed Jan 02 14:15:53 2019 +0530<br>
@@ -578,7 +578,7 @@<br>
<br>
# convert X265_LATEST_TAG (ex: 0.7) and X265_TAG_DISTANCE (ex: 103) to<br>
# @X265_VERSION_MAJOR@,@X265_VERSION_MINOR@,@X265_BRANCH_ID@,@X265_TAG_DISTANCE@<br>
- string(REPLACE "." ";" VERSION_LIST "${X265_LATEST_TAG}")<br>
+ string(REGEX MATCHALL "([0-9]+)" VERSION_LIST "${X265_LATEST_TAG}")<br></blockquote><div><br></div><div>I am not a fan of this fix. It removes the _RC completely making it unclear whether we are on a release candidate tag, or a real release.</div><div>Is only _ the problem, or is any non-numeric character the problem?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
list(GET VERSION_LIST 0 X265_VERSION_MAJOR)<br>
list(GET VERSION_LIST 1 X265_VERSION_MINOR)<br>
set(X265_BRANCH_ID 0) # TODO: 0 - stable, 1 - default or other<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div></div>