<div style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial"><div>Thank you.</div><div><br></div><div>for constant, I explain a little more</div><div>we may declare</div><div>const intptr_t row_n2 = (rowNum - 2)*stride;</div><div><br></div><div>Now,</div><div><br></div><div>src[(rowNum - 2)*stride + (colNum - 2)]</div><div>src[(rowNum - 2)*stride + (colNum - 1)] </div><div><br></div><div>==></div><div><br></div><div>src[row_n2 + (colNum - 2)]</div><div style="position:relative;zoom:1"></div><div id="divNeteaseMailCard"></div><div>src[row_n2 + (colNum - 1)]</div><div><br></div><div>a little better to read.</div><div><br></div>At 2019-07-15 13:58:53, "Akil" <akil@multicorewareinc.com> wrote:<br> <blockquote id="isReplyContent" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid"><div dir="ltr">Thanks for your suggestions, Chen. Have added the matrix in comments. That should make the code more readable. Regarding the last point, I think <span style="color:rgb(0,0,0);font-family:Arial;font-size:14px">(rowNum+X)*stride cannot be replaced by a constant since it tends to change every time.</span></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 12, 2019 at 7:27 AM chen <<a href="mailto:chenm003@163.com">chenm003@163.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="line-height:1.7;color:rgb(0,0,0);font-size:14px;font-family:Arial"><blockquote id="gmail-m_-6498159105604045950isReplyContent" style="padding-left:1ex;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)"><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><br>On Wed, Jul 10, 2019 at 3:41 PM Akil <<a href="mailto:akil@multicorewareinc.com" target="_blank">akil@multicorewareinc.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"># HG changeset patch<br># User Akil Ayyappan<<a href="mailto:akil@multicorewareinc.com" target="_blank">akil@multicorewareinc.com</a>><br># Date 1561035091 -19800<br># Thu Jun 20 18:21:31 2019 +0530<br># Node ID d25c33cc2b748401c5e908af445a0a110e26c3cf<br># Parent 4f6dde51a5db4f9229bddb60db176f16ac98f505<br>AQ: New AQ mode with Variance and Edge information<br><br><br>+ //Applying Gaussian filter on the picture<br>+ src = (pixel*)curFrame->m_fencPic->m_picOrg[0];<br>+ refPic = pic2 + curFrame->m_fencPic->m_lumaMarginY * stride + curFrame->m_fencPic->m_lumaMarginX;<br>+ pixel pixelValue = 0;<br>+ for (int rowNum = 0; rowNum < height; rowNum++)<br>+ {<br>+ for (int colNum = 0; colNum < width; colNum++)<br>+ {<br>+ if ((rowNum >= 2) && (colNum >= 2) && (rowNum != height - 2) && (colNum != width - 2)) //Ignoring the border pixels of the picture<br>+ {<br>+ pixelValue = ((2 * src[(rowNum - 2)*stride + (colNum - 2)] + 4 * src[(rowNum - 2)*stride + (colNum - 1)] + 5 * src[(rowNum - 2)*stride + (colNum)] + 4 * src[(rowNum - 2)*stride + (colNum + 1)] + 2 * src[(rowNum - 2)*stride + (colNum + 2)] +<br>+ 4 * src[(rowNum - 1)*stride + (colNum - 2)] + 9 * src[(rowNum - 1)*stride + (colNum - 1)] + 12 * src[(rowNum - 1)*stride + (colNum)] + 9 * src[(rowNum - 1)*stride + (colNum + 1)] + 4 * src[(rowNum - 1)*stride + (colNum + 2)] +<br>+ 5 * src[(rowNum)*stride + (colNum - 2)] + 12 * src[(rowNum)*stride + (colNum - 1)] + 15 * src[(rowNum)*stride + (colNum)] + 12 * src[(rowNum)*stride + (colNum + 1)] + 5 * src[(rowNum)*stride + (colNum + 2)] +<br>+ 4 * src[(rowNum + 1)*stride + (colNum - 2)] + 9 * src[(rowNum + 1)*stride + (colNum - 1)] + 12 * src[(rowNum + 1)*stride + (colNum)] + 9 * src[(rowNum + 1)*stride + (colNum + 1)] + 4 * src[(rowNum + 1)*stride + (colNum + 2)] +<br>+ 2 * src[(rowNum + 2)*stride + (colNum - 2)] + 4 * src[(rowNum + 2)*stride + (colNum - 1)] + 5 * src[(rowNum + 2)*stride + (colNum)] + 4 * src[(rowNum + 2)*stride + (colNum + 1)] + 2 * src[(rowNum + 2)*stride + (colNum + 2)]) / 159);<br>+ refPic[(rowNum*stride) + colNum] = pixelValue;<br>+ }<br>+ }<br>+ }<br></div><div dir="ltr"><br></div><div dir="ltr">Could you please modify a little?</div><div dir="ltr">Ident or give coif matrix as comment, it will be more readable</div><div dir="ltr">moreover, (rowNum+X)*stride can be replace by constant, it does not affect compiled code performance but help human read code.</div><div dir="ltr"><br></div></blockquote></div>
</blockquote></div>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><i><b>Regards,</b></i><div><i><b>Akil R</b></i></div></div></div>
</blockquote></div>