<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 1, 2019 at 7:13 PM Nomis101 🐝 <<a href="mailto:Nomis101@web.de">Nomis101@web.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am 25.07.19 um 23:58 schrieb Nomis101 🐝:<br>
> Am 25.07.19 um 06:48 schrieb Aruna Matheswaran:<br>
>><br>
>><br>
>> On Wed, Jul 24, 2019 at 9:59 PM Nomis101 🐝 <<a href="mailto:Nomis101@web.de" target="_blank">Nomis101@web.de</a> <mailto:<a href="mailto:Nomis101@web.de" target="_blank">Nomis101@web.de</a>>> wrote:<br>
>><br>
>> Hi Aruna,<br>
>><br>
>> could you specifiy what kind of errors and warnings you see on Windows? I don't have Windows, so I can not test or reproduce.<br>
>><br>
>><br>
>> Please find the attached error log. <br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> Am 24.07.19 um 16:11 schrieb Aruna Matheswaran:<br>
>> > The patch applies on default and builds successfully in Mac and Linux, but gives build warnings and errors in windows. Could you please fix them and resend the patch?<br>
>><br>
>> _______________________________________________<br>
>> x265-devel mailing list<br>
>> <a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a> <mailto:<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a>><br>
>> <a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> Regards,<br>
>> Aruna<br>
>><br>
>> _______________________________________________<br>
>> x265-devel mailing list<br>
>> <a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
>> <a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
>><br>
> <br>
> <br>
> Thanks for the error log. Interestingly, most of the lines the log mentions is not touched by my patch. The error messages look to me, like a compiler was<br>
> used which did not fully support C++11. The Microsoft Visual Studio 12.0 (2013) you used for your test is known to have a limied C++11 implementation.<br>
> See: <a href="https://docs.microsoft.com/en-us/previous-versions/hh567368(v=vs.140)" rel="noreferrer" target="_blank">https://docs.microsoft.com/en-us/previous-versions/hh567368(v=vs.140)</a><br>
> For MSVC12 Compatibility I found this issue, which is still open: <a href="https://github.com/dropbox/json11/issues/2" rel="noreferrer" target="_blank">https://github.com/dropbox/json11/issues/2</a><br>
> I think the only solution for this kind of errors are to use minimum Visual Studio 2015. What do you think? I'm pretty sure it will build on Windows with a<br>
> newer MSVC with full C++11 implementation.<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> <br>
> Best, Simon<br>
> _______________________________________________<br>
> x265-devel mailing list<br>
> <a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
> <a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
> <br>
<br>
<br>
As an alternative, I could cherry-pick json11 #92, to at least fix Issue #373. I don't know if this will help building on Microsoft Visual Studio 12.0, but<br>
it would not introduce so many new lines.<br></blockquote><div><br></div><div>Yes, the patch builds fine with MSVC15, but setting the minimum required MSVC version to 15 for HDR10+ isn't recommended at this point. So as you suggest, please provide the fix for Issue #373; We shall push the fix if it is compatible with MSVC12.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><font face="georgia, serif">Regards,</font><div><font face="georgia, serif">Aruna</font></div></div></div></div>