<div dir="ltr">Hi chen<div> we didn't receive your reply about Part-1, can you resend it? Maybe the content is too large and the mail list blocked it. You can just quote the code where you have questions.</div><div><br></div><div>Thanks.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">chen <<a href="mailto:chenm003@163.com">chenm003@163.com</a>> 于2020年3月18日周三 上午9:07写道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="line-height:1.7;color:rgb(0,0,0);font-size:14px;font-family:Arial"><p style="margin:0px"><br></p><blockquote id="gmail-m_4841379356685928206isReplyContent" style="padding-left:1ex;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div class="gmail_attr" dir="ltr">On Tue, Mar 17, 2020 at 2:59 PM Suyimeng <<a href="mailto:yimeng.su@huawei.com" target="_blank">yimeng.su@huawei.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left:1px solid rgb(204,204,204)">
<div lang="ZH-CN">
<div>
<p class="MsoNormal"><span lang="EN-US" style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:10.5pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-family:Calibri,sans-serif;font-size:11pt">From:</span></b><span lang="EN-US" style="font-family:Calibri,sans-serif;font-size:11pt"> x265-devel [mailto:<a href="mailto:x265-devel-bounces@videolan.org" target="_blank">x265-devel-bounces@videolan.org</a>]
<b>On Behalf Of </b>Gopi Satykrishna Akisetty<br>
<b>Sent:</b> Tuesday, March 17, 2020 4:53 PM<br>
<b>To:</b> Development for x265 <<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a>><br>
<b>Subject:</b> Re: [x265] [PATCH] Add aarch64 support - Part 2<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> </span></p><div><div><blockquote style="border-width:medium medium medium 1pt;border-style:none none none solid;border-color:currentcolor currentcolor currentcolor rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-right:0cm;margin-left:4.8pt"><div><div><div><div><blockquote style="border-width:medium medium medium 1pt;border-style:none none none solid;border-color:currentcolor currentcolor currentcolor rgb(204,204,204);margin:5pt 0cm 5pt 4.8pt;padding:0cm 0cm 0cm 6pt"><div><div><p class="MsoNormal"><span lang="EN-US">
diff --git a/source/common/pixel.cpp b/source/common/pixel.cpp<br>
index 99b84449c..e4f890cd5 100644<br>
--- a/source/common/pixel.cpp<br>
+++ b/source/common/pixel.cpp<br>
@@ -5,6 +5,7 @@<br>
* Mandar Gurav <<a href="mailto:mandar@multicorewareinc.com" target="_blank">mandar@multicorewareinc.com</a>><br>
* Mahesh Pittala <<a href="mailto:mahesh@multicorewareinc.com" target="_blank">mahesh@multicorewareinc.com</a>><br>
* Min Chen <<a href="mailto:min.chen@multicorewareinc.com" target="_blank">min.chen@multicorewareinc.com</a>><br>
+ * Hongbin Liu<<a href="mailto:liuhongbin1@huawei.com" target="_blank">liuhongbin1@huawei.com</a>><br>
*<br>
* This program is free software; you can redistribute it and/or modify<br>
* it under the terms of the GNU General Public License as published by<br>
@@ -265,6 +266,10 @@ int satd4(const pixel* pix1, intptr_t stride_pix1, const pixel* pix2, intptr_t s<br>
{<br>
int satd = 0;<br>
<br>
+#if ENABLE_ASSEMBLY && X265_ARCH_ARM64<br>
+ pixelcmp_t satd_4x4 = x265_pixel_satd_4x4_neon;<br>
+#endif<u></u><u></u></span></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><span lang="EN-US">is there any specific reason why the above code is added?? is this a kind of a temporary fix for the output mismatch between c and asm code? <u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">No, c and asm output is matched. Currently we only complete partial satd primatives. This is a workaround that improve all satd primitives with asm code. Maybe
there is a bad code style.<u></u><u></u></span></p>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><span lang="EN-US">If I understand correctly, you are trying to use a combination of c and asm code for all other kernel sizes that you have not completed asm implementation yet? <u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:10.5pt">Yes, you are right.</span></p></div></div></div></div></div></blockquote><div>ok. If this code block is going to be removed in the future patches, where you will be implementing the asm for remaining satd kernels, then this patch is good to be pushed.</div><div><br></div><div>before push the patches, I want to double check how about response for my review on Part-1?</div><div>I am not sure I missed these email, or my post still in pending.</div><div><br></div></div></div>
</blockquote></div>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div>