<div dir="ltr">addressed review comments from <a class="gmail_plusreply" id="plusReplyChip-0" href="mailto:aruna@multicorewareinc.com" tabindex="-1">@Aruna Matheswaran</a> </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 4, 2021 at 2:30 PM Srikanth Kurapati <<a href="mailto:srikanth.kurapati@multicorewareinc.com">srikanth.kurapati@multicorewareinc.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">From cf1f533ff312eda5896f9cfe00bb842c60a3bf5f Mon Sep 17 00:00:00 2001<br>From: Srikanth Kurapati <<a href="mailto:srikanth.kurapati@multicorewareinc.com" target="_blank">srikanth.kurapati@multicorewareinc.com</a>><br>Date: Thu, 31 Dec 2020 16:35:27 +0530<br>Subject: [PATCH] Fixes cmake backward compatibility issues for version control<br> script<br><br>---<br> source/cmake/Version.cmake | 9 ++++-----<br> 1 file changed, 4 insertions(+), 5 deletions(-)<br><br>diff --git a/source/cmake/Version.cmake b/source/cmake/Version.cmake<br>index a3988d39f..eed6e8b13 100644<br>--- a/source/cmake/Version.cmake<br>+++ b/source/cmake/Version.cmake<br>@@ -47,16 +47,15 @@ if(HG_EXECUTABLE)<br>         set(HG_ARCHETYPE "0")<br>     endif()<br> endif(HG_EXECUTABLE)<br>-find_package(Git QUIET) #No restrictions on Git versions used, any versions from 1.8.x to 2.2.x or later should do.<br>-if(Git_FOUND)<br>-    find_program(GIT_EXECUTABLE git)<br>+find_program(GIT_EXECUTABLE git)  #No restrictions on Git versions used, any versions from 1.8.x to 2.2.x or later should do.<br>+if(GIT_EXECUTABLE)<br>     message(STATUS "GIT_EXECUTABLE ${GIT_EXECUTABLE}")<br>     if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/../.git)<br>         set(GIT_ARCHETYPE "0")<br>     elseif(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/../x265Version.txt)<br>         set(GIT_ARCHETYPE "1")<br>     endif()<br>-endif(Git_FOUND)<br>+endif(GIT_EXECUTABLE)<br> if(HG_ARCHETYPE)<br>     #Read the lines of the archive summary file to extract the version<br>     message(STATUS "SOURCE CODE IS FROM x265 HG ARCHIVED ZIP OR TAR BALL")<br>@@ -122,7 +121,7 @@ elseif(GIT_ARCHETYPE)<br>         set(X265_LATEST_TAG ${git_releasetag})<br>         if(DEFINED git_releasetagdistance)<br>             set(X265_TAG_DISTANCE ${git_releasetagdistance})<br>-            if(X265_TAG_DISTANCE STRGREATER_EQUAL "0")<br>+            if(X265_TAG_DISTANCE STRGREATER "0" OR X265_TAG_DISTANCE STREQUAL "0")<br>                 #for x265 the repository changeset has to be a tag id or commit id after the tag<br>                 #hence mandating it's presence in version file always for valid tag distances.<br>                 if(DEFINED git_repositorychangeset)<font color="#888888"><br>--<br>2.20.1.windows.1</font>  <br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><b style="background-color:rgb(255,255,255)"><font color="#0b5394">With Regards,</font></b><div><b style="background-color:rgb(255,255,255)"><font color="#0b5394">Srikanth Kurapati.</font></b></div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><b style="background-color:rgb(255,255,255)"><font color="#0b5394">With Regards,</font></b><div><b style="background-color:rgb(255,255,255)"><font color="#0b5394">Srikanth Kurapati.</font></b></div></div></div>