<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>I am re-sending ipfilters patch with gzipped attachment.</p>
<p>(The mailing list rejected the previous email with the patch larger than 200K.)<br>
</p>
<p><br>
</p>
<p>Sebastian<br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Wednesday, September 15, 2021 8:21 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi,<br>
</p>
<p><br>
</p>
<p>Please find attached a patch that ports all ip filters to arm64.<br>
</p>
<p>The patch is <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">
to be applied </span><span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">on top of p2s patch</span>.<br>
</p>
<p>For the moment only 8bit is accelerated. I am still working on 10bit and 12bit.<br>
</p>
<p>With this patch I have seen better results on Graviton2 compared to the NEON intrinsics compiled with gcc-11 and clang-12.<br>
</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Sebastian</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> x265-devel <x265-devel-bounces@videolan.org> on behalf of Pop, Sebastian <spop@amazon.com><br>
<b>Sent:</b> Wednesday, September 15, 2021 7:15 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty<br>
<b>Cc:</b> Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi,<br>
</p>
<p><span style="font-size:12pt">Here is the updated patch for p2s on top of</span><br>
</p>
<p><span style="font-size:12pt"><a href="https://bitbucket.org/multicoreware/x265_git/commits/4bf31dc15fb6d1f93d12ecf21fad5e695f0db5c0" title="https://bitbucket.org/multicoreware/x265_git/commits/4bf31dc15fb6d1f93d12ecf21fad5e695f0db5c0
Ctrl+Click or tap to follow the link">https://bitbucket.org/multicoreware/x265_git/commits/4bf31dc15fb6d1f93d12ecf21fad5e695f0db5c0</a><br>
</span></p>
<p><span style="font-size:12pt"><br>
</span></p>
<p>Sebastian<br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Thursday, September 9, 2021 3:45 AM<br>
<b>To:</b> Gopi Satykrishna Akisetty<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E; Development for x265<br>
<b>Subject:</b> Re: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi Gopi,</p>
<p><br>
</p>
<p>Please see attached the patch for p2s.</p>
<p>The patch passes TestBench for 8bit, 10bit, and 12bit configurations.<br>
</p>
<p><br>
</p>
<p>Next, I will submit all the ipfilter functions.​<br>
</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Sebastian <br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Wednesday, September 8, 2021 12:40 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E; Development for x265<br>
<b>Subject:</b> Re: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Thanks Gopi for the instructions.<br>
</p>
<p>I was able to see TestBench failing for 10bit and 12bit configurations.<br>
</p>
<p><br>
</p>
<p>Sebastian​<br>
</p>
<div style="color:rgb(33,33,33)">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Gopi Satykrishna Akisetty <gopi.satykrishna@multicorewareinc.com><br>
<b>Sent:</b> Wednesday, September 8, 2021 10:18 AM<br>
<b>To:</b> Pop, Sebastian<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E; Development for x265<br>
<b>Subject:</b> RE: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<div class="WordSection1">
<table class="MsoTableGrid" border="1" cellspacing="0" cellpadding="0" style="border-collapse:collapse; border:none">
<tbody>
<tr style="height:15.25pt">
<td width="711" valign="top" style="width:842.35pt; border:solid #ED7D31 1.5pt; padding:0in 5.4pt 0in 5.4pt; height:15.25pt">
<p><strong><span style="background:#FFFF99">CAUTION</span></strong><span style="background:#FFFF99">: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.</span></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Sep 7, 2021 at 8:06 PM Pop, Sebastian <<a href="mailto:spop@amazon.com">spop@amazon.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">
+x265-devel@ mailing list<br>
</p>
<div><br>
</div>
<p>Hi Gopi,<br>
</p>
<p><br>
</p>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Thanks for your feedback. <span style="font-size:12pt">I will check the errors you reported.</span></p>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><span style="font-size:12pt">I will fix all the issues</span><span style="font-size:12pt"> and re-submit </span><span style="font-size:12pt">the p2s patch for review</span><span style="font-size:12pt">.</span><br>
</p>
<div><span style="font-size:12pt"></span></div>
<span style="font-size:12pt">Could you please send me the exact cmake flags and the commands you used to run the smoke tests?</span>
<div>I want to make sure my testing covers the use cases you have seen failing.<br>
</div>
</div>
</blockquote>
<div>You can use the smoke-tests.txt file from the test folder in the repo <a href="https://github.com/videolan/x265/blob/master/source/test/smoke-tests.txt">https://github.com/videolan/x265/blob/master/source/test/smoke-tests.txt</a></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<div><span style="font-size:12pt"></span>
<p><br>
</p>
<p>I see the following cmake flags in <a href="https://github.com/videolan/x265/blob/master/build/linux/multilib.sh#L6" target="_blank">https://github.com/videolan/x265/blob/master/build/linux/multilib.sh#L6</a><br>
</p>
<p># cmake ../../../source -DHIGH_BIT_DEPTH=ON -DMAIN12=ON<br>
</p>
</div>
</div>
</blockquote>
<div>For 8bit you can set WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=OFF</div>
<div>For 10bit you can set WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=ON</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<div>
<p></p>
<p>With this configuration the current code in x265/source/common/aarch64 fails to build.<br>
</p>
<p>Would it be ok to remove the code in <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">x265/source/common/aarch64 and submit the p2s routines working with 8bit, 10bit, and 12bit configurations?</span><br>
</p>
<p><br>
</p>
<p>On my side I cleaned up aarch64/ipfilter8.S and have it complete with all the functions that x86_64 implements.<br>
</p>
<p>I will make sure ipfilter functions pass TestBench with and without <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">
HIGH_BIT_DEPTH</span> before I submit the patch for review.<br>
</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Sebastian<br>
</p>
<div style="color:rgb(33,33,33)">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_1502158474132214040divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Gopi Satykrishna Akisetty <<a href="mailto:gopi.satykrishna@multicorewareinc.com" target="_blank">gopi.satykrishna@multicorewareinc.com</a>><br>
<b>Sent:</b> Monday, September 6, 2021 12:00 AM<br>
<b>To:</b> Pop, Sebastian<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E<br>
<b>Subject:</b> RE: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div><br>
</div>
</div>
<div>
<div>
<div dir="ltr">Hi Pop Sebastian,
<div>Sorry for the late reply. We have been running some tests at our end and found that the patch is failing when HIGH_BIT_DEPTH is enabled i.e testbench is failing and also there are output changes with decoder errors in the smoke tests for HIGH_BIT_DEPTH
enabled builds. Can you check them at your end once.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Gopi.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Aug 19, 2021 at 2:44 AM <<a href="mailto:spop@amazon.com" target="_blank">spop@amazon.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
Hello Gopi,<br>
<br>
Please see attached the first patch of the series.<br>
It ports p2s function.<br>
Please let me know if the format of the patch is fine.<br>
I will submit the next patches following your guidelines.<br>
<br>
Thanks,<br>
Sebastian<br>
<br>
<br>
On 8/18/21 6:46 AM, Gopi Satykrishna Akisetty wrote:<br>
> Hello Pop Sebastian,<br>
> Thanks for the contribution of ARM64 patches. Can you resend all the <br>
> final patches that have been reviewed by Min Chen over the development <br>
> mailing list, so that it is easier to check and commit each of them <br>
> individually instead of one big combined patch. Please include <br>
> performance numbers and the specs of the test machine used in the <br>
> patch as part of the commit message. Also send all these patches in a <br>
> sequence so that it is easier to apply them and check.<br>
><br>
> Thanks,<br>
> Gopi.<br>
><br>
<br>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>