<div style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial"><div style="margin: 0;">Hi Sebastian,</div><div style="margin: 0;"><br></div><div style="margin: 0;">Thank you for your contribution, I reviewed and made some of comments, could you please take a look.</div><div style="margin: 0;"><br></div><div style="margin: 0;">Regards,</div><div style="margin: 0;">Min Chen</div><div style="position:relative;zoom:1"></div><div id="divNeteaseMailCard"></div><p style="margin: 0;"><br></p><p>At 2022-01-19 23:25:30, "Pop, Sebastian" <spop@amazon.com> wrote:</p><blockquote id="isReplyContent" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
<p>Hi Gopi,<br>
</p>
<p><br>
</p>
<p>Please find attached a patch that ports scanPosLast to arm64 NEON.<br>
</p>
<p><span style="font-size: 12pt;"><br>
</span></p>
<p><span style="font-size: 12pt;"> </span><span style="font-size: 12pt;">scanPosLast 5.08x 842.11 4277.83</span><br>
</p>
<p><br>
</p>
<p>When encoding a video where scanPosLast was accounting for 4.66% of the total samples,</p>
<p>with the patch the function now accounts for 1.4% of the total samples.<br>
</p>
<p><br>
</p>
<p>I still see costCoeffNxN_c at 3.5% on some profiles, and I will send a patch to implement it for arm64.<br>
</p>
<p><br>
</p>
<p>Would it be possible to commit all the arm64 NEON patches to x265 git?<br>
</p>
<p>How can I help to speed up the process?<br>
</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Sebastian<br>
</p>
<p><br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> x265-devel <x265-devel-bounces@videolan.org> on behalf of Pop, Sebastian <spop@amazon.com><br>
<b>Sent:</b> Thursday, December 9, 2021 4:48 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi,<br>
</p>
<p><br>
</p>
<p>Attached is a patch for weight_pp and weight_sp for arm64.<br>
</p>
<p><br>
</p>
<div> weight_pp 4.66x 182.14 849.07</div>
<div> weight_sp 1.16x 621.23 718.51</div>
<div><br>
</div>
<p>Sebastian</p>
<p><br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> x265-devel <x265-devel-bounces@videolan.org> on behalf of Pop, Sebastian <spop@amazon.com><br>
<b>Sent:</b> Monday, November 15, 2021 5:43 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi,<br>
</p>
<p><br>
</p>
<p>Here is a patch to implement 8bit normFact on arm64.<br>
</p>
<p><br>
</p>
<div>normFact[8x8]<span style="white-space:pre"> </span>6.98x <span style="white-space:pre">
</span>11.99 <span style="white-space:pre"></span>83.66 </div>
<div>normFact[16x16]<span style="white-space:pre"> </span>6.40x <span style="white-space:pre">
</span>53.95 <span style="white-space:pre"></span>345.39 </div>
<div>normFact[32x32]<span style="white-space:pre"> </span>5.54x <span style="white-space:pre">
</span>245.17 <span style="white-space:pre"> </span>1359.08 </div>
<div>normFact[64x64]<span style="white-space:pre"> </span>5.45x <span style="white-space:pre">
</span>996.32 <span style="white-space:pre"> </span>5433.85 </div>
<div><br>
Sebastian<br>
</div>
<p><br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> x265-devel <x265-devel-bounces@videolan.org> on behalf of Pop, Sebastian <spop@amazon.com><br>
<b>Sent:</b> Monday, November 15, 2021 4:58 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi,<br>
</p>
<p><br>
</p>
<p>Here is a patch to implement 8bit ssimDist on top of the previous patches.<br>
</p>
<p>Tested on arm64-linux.<br>
</p>
<p><br>
</p>
<div>ssimDist[4x4] 3.66x 8.67 31.72</div>
<div>ssimDist[8x8] 4.69x 27.65 129.62</div>
<div>ssimDist[16x16] 5.00x 106.38 531.60</div>
<div>ssimDist[32x32] 6.98x 434.51 3034.55</div>
<div>ssimDist[64x64] 6.72x 1792.07 12046.95</div>
<div><br>
</div>
<p>Sebastian<br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> x265-devel <x265-devel-bounces@videolan.org> on behalf of Pop, Sebastian <spop@amazon.com><br>
<b>Sent:</b> Monday, October 25, 2021 7:08 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi Gopi,<br>
</p>
<p><br>
</p>
<p>Please find attached the updated patches to fix an issue in sad_x4[12x16] where I was using v31 uninitialized.<br>
</p>
<p>The patch now passes TestBench and produces the same output on the following command:<br>
</p>
<p>./x265 --input=/home/ubuntu/old_town_cross_444_720p50.y4m --preset slower --crf 4 --cu-lossless --no-info --hash=1 --psnr --ssim -o out.hevc<br>
</p>
<p><span style="font-size:12pt"><br>
</span></p>
<p><span style="font-size:12pt">I have also tested the patch with</span><span style="font-size:12pt"> ./build/linux/mulitlib.sh.</span><br>
</p>
<p><br>
</p>
<p>Sebastian<br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Friday, October 22, 2021 10:30 AM<br>
<b>To:</b> Gopi Satykrishna Akisetty<br>
<b>Cc:</b> Siva Viswanathan; Janani T E; Liwei Wang<br>
<b>Subject:</b> Re: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Thanks Gopi for the clarification.<br>
</p>
<p>I will make sure the values in the following fields remain the same with and without the patches:<br>
</p>
<p>"<span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:15px; background-color:rgb(255,255,255)">222539.85 kb/s, Avg QP:11.68, Global PSNR: 47.406, SSIM Mean Y: 0.9957770 (23.744 dB)</span>"<br>
</p>
<p><br>
</p>
<div style="color:rgb(33,33,33)">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Gopi Satykrishna Akisetty <gopi.satykrishna@multicorewareinc.com><br>
<b>Sent:</b> Friday, October 22, 2021 10:19 AM<br>
<b>To:</b> Pop, Sebastian<br>
<b>Cc:</b> Siva Viswanathan; Janani T E; Liwei Wang<br>
<b>Subject:</b> RE: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<div class="WordSection1">
<table class="MsoTableGrid ntes_not_fresh_table" border="1" cellspacing="0" cellpadding="0" style="border-collapse:collapse; border:none">
<tbody>
<tr style="height:15.25pt">
<td width="711" valign="top" style="width:842.35pt; border:solid #ED7D31 1.5pt; padding:0in 5.4pt 0in 5.4pt; height:15.25pt">
<p><strong><span style="background:#FFFF99">CAUTION</span></strong><span style="background:#FFFF99">: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.</span></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi Sebastian,
<div><br>
</div>
<div>The bitstream generated on the master tip is not the same as the bitstream generated after applying the eight patches. You can get this info from the logs where bitrate, PSNR, SSIM values are printed. </div>
<div>For ex:</div>
<div>encoded 500 frames in 1823.56s (0.27 fps), 222539.85 kb/s, Avg QP:11.68, Global PSNR: 47.406, SSIM Mean Y: 0.9957770 (23.744 dB)<br>
</div>
<div>vs</div>
<div>encoded 500 frames in 1595.87s (0.31 fps), 222530.92 kb/s, Avg QP:11.68, Global PSNR: 47.405, SSIM Mean Y: 0.9957767 (23.743 dB)<br>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Gopi.</div>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Oct 22, 2021 at 8:43 PM Pop, Sebastian <<a href="mailto:spop@amazon.com">spop@amazon.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Hi Gopi,<br>
</p>
<p>Could you please let me know exactly what I need to pay attention to in the diff between logs on "Master Tip" and logs "after applying 8 patches".<br>
</p>
<p>i.e., which numbers in the diff need to be exactly the same.</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Sebastian <br>
</p>
<p><br>
</p>
<div style="color:rgb(33,33,33)">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Gopi Satykrishna Akisetty <<a href="mailto:gopi.satykrishna@multicorewareinc.com" target="_blank">gopi.satykrishna@multicorewareinc.com</a>><br>
<b>Sent:</b> Friday, October 22, 2021 9:25 AM<br>
<b>To:</b> Pop, Sebastian<br>
<b>Cc:</b> Siva Viswanathan; Janani T E; Liwei Wang<br>
<b>Subject:</b> RE: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<div>
<table border="1" cellspacing="0" cellpadding="0" style="border-collapse:collapse; border:none" class="ntes_not_fresh_table">
<tbody>
<tr style="height:15.25pt">
<td width="711" valign="top" style="width:842.35pt; border:1.5pt solid rgb(237,125,49); padding:0in 5.4pt; height:15.25pt">
<p><strong><span style="background:rgb(255,255,153)">CAUTION</span></strong><span style="background:rgb(255,255,153)">: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know
the content is safe.</span></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<div>
<div dir="ltr">Hi Sebastian,
<div><br>
</div>
<div>We are seeing some output changes after applying the 8 patches shared above by you. I have attached some sample logs below. Can you look into this issue and fix the output changes with the patches.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Gopi.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Oct 6, 2021 at 11:09 PM Pop, Sebastian <<a href="mailto:spop@amazon.com" target="_blank">spop@amazon.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Hi,<br>
</p>
<p><br>
</p>
<p>please find attached the patches to optimize <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">with arm64 </span><span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">assembly</span> about
85% of the x265 routines optimized for the x86 target.<br>
</p>
<p>The patches have been tested on AWS Graviton2 arm64-linux and on Apple M1 processor.<br>
</p>
<p>The assembly optimized routines are faster than the reference C and faster than the arm64 intrinsics optimized routines.<br>
</p>
<p><br>
</p>
<p><span style="font-size:12pt">I will subm</span><span style="font-size:12pt">it additional patches to optimize for arm64</span><span style="font-size:12pt"> the remaining 15% of the functions</span><span style="font-size:12pt">.</span><br>
</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Sebastian<br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Friday, September 24, 2021 12:46 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Cc:</b> Siva Viswanathan; Janani T E; Liwei Wang<br>
<b>Subject:</b> Re: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>I am resubmitting all the arm64 x265 patches as a compressed attachment because the x265 mailing has a limit on email size.</p>
<p><br>
</p>
<p>Sebastian <br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Friday, September 24, 2021 12:36 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Cc:</b> Siva Viswanathan; Janani T E; Liwei Wang<br>
<b>Subject:</b> Re: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Thanks for the bug report.<br>
</p>
<p>I was able to reproduce the build errors on an Apple M1.<br>
</p>
<p>Please see attached the amended patches that pass TestBench on M1.<br>
</p>
<p>I also have fixed builds with clang on arm64-linux.<br>
</p>
<p><br>
</p>
<p>Next: I will submit for review blockcopy.S, and I will make sure it passes on arm64-linux with gcc and clang and on Apple M1.<br>
</p>
<p><br>
</p>
<p><span style="font-size:12pt">Sebastian</span><span style="font-size:12pt"> </span><br>
</p>
<p><br>
</p>
<div style="color:rgb(33,33,33)">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Gopi Satykrishna Akisetty <<a href="mailto:gopi.satykrishna@multicorewareinc.com" target="_blank">gopi.satykrishna@multicorewareinc.com</a>><br>
<b>Sent:</b> Monday, September 20, 2021 10:45 PM<br>
<b>To:</b> Pop, Sebastian<br>
<b>Cc:</b> Siva Viswanathan; Janani T E; Liwei Wang<br>
<b>Subject:</b> RE: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<div>
<table border="1" cellspacing="0" cellpadding="0" style="border-collapse:collapse; border:none" class="ntes_not_fresh_table">
<tbody>
<tr style="height:15.25pt">
<td width="711" valign="top" style="width:842.35pt; border:1.5pt solid rgb(237,125,49); padding:0in 5.4pt; height:15.25pt">
<p><strong><span style="background:rgb(255,255,153)">CAUTION</span></strong><span style="background:rgb(255,255,153)">: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know
the content is safe.</span></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<div>
<div dir="ltr">
<div dir="ltr">Hi,
<div>We are seeing build errors with the patches on Apple M1 with AppleClang 12.0.5.12050022. Can you check and send the updated patches?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Gopi.</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Sep 16, 2021 at 6:56 AM Pop, Sebastian <<a href="mailto:spop@amazon.com" target="_blank">spop@amazon.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<p>I am re-sending ipfilters patch with gzipped attachment.</p>
<p>(The mailing list rejected the previous email with the patch larger than 200K.)<br>
</p>
<p><br>
</p>
<p>Sebastian<br>
</p>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226gmail-m_-4547257414440593992divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Wednesday, September 15, 2021 8:21 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty; Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi,<br>
</p>
<p><br>
</p>
<p>Please find attached a patch that ports all ip filters to arm64.<br>
</p>
<p>The patch is <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">
to be applied </span><span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">on top of p2s patch</span>.<br>
</p>
<p>For the moment only 8bit is accelerated. I am still working on 10bit and 12bit.<br>
</p>
<p>With this patch I have seen better results on Graviton2 compared to the NEON intrinsics compiled with gcc-11 and clang-12.<br>
</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Sebastian</p>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226gmail-m_-4547257414440593992divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> x265-devel <<a href="mailto:x265-devel-bounces@videolan.org" target="_blank">x265-devel-bounces@videolan.org</a>> on behalf of Pop, Sebastian <<a href="mailto:spop@amazon.com" target="_blank">spop@amazon.com</a>><br>
<b>Sent:</b> Wednesday, September 15, 2021 7:15 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty<br>
<b>Cc:</b> Development for x265<br>
<b>Subject:</b> Re: [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi,<br>
</p>
<p><span style="font-size:12pt">Here is the updated patch for p2s on top of</span><br>
</p>
<p><span style="font-size:12pt"><a href="https://bitbucket.org/multicoreware/x265_git/commits/4bf31dc15fb6d1f93d12ecf21fad5e695f0db5c0" title="https://bitbucket.org/multicoreware/x265_git/commits/4bf31dc15fb6d1f93d12ecf21fad5e695f0db5c0
Ctrl+Click or tap to follow the link" target="_blank">https://bitbucket.org/multicoreware/x265_git/commits/4bf31dc15fb6d1f93d12ecf21fad5e695f0db5c0</a><br>
</span></p>
<p><span style="font-size:12pt"><br>
</span></p>
<p>Sebastian<br>
</p>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226gmail-m_-4547257414440593992divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Thursday, September 9, 2021 3:45 AM<br>
<b>To:</b> Gopi Satykrishna Akisetty<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E; Development for x265<br>
<b>Subject:</b> Re: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Hi Gopi,</p>
<p><br>
</p>
<p>Please see attached the patch for p2s.</p>
<p>The patch passes TestBench for 8bit, 10bit, and 12bit configurations.<br>
</p>
<p><br>
</p>
<p>Next, I will submit all the ipfilter functions.<br>
</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Sebastian <br>
</p>
<p><br>
</p>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226gmail-m_-4547257414440593992divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Pop, Sebastian<br>
<b>Sent:</b> Wednesday, September 8, 2021 12:40 PM<br>
<b>To:</b> Gopi Satykrishna Akisetty<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E; Development for x265<br>
<b>Subject:</b> Re: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<p>Thanks Gopi for the instructions.<br>
</p>
<p>I was able to see TestBench failing for 10bit and 12bit configurations.<br>
</p>
<p><br>
</p>
<p>Sebastian<br>
</p>
<div style="color:rgb(33,33,33)">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226gmail-m_-4547257414440593992divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Gopi Satykrishna Akisetty <<a href="mailto:gopi.satykrishna@multicorewareinc.com" target="_blank">gopi.satykrishna@multicorewareinc.com</a>><br>
<b>Sent:</b> Wednesday, September 8, 2021 10:18 AM<br>
<b>To:</b> Pop, Sebastian<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E; Development for x265<br>
<b>Subject:</b> RE: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div> </div>
</div>
<div>
<div>
<table border="1" cellspacing="0" cellpadding="0" style="border-collapse:collapse; border:none" class="ntes_not_fresh_table">
<tbody>
<tr style="height:15.25pt">
<td width="711" valign="top" style="width:842.35pt; border:1.5pt solid rgb(237,125,49); padding:0in 5.4pt; height:15.25pt">
<p><strong><span style="background:rgb(255,255,153)">CAUTION</span></strong><span style="background:rgb(255,255,153)">: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know
the content is safe.</span></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Sep 7, 2021 at 8:06 PM Pop, Sebastian <<a href="mailto:spop@amazon.com" target="_blank">spop@amazon.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">
+x265-devel@ mailing list<br>
</p>
<div><br>
</div>
<p>Hi Gopi,<br>
</p>
<p><br>
</p>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Thanks for your feedback. <span style="font-size:12pt">I will check the errors you reported.</span></p>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><span style="font-size:12pt">I will fix all the issues</span><span style="font-size:12pt"> and re-submit </span><span style="font-size:12pt">the p2s patch for review</span><span style="font-size:12pt">.</span><br>
</p>
<div><span style="font-size:12pt"></span></div>
<span style="font-size:12pt">Could you please send me the exact cmake flags and the commands you used to run the smoke tests?</span>
<div>I want to make sure my testing covers the use cases you have seen failing.<br>
</div>
</div>
</blockquote>
<div>You can use the smoke-tests.txt file from the test folder in the repo <a href="https://github.com/videolan/x265/blob/master/source/test/smoke-tests.txt" target="_blank">https://github.com/videolan/x265/blob/master/source/test/smoke-tests.txt</a></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<div><span style="font-size:12pt"></span>
<p><br>
</p>
<p>I see the following cmake flags in <a href="https://github.com/videolan/x265/blob/master/build/linux/multilib.sh#L6" target="_blank">https://github.com/videolan/x265/blob/master/build/linux/multilib.sh#L6</a><br>
</p>
<p># cmake ../../../source -DHIGH_BIT_DEPTH=ON -DMAIN12=ON<br>
</p>
</div>
</div>
</blockquote>
<div>For 8bit you can set WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=OFF</div>
<div>For 10bit you can set WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=ON</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif">
<div>
<p></p>
<p>With this configuration the current code in x265/source/common/aarch64 fails to build.<br>
</p>
<p>Would it be ok to remove the code in <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">x265/source/common/aarch64 and submit the p2s routines working with 8bit, 10bit, and 12bit configurations?</span><br>
</p>
<p><br>
</p>
<p>On my side I cleaned up aarch64/ipfilter8.S and have it complete with all the functions that x86_64 implements.<br>
</p>
<p>I will make sure ipfilter functions pass TestBench with and without <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px; background-color:rgb(255,255,255)">
HIGH_BIT_DEPTH</span> before I submit the patch for review.<br>
</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Sebastian<br>
</p>
<div style="color:rgb(33,33,33)">
<hr style="display:inline-block; width:98%">
<div id="gmail-m_-6043738059339760945gmail-m_8953404848488009226gmail-m_-4547257414440593992gmail-m_1502158474132214040divRplyFwdMsg" dir="ltr">
<font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Gopi Satykrishna Akisetty <<a href="mailto:gopi.satykrishna@multicorewareinc.com" target="_blank">gopi.satykrishna@multicorewareinc.com</a>><br>
<b>Sent:</b> Monday, September 6, 2021 12:00 AM<br>
<b>To:</b> Pop, Sebastian<br>
<b>Cc:</b> Liwei Wang; Siva Viswanathan; Janani T E<br>
<b>Subject:</b> RE: [EXTERNAL] [x265] [arm64] Status and combined patch</font>
<div><br>
</div>
</div>
<div>
<div>
<div dir="ltr">Hi Pop Sebastian,
<div>Sorry for the late reply. We have been running some tests at our end and found that the patch is failing when HIGH_BIT_DEPTH is enabled i.e testbench is failing and also there are output changes with decoder errors in the smoke tests for HIGH_BIT_DEPTH
enabled builds. Can you check them at your end once.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Gopi.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Aug 19, 2021 at 2:44 AM <<a href="mailto:spop@amazon.com" target="_blank">spop@amazon.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
Hello Gopi,<br>
<br>
Please see attached the first patch of the series.<br>
It ports p2s function.<br>
Please let me know if the format of the patch is fine.<br>
I will submit the next patches following your guidelines.<br>
<br>
Thanks,<br>
Sebastian<br>
<br>
<br>
On 8/18/21 6:46 AM, Gopi Satykrishna Akisetty wrote:<br>
> Hello Pop Sebastian,<br>
> Thanks for the contribution of ARM64 patches. Can you resend all the <br>
> final patches that have been reviewed by Min Chen over the development <br>
> mailing list, so that it is easier to check and commit each of them <br>
> individually instead of one big combined patch. Please include <br>
> performance numbers and the specs of the test machine used in the <br>
> patch as part of the commit message. Also send all these patches in a <br>
> sequence so that it is easier to apply them and check.<br>
><br>
> Thanks,<br>
> Gopi.<br>
><br>
<br>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></div>