<div style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial"><div style="margin: 0;">Hi Song,</div><div style="margin: 0;"><br></div><div style="margin: 0;">Thank you for your patch.</div><div style="margin: 0;"><br></div><div style="margin: 0;">However, syntax of ':lo12:' depends on compiler, so more general LDR is better in here.</div><div style="margin: 0;"><br></div><div style="margin: 0;">Regards,</div><div style="margin: 0;">Min Chen</div><pre>At 2022-08-30 02:33:37, "Fangrui Song" <maskray@google.com> wrote:
>The ldr pseudo-instruction uses a literal pool, which is less efficient
>and does not decrease the code size.
>---
> source/common/aarch64/asm.S | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/source/common/aarch64/asm.S b/source/common/aarch64/asm.S
>index 399c37cf2..2506f50aa 100644
>--- a/source/common/aarch64/asm.S
>+++ b/source/common/aarch64/asm.S
>@@ -130,11 +130,9 @@ ELF     .size   \name, . - \name
>         adrp            \rd, \val+(\offset)
>         add             \rd, \rd, :lo12:\val+(\offset)
>   .endif
>-#elif defined(PIC)
>+#else
>         adrp            \rd, \val+(\offset)
>         add             \rd, \rd, :lo12:\val+(\offset)
>-#else
>-        ldr             \rd, =\val+\offset
> #endif
> .endm
> 
>-- 
>2.37.2.672.g94769d06f0-goog
>
>_______________________________________________
>x265-devel mailing list
>x265-devel@videolan.org
>https://mailman.videolan.org/listinfo/x265-devel
</pre></div>